virDomainNetDefFormat: Modernize XML formatting

[PATCH 0/7] virDomainNetDefFormat: Modernize XML formatting

Michal Privoznik posted 7 patches 1 year, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1675183375.git.mprivozn@redhat.com

src/conf/domain_conf.c               | 151 ++++++++++-----------------
tests/qemuxml2argvdata/net-mtu.xml   |  26 +++--
tests/qemuxml2xmloutdata/net-mtu.xml |  72 +------------
3 files changed, 74 insertions(+), 175 deletions(-)
mode change 100644 => 120000 tests/qemuxml2xmloutdata/net-mtu.xml

Expand all Fold all

[PATCH 0/7] virDomainNetDefFormat: Modernize XML formatting

Posted by Michal Privoznik 1 year, 3 months ago

A bit. After these, the function is still long and could be broken into
smaller ones, but let's leave that as an exercise for future us.

Michal Prívozník (7):
  qemuxml2xmloutdata: Turn net-mtu.xml into a symlink
  virDomainNetDefFormat: Rename @attrBuf to @targetAttrBuf
  virDomainNetDefFormat: Modernize <tune/> formatting
  virDomainNetDefFormat: Modernize <guest/> formatting
  virDomainNetDefFormat: Modernize <source/> formatting
  virDomainNetDefFormat: Simplify @sourceAttrBuf handling for some types
    of VIR_DOMAIN_NET
  virDomainNetDefFormat: Modernize <mac/> formatting

 src/conf/domain_conf.c               | 151 ++++++++++-----------------
 tests/qemuxml2argvdata/net-mtu.xml   |  26 +++--
 tests/qemuxml2xmloutdata/net-mtu.xml |  72 +------------
 3 files changed, 74 insertions(+), 175 deletions(-)
 mode change 100644 => 120000 tests/qemuxml2xmloutdata/net-mtu.xml

-- 
2.39.1

Re: [PATCH 0/7] virDomainNetDefFormat: Modernize XML formatting

Posted by Peter Krempa 1 year, 3 months ago

On Tue, Jan 31, 2023 at 17:44:14 +0100, Michal Privoznik wrote:
> A bit. After these, the function is still long and could be broken into
> smaller ones, but let's leave that as an exercise for future us.
> 
> Michal Prívozník (7):
>   qemuxml2xmloutdata: Turn net-mtu.xml into a symlink
>   virDomainNetDefFormat: Rename @attrBuf to @targetAttrBuf
>   virDomainNetDefFormat: Modernize <tune/> formatting
>   virDomainNetDefFormat: Modernize <guest/> formatting
>   virDomainNetDefFormat: Modernize <source/> formatting
>   virDomainNetDefFormat: Simplify @sourceAttrBuf handling for some types
>     of VIR_DOMAIN_NET
>   virDomainNetDefFormat: Modernize <mac/> formatting

Reviewed-by: Peter Krempa <pkrempa@redhat.com>