Credential asking cleanup follow-up

[PATCH 0/5] Credential asking cleanup follow-up

Peter Krempa posted 5 patches 1 year, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1674490067.git.pkrempa@redhat.com

src/rpc/virnetlibsshsession.c | 50 ++++++++---------------------------
src/rpc/virnetsshsession.c    | 41 +++++++---------------------
src/util/virauthconfig.c      |  8 ++----
3 files changed, 23 insertions(+), 76 deletions(-)

Expand all Fold all

[PATCH 0/5] Credential asking cleanup follow-up

Posted by Peter Krempa 1 year, 3 months ago

Few things noticed during review and during fixing of the original
patches after review.

Peter Krempa (5):
  util: authconfig: Don't check return value of 'g_key_file_new()'
  virNetSSHSessionAuthAddPasswordAuth: Don't access unlocked 'sess'
  virnetsshsession: Don't check return value of
    'virNetSSHSessionAuthMethodNew'
  virNetLibsshSessionAuthAddPasswordAuth: Don't access unlocked 'sess'
  virnetlibsshsession: Don't check return value of
    'virNetLibsshSessionAuthMethodNew'

 src/rpc/virnetlibsshsession.c | 50 ++++++++---------------------------
 src/rpc/virnetsshsession.c    | 41 +++++++---------------------
 src/util/virauthconfig.c      |  8 ++----
 3 files changed, 23 insertions(+), 76 deletions(-)

-- 
2.38.1

Re: [PATCH 0/5] Credential asking cleanup follow-up

Posted by Ján Tomko 1 year, 3 months ago

On a Monday in 2023, Peter Krempa wrote:
>Few things noticed during review and during fixing of the original
>patches after review.
>
>Peter Krempa (5):
>  util: authconfig: Don't check return value of 'g_key_file_new()'
>  virNetSSHSessionAuthAddPasswordAuth: Don't access unlocked 'sess'
>  virnetsshsession: Don't check return value of
>    'virNetSSHSessionAuthMethodNew'
>  virNetLibsshSessionAuthAddPasswordAuth: Don't access unlocked 'sess'
>  virnetlibsshsession: Don't check return value of
>    'virNetLibsshSessionAuthMethodNew'
>
> src/rpc/virnetlibsshsession.c | 50 ++++++++---------------------------
> src/rpc/virnetsshsession.c    | 41 +++++++---------------------
> src/util/virauthconfig.c      |  8 ++----
> 3 files changed, 23 insertions(+), 76 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano