vbox: Report VirtualBox exceptions too

[PATCH 0/8] vbox: Report VirtualBox exceptions too

Michal Privoznik posted 8 patches 1 year, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1674466489.git.mprivozn@redhat.com

src/vbox/vbox_common.c        | 1223 +++++++++++++++++----------------
src/vbox/vbox_common.h        |    6 +
src/vbox/vbox_tmpl.c          |   52 ++
src/vbox/vbox_uniformed_api.h |   11 +
4 files changed, 712 insertions(+), 580 deletions(-)

Expand all Fold all

[PATCH 0/8] vbox: Report VirtualBox exceptions too

Posted by Michal Privoznik 1 year, 3 months ago

See 5/8 for motivation.

Michal Prívozník (8):
  vbox: Introduce VBOX_QUERY_INTERFACE()
  vbox: Introduce IVirtualBoxErrorInfo interface
  vbox: Introduce vboxUniformedPFN::GetException()
  vbox: Introduce vboxUniformedPFN::ClearException()
  vbox: Introduce vboxReportError()
  vbox: Replace virReportError() with vboxReportError()
  vbox: Move error messages onto a single line
  vbox: Stop reporting RC in error messages

 src/vbox/vbox_common.c        | 1223 +++++++++++++++++----------------
 src/vbox/vbox_common.h        |    6 +
 src/vbox/vbox_tmpl.c          |   52 ++
 src/vbox/vbox_uniformed_api.h |   11 +
 4 files changed, 712 insertions(+), 580 deletions(-)

-- 
2.39.1

Re: [PATCH 0/8] vbox: Report VirtualBox exceptions too

Posted by Martin Kletzander 1 year, 3 months ago

On Mon, Jan 23, 2023 at 10:35:47AM +0100, Michal Privoznik wrote:
>See 5/8 for motivation.
>
>Michal Prívozník (8):
>  vbox: Introduce VBOX_QUERY_INTERFACE()
>  vbox: Introduce IVirtualBoxErrorInfo interface
>  vbox: Introduce vboxUniformedPFN::GetException()
>  vbox: Introduce vboxUniformedPFN::ClearException()
>  vbox: Introduce vboxReportError()
>  vbox: Replace virReportError() with vboxReportError()
>  vbox: Move error messages onto a single line
>  vbox: Stop reporting RC in error messages
>

With the few things fixed this is

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> src/vbox/vbox_common.c        | 1223 +++++++++++++++++----------------
> src/vbox/vbox_common.h        |    6 +
> src/vbox/vbox_tmpl.c          |   52 ++
> src/vbox/vbox_uniformed_api.h |   11 +
> 4 files changed, 712 insertions(+), 580 deletions(-)
>
>-- 
>2.39.1
>