cgroups cpu shares fixes

[libvirt PATCH 0/3] cgroups cpu shares fixes

Pavel Hrdina posted 3 patches 1 year, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1673948141.git.phrdina@redhat.com

docs/formatdomain.rst      |  2 +-
docs/manpages/virsh.rst    |  3 ++-
src/conf/domain_validate.c | 10 ----------
src/util/vircgroup.h       |  2 ++
src/util/vircgroupv2.c     |  8 ++++----
5 files changed, 9 insertions(+), 16 deletions(-)

Expand all Fold all

[libvirt PATCH 0/3] cgroups cpu shares fixes

Posted by Pavel Hrdina 1 year, 3 months ago

Pavel Hrdina (3):
  vircgroupv2: fix cpu.weight limits check
  domain_validate: drop cpu.shares cgroup check
  docs: document correct cpu shares limits with both cgroups v1 and v2

 docs/formatdomain.rst      |  2 +-
 docs/manpages/virsh.rst    |  3 ++-
 src/conf/domain_validate.c | 10 ----------
 src/util/vircgroup.h       |  2 ++
 src/util/vircgroupv2.c     |  8 ++++----
 5 files changed, 9 insertions(+), 16 deletions(-)

-- 
2.39.0

Re: [libvirt PATCH 0/3] cgroups cpu shares fixes

Posted by Erik Skultety 1 year, 3 months ago

On Tue, Jan 17, 2023 at 10:37:24AM +0100, Pavel Hrdina wrote:
> Pavel Hrdina (3):
>   vircgroupv2: fix cpu.weight limits check
>   domain_validate: drop cpu.shares cgroup check
>   docs: document correct cpu shares limits with both cgroups v1 and v2
> 
>  docs/formatdomain.rst      |  2 +-
>  docs/manpages/virsh.rst    |  3 ++-
>  src/conf/domain_validate.c | 10 ----------
>  src/util/vircgroup.h       |  2 ++
>  src/util/vircgroupv2.c     |  8 ++++----
>  5 files changed, 9 insertions(+), 16 deletions(-)
> 
> -- 
> 2.39.0
> 

FWIW:
Reviewed-by: Erik Skultety <eskultet@redhat.com>

Thanks for fixing this for the TCK tests' sake :)

Re: [libvirt PATCH 0/3] cgroups cpu shares fixes

Posted by Martin Kletzander 1 year, 3 months ago

On Tue, Jan 17, 2023 at 10:37:24AM +0100, Pavel Hrdina wrote:
>Pavel Hrdina (3):
>  vircgroupv2: fix cpu.weight limits check
>  domain_validate: drop cpu.shares cgroup check
>  docs: document correct cpu shares limits with both cgroups v1 and v2
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> docs/formatdomain.rst      |  2 +-
> docs/manpages/virsh.rst    |  3 ++-
> src/conf/domain_validate.c | 10 ----------
> src/util/vircgroup.h       |  2 ++
> src/util/vircgroupv2.c     |  8 ++++----
> 5 files changed, 9 insertions(+), 16 deletions(-)
>
>-- 
>2.39.0
>