Check that max_clients is not less than max_anonymous_clients

[PATCH 0/4] Check that max_clients is not less than max_anonymous_clients

Martin Kletzander posted 4 patches 1 year, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1672675104.git.mkletzan@redhat.com

src/rpc/virnetserver.c                        | 19 ++++++++++--
...nput-data-client-auth-pending-failure.json |  4 +--
...nput-data-invalid-max-clients-failure.json | 31 +++++++++++++++++++
.../output-data-anon-clients.err              |  1 +
...utput-data-client-auth-pending-failure.err |  1 +
...utput-data-invalid-max-clients-failure.err |  1 +
tests/virnetdaemontest.c                      | 20 +++++++-----
7 files changed, 64 insertions(+), 13 deletions(-)
create mode 100644 tests/virnetdaemondata/input-data-invalid-max-clients-failure.json
create mode 100644 tests/virnetdaemondata/output-data-anon-clients.err
create mode 100644 tests/virnetdaemondata/output-data-client-auth-pending-failure.err
create mode 100644 tests/virnetdaemondata/output-data-invalid-max-clients-failure.err

Expand all Fold all

[PATCH 0/4] Check that max_clients is not less than max_anonymous_clients

Posted by Martin Kletzander 1 year, 4 months ago

One check is there, but there ought to be more.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2033879

Martin Kletzander (4):
  Fix test case to actually test something
  tests: Check error message in virnetdaemontest
  rpc: Fix error message in virNetServerSetClientLimits
  rpc: Check client limits in more places

 src/rpc/virnetserver.c                        | 19 ++++++++++--
 ...nput-data-client-auth-pending-failure.json |  4 +--
 ...nput-data-invalid-max-clients-failure.json | 31 +++++++++++++++++++
 .../output-data-anon-clients.err              |  1 +
 ...utput-data-client-auth-pending-failure.err |  1 +
 ...utput-data-invalid-max-clients-failure.err |  1 +
 tests/virnetdaemontest.c                      | 20 +++++++-----
 7 files changed, 64 insertions(+), 13 deletions(-)
 create mode 100644 tests/virnetdaemondata/input-data-invalid-max-clients-failure.json
 create mode 100644 tests/virnetdaemondata/output-data-anon-clients.err
 create mode 100644 tests/virnetdaemondata/output-data-client-auth-pending-failure.err
 create mode 100644 tests/virnetdaemondata/output-data-invalid-max-clients-failure.err

-- 
2.39.0

Re: [PATCH 0/4] Check that max_clients is not less than max_anonymous_clients

Posted by Ján Tomko 1 year, 4 months ago

On a Monday in 2023, Martin Kletzander wrote:
>One check is there, but there ought to be more.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2033879
>
>Martin Kletzander (4):
>  Fix test case to actually test something
>  tests: Check error message in virnetdaemontest
>  rpc: Fix error message in virNetServerSetClientLimits
>  rpc: Check client limits in more places
>
> src/rpc/virnetserver.c                        | 19 ++++++++++--
> ...nput-data-client-auth-pending-failure.json |  4 +--
> ...nput-data-invalid-max-clients-failure.json | 31 +++++++++++++++++++
> .../output-data-anon-clients.err              |  1 +
> ...utput-data-client-auth-pending-failure.err |  1 +
> ...utput-data-invalid-max-clients-failure.err |  1 +
> tests/virnetdaemontest.c                      | 20 +++++++-----
> 7 files changed, 64 insertions(+), 13 deletions(-)
> create mode 100644 tests/virnetdaemondata/input-data-invalid-max-clients-failure.json
> create mode 100644 tests/virnetdaemondata/output-data-anon-clients.err
> create mode 100644 tests/virnetdaemondata/output-data-client-auth-pending-failure.err
> create mode 100644 tests/virnetdaemondata/output-data-invalid-max-clients-failure.err
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano