util: qemu: Perform the 'skipKey' handling only on the top level object

[PATCH 0/2] util: qemu: Perform the 'skipKey' handling only on the top level object

Peter Krempa posted 2 patches 1 year, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1671440529.git.pkrempa@redhat.com

src/util/virqemu.c | 21 +++++++++------------
src/util/virqemu.h | 12 ++++--------
2 files changed, 13 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH 0/2] util: qemu: Perform the 'skipKey' handling only on the top level object

Posted by Peter Krempa 1 year, 4 months ago

Semantically we need to handle one of the keys in the top level object
spearately, thus skipping it in nested objects doesn't make sense.

Peter Krempa (2):
  virqemu: Don't strip the requested key from nested objects
  util: qemu: Remove 'skipKey' argument from
    virQEMUBuildCommandLineJSONArrayFormatFunc prototype

 src/util/virqemu.c | 21 +++++++++------------
 src/util/virqemu.h | 12 ++++--------
 2 files changed, 13 insertions(+), 20 deletions(-)

-- 
2.38.1

Re: [PATCH 0/2] util: qemu: Perform the 'skipKey' handling only on the top level object

Posted by Michal Prívozník 1 year, 4 months ago

On 12/19/22 10:03, Peter Krempa wrote:
> Semantically we need to handle one of the keys in the top level object
> spearately, thus skipping it in nested objects doesn't make sense.
> 
> Peter Krempa (2):
>   virqemu: Don't strip the requested key from nested objects
>   util: qemu: Remove 'skipKey' argument from
>     virQEMUBuildCommandLineJSONArrayFormatFunc prototype
> 
>  src/util/virqemu.c | 21 +++++++++------------
>  src/util/virqemu.h | 12 ++++--------
>  2 files changed, 13 insertions(+), 20 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal