qemu: Prefer PNG for domain screenshots

[PATCH 0/5] qemu: Prefer PNG for domain screenshots

Michal Privoznik posted 5 patches 1 year, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1670411966.git.mprivozn@redhat.com

NEWS.rst                                         |  4 ++++
src/qemu/qemu_capabilities.c                     |  2 ++
src/qemu/qemu_capabilities.h                     |  1 +
src/qemu/qemu_driver.c                           | 13 +++++++++++--
src/qemu/qemu_monitor.c                          |  6 ++++--
src/qemu/qemu_monitor.h                          |  1 +
src/qemu/qemu_monitor_json.c                     |  2 ++
src/qemu/qemu_monitor_json.h                     |  1 +
tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml  |  1 +
tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml |  1 +
tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml |  1 +
tests/qemumonitorjsontest.c                      |  2 +-
12 files changed, 30 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH 0/5] qemu: Prefer PNG for domain screenshots

Posted by Michal Privoznik 1 year, 4 months ago

Whilst preparing for libvirt-php release, I want to ditch its imagick
dependency which is needed to convert PPM to PNG. But I've learned that
QEMU is able to return PNG already which looks more versatile than PPM
anyways.

Michal Prívozník (5):
  qemu_caps: Introduce QEMU_CAPS_SCREENSHOT_FORMAT_PNG
  qemu_monitor: Debug print all arguments in qemuMonitorScreendump()
  qemu_monitor: Extend qemuMonitorScreendump() for @format
  qemu: Prefer PNG for domain screenshots
  NEWS: Document change of screenshot format for QEMU

 NEWS.rst                                         |  4 ++++
 src/qemu/qemu_capabilities.c                     |  2 ++
 src/qemu/qemu_capabilities.h                     |  1 +
 src/qemu/qemu_driver.c                           | 13 +++++++++++--
 src/qemu/qemu_monitor.c                          |  6 ++++--
 src/qemu/qemu_monitor.h                          |  1 +
 src/qemu/qemu_monitor_json.c                     |  2 ++
 src/qemu/qemu_monitor_json.h                     |  1 +
 tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml |  1 +
 tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml |  1 +
 tests/qemumonitorjsontest.c                      |  2 +-
 12 files changed, 30 insertions(+), 5 deletions(-)

-- 
2.37.4

Re: [PATCH 0/5] qemu: Prefer PNG for domain screenshots

Posted by Martin Kletzander 1 year, 4 months ago

On Wed, Dec 07, 2022 at 12:20:48PM +0100, Michal Privoznik wrote:
>Whilst preparing for libvirt-php release, I want to ditch its imagick
>dependency which is needed to convert PPM to PNG. But I've learned that
>QEMU is able to return PNG already which looks more versatile than PPM
>anyways.
>
>Michal Prívozník (5):
>  qemu_caps: Introduce QEMU_CAPS_SCREENSHOT_FORMAT_PNG
>  qemu_monitor: Debug print all arguments in qemuMonitorScreendump()
>  qemu_monitor: Extend qemuMonitorScreendump() for @format
>  qemu: Prefer PNG for domain screenshots
>  NEWS: Document change of screenshot format for QEMU

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>
> NEWS.rst                                         |  4 ++++
> src/qemu/qemu_capabilities.c                     |  2 ++
> src/qemu/qemu_capabilities.h                     |  1 +
> src/qemu/qemu_driver.c                           | 13 +++++++++++--
> src/qemu/qemu_monitor.c                          |  6 ++++--
> src/qemu/qemu_monitor.h                          |  1 +
> src/qemu/qemu_monitor_json.c                     |  2 ++
> src/qemu/qemu_monitor_json.h                     |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml  |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml |  1 +
> tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml |  1 +
> tests/qemumonitorjsontest.c                      |  2 +-
> 12 files changed, 30 insertions(+), 5 deletions(-)
>
>-- 
>2.37.4
>

Re: [PATCH 0/5] qemu: Prefer PNG for domain screenshots

Posted by Ján Tomko 1 year, 4 months ago

On a Wednesday in 2022, Michal Privoznik wrote:
>Whilst preparing for libvirt-php release, I want to ditch its imagick
>dependency which is needed to convert PPM to PNG. But I've learned that
>QEMU is able to return PNG already which looks more versatile than PPM
>anyways.
>
>Michal Prívozník (5):
>  qemu_caps: Introduce QEMU_CAPS_SCREENSHOT_FORMAT_PNG
>  qemu_monitor: Debug print all arguments in qemuMonitorScreendump()
>  qemu_monitor: Extend qemuMonitorScreendump() for @format
>  qemu: Prefer PNG for domain screenshots
>  NEWS: Document change of screenshot format for QEMU
>
> NEWS.rst                                         |  4 ++++
> src/qemu/qemu_capabilities.c                     |  2 ++
> src/qemu/qemu_capabilities.h                     |  1 +
> src/qemu/qemu_driver.c                           | 13 +++++++++++--
> src/qemu/qemu_monitor.c                          |  6 ++++--
> src/qemu/qemu_monitor.h                          |  1 +
> src/qemu/qemu_monitor_json.c                     |  2 ++
> src/qemu/qemu_monitor_json.h                     |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml  |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml |  1 +
> tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml |  1 +
> tests/qemumonitorjsontest.c                      |  2 +-
> 12 files changed, 30 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano