[PATCH 0/9] Couple of virCommand related improvements

Michal Privoznik posted 9 patches 1 year, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1669801586.git.mprivozn@redhat.com
src/qemu/qemu_tpm.c              |   2 +-
src/util/vircommand.c            |  11 ++-
src/util/vircommand.h            |   2 +-
tests/commanddata/test29.log     |  20 ++++
tests/commandtest.c              | 152 +++++++++++++++++++++++--------
tests/esxutilstest.c             |  10 +-
tests/nwfilterebiptablestest.c   |  21 ++---
tests/openvzutilstest.c          |   6 +-
tests/sockettest.c               |   3 +-
tests/utiltest.c                 |   3 +-
tests/vboxsnapshotxmltest.c      |   3 +-
tests/virbuftest.c               |  25 ++---
tests/virfirewalltest.c          |  30 ++----
tests/virjsontest.c              |   6 +-
tests/virkmodtest.c              |   3 +-
tests/virnetdevbandwidthtest.c   |   5 +-
tests/virnetdevopenvswitchtest.c |  10 +-
tests/virnetsockettest.c         |   3 +-
tests/virshtest.c                |   3 +-
19 files changed, 182 insertions(+), 136 deletions(-)
create mode 100644 tests/commanddata/test29.log
[PATCH 0/9] Couple of virCommand related improvements
Posted by Michal Privoznik 1 year, 5 months ago
Found these on a abandoned branch, but they are still worth merging.
Polished them a bit though.

Michal Prívozník (9):
  vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize
  virCommandDoAsyncIO: Drop misleading statement about main event loop
  commandtest: Use unsigned char in test27()
  virCommandSetSendBuffer: Take double pointer of @buffer
  commandtest: Test virCommandSetSendBuffer() with virCommandDoAsyncIO()
  commandtest: Use virTestCompareToFile() in checkoutput()
  virbuftest: Cleanup code around virTestDifference()
  tests: Don't wrap virTestDifference() arguments in NULLSTR()
  tests: Use virTestCompareToString() more

 src/qemu/qemu_tpm.c              |   2 +-
 src/util/vircommand.c            |  11 ++-
 src/util/vircommand.h            |   2 +-
 tests/commanddata/test29.log     |  20 ++++
 tests/commandtest.c              | 152 +++++++++++++++++++++++--------
 tests/esxutilstest.c             |  10 +-
 tests/nwfilterebiptablestest.c   |  21 ++---
 tests/openvzutilstest.c          |   6 +-
 tests/sockettest.c               |   3 +-
 tests/utiltest.c                 |   3 +-
 tests/vboxsnapshotxmltest.c      |   3 +-
 tests/virbuftest.c               |  25 ++---
 tests/virfirewalltest.c          |  30 ++----
 tests/virjsontest.c              |   6 +-
 tests/virkmodtest.c              |   3 +-
 tests/virnetdevbandwidthtest.c   |   5 +-
 tests/virnetdevopenvswitchtest.c |  10 +-
 tests/virnetsockettest.c         |   3 +-
 tests/virshtest.c                |   3 +-
 19 files changed, 182 insertions(+), 136 deletions(-)
 create mode 100644 tests/commanddata/test29.log

-- 
2.37.4

Re: [PATCH 0/9] Couple of virCommand related improvements
Posted by Jonathon Jongsma 1 year, 5 months ago
On 11/30/22 3:48 AM, Michal Privoznik wrote:
> Found these on a abandoned branch, but they are still worth merging.
> Polished them a bit though.
> 
> Michal Prívozník (9):
>    vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize
>    virCommandDoAsyncIO: Drop misleading statement about main event loop
>    commandtest: Use unsigned char in test27()
>    virCommandSetSendBuffer: Take double pointer of @buffer
>    commandtest: Test virCommandSetSendBuffer() with virCommandDoAsyncIO()
>    commandtest: Use virTestCompareToFile() in checkoutput()
>    virbuftest: Cleanup code around virTestDifference()
>    tests: Don't wrap virTestDifference() arguments in NULLSTR()
>    tests: Use virTestCompareToString() more
> 
>   src/qemu/qemu_tpm.c              |   2 +-
>   src/util/vircommand.c            |  11 ++-
>   src/util/vircommand.h            |   2 +-
>   tests/commanddata/test29.log     |  20 ++++
>   tests/commandtest.c              | 152 +++++++++++++++++++++++--------
>   tests/esxutilstest.c             |  10 +-
>   tests/nwfilterebiptablestest.c   |  21 ++---
>   tests/openvzutilstest.c          |   6 +-
>   tests/sockettest.c               |   3 +-
>   tests/utiltest.c                 |   3 +-
>   tests/vboxsnapshotxmltest.c      |   3 +-
>   tests/virbuftest.c               |  25 ++---
>   tests/virfirewalltest.c          |  30 ++----
>   tests/virjsontest.c              |   6 +-
>   tests/virkmodtest.c              |   3 +-
>   tests/virnetdevbandwidthtest.c   |   5 +-
>   tests/virnetdevopenvswitchtest.c |  10 +-
>   tests/virnetsockettest.c         |   3 +-
>   tests/virshtest.c                |   3 +-
>   19 files changed, 182 insertions(+), 136 deletions(-)
>   create mode 100644 tests/commanddata/test29.log
> 


Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>