util: xml: Clean up other instances of problems pointed out in review

[PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review

Peter Krempa posted 2 patches 1 year, 7 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1664804622.git.pkrempa@redhat.com

src/util/virxml.c | 34 +++++++++++++++++-----------------
src/util/virxml.h | 12 ++++++------
2 files changed, 23 insertions(+), 23 deletions(-)

Expand all Fold all

[PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review

Posted by Peter Krempa 1 year, 7 months ago

In review of my series which was adding new XML Property fetching
helpers I was asked to change few things which were also present in
other instances in existing code. Fix those too.

Peter Krempa (2):
  util: xml: Fix declararation of 'const char *' parameters in
    virXMLProp* helpers
  util: xml: Use common formatting of 'Bitwise-OR' in function param
    description

 src/util/virxml.c | 34 +++++++++++++++++-----------------
 src/util/virxml.h | 12 ++++++------
 2 files changed, 23 insertions(+), 23 deletions(-)

-- 
2.37.3

Re: [PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review

Posted by Ján Tomko 1 year, 7 months ago

On a Monday in 2022, Peter Krempa wrote:
>In review of my series which was adding new XML Property fetching
>helpers I was asked to change few things which were also present in
>other instances in existing code. Fix those too.
>
>Peter Krempa (2):
>  util: xml: Fix declararation of 'const char *' parameters in
>    virXMLProp* helpers
>  util: xml: Use common formatting of 'Bitwise-OR' in function param
>    description
>
> src/util/virxml.c | 34 +++++++++++++++++-----------------
> src/util/virxml.h | 12 ++++++------
> 2 files changed, 23 insertions(+), 23 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano