[PATCH 0/7] Fix two bugs in XML schema

Peter Krempa posted 7 patches 1 year, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1661420712.git.pkrempa@redhat.com
docs/formatnode.rst                           |   2 +-
src/conf/schemas/domain.rng                   |  12 +-
src/conf/schemas/domaincommon.rng             | 150 ++++++++++--------
src/conf/schemas/domainoverrides.rng          |  16 ++
src/conf/schemas/domainsnapshot.rng           |   5 +
src/conf/schemas/inactiveDomain.rng           |  10 ++
src/conf/schemas/nodedev.rng                  |   2 +-
tests/nodedevschemadata/hba_vport_ops.xml     |  18 +++
tests/nodedevxml2xmlout/hba_vport_ops.xml     |  18 +++
tests/nodedevxml2xmltest.c                    |   1 +
.../memory-snapshot-inactivedomain.xml        | 148 +++++++++++++++++
tests/qemudomainsnapshotxml2xmltest.c         |  10 +-
12 files changed, 303 insertions(+), 89 deletions(-)
create mode 100644 src/conf/schemas/domainoverrides.rng
create mode 100644 src/conf/schemas/inactiveDomain.rng
create mode 100644 tests/nodedevschemadata/hba_vport_ops.xml
create mode 100644 tests/nodedevxml2xmlout/hba_vport_ops.xml
create mode 100644 tests/qemudomainsnapshotxml2xmlout/memory-snapshot-inactivedomain.xml
[PATCH 0/7] Fix two bugs in XML schema
Posted by Peter Krempa 1 year, 8 months ago
Patches 1/7 and 6/7 outline the individual bugs.

Peter Krempa (7):
  schema: nodedev: Fix schema attribute value for the 'vport_ops'
    capability
  nodedevschematest: Add example file for a HBA with 'vport_ops'
    capability
  qemudomainsnapshotxml2xmltest: Allow regenerating into non-existing
    output file
  schemas: Extract overrides for the domain element from 'domain.rng'
  schemas: domaincommon: Extract contents of the 'domain' element
    definition
  schema: Add schema for '<inactiveDomain>' element used in the snapshot
    definition
  qemudomainsnapshotxml2xmltest: Add test case for a snapshot with
    'inactiveDomain' element

 docs/formatnode.rst                           |   2 +-
 src/conf/schemas/domain.rng                   |  12 +-
 src/conf/schemas/domaincommon.rng             | 150 ++++++++++--------
 src/conf/schemas/domainoverrides.rng          |  16 ++
 src/conf/schemas/domainsnapshot.rng           |   5 +
 src/conf/schemas/inactiveDomain.rng           |  10 ++
 src/conf/schemas/nodedev.rng                  |   2 +-
 tests/nodedevschemadata/hba_vport_ops.xml     |  18 +++
 tests/nodedevxml2xmlout/hba_vport_ops.xml     |  18 +++
 tests/nodedevxml2xmltest.c                    |   1 +
 .../memory-snapshot-inactivedomain.xml        | 148 +++++++++++++++++
 tests/qemudomainsnapshotxml2xmltest.c         |  10 +-
 12 files changed, 303 insertions(+), 89 deletions(-)
 create mode 100644 src/conf/schemas/domainoverrides.rng
 create mode 100644 src/conf/schemas/inactiveDomain.rng
 create mode 100644 tests/nodedevschemadata/hba_vport_ops.xml
 create mode 100644 tests/nodedevxml2xmlout/hba_vport_ops.xml
 create mode 100644 tests/qemudomainsnapshotxml2xmlout/memory-snapshot-inactivedomain.xml

-- 
2.37.1
Re: [PATCH 0/7] Fix two bugs in XML schema
Posted by Ján Tomko 1 year, 8 months ago
On a Thursday in 2022, Peter Krempa wrote:
>Patches 1/7 and 6/7 outline the individual bugs.
>
>Peter Krempa (7):
>  schema: nodedev: Fix schema attribute value for the 'vport_ops'
>    capability
>  nodedevschematest: Add example file for a HBA with 'vport_ops'
>    capability
>  qemudomainsnapshotxml2xmltest: Allow regenerating into non-existing
>    output file
>  schemas: Extract overrides for the domain element from 'domain.rng'
>  schemas: domaincommon: Extract contents of the 'domain' element
>    definition
>  schema: Add schema for '<inactiveDomain>' element used in the snapshot
>    definition
>  qemudomainsnapshotxml2xmltest: Add test case for a snapshot with
>    'inactiveDomain' element
>
> docs/formatnode.rst                           |   2 +-
> src/conf/schemas/domain.rng                   |  12 +-
> src/conf/schemas/domaincommon.rng             | 150 ++++++++++--------
> src/conf/schemas/domainoverrides.rng          |  16 ++
> src/conf/schemas/domainsnapshot.rng           |   5 +
> src/conf/schemas/inactiveDomain.rng           |  10 ++
> src/conf/schemas/nodedev.rng                  |   2 +-
> tests/nodedevschemadata/hba_vport_ops.xml     |  18 +++
> tests/nodedevxml2xmlout/hba_vport_ops.xml     |  18 +++
> tests/nodedevxml2xmltest.c                    |   1 +
> .../memory-snapshot-inactivedomain.xml        | 148 +++++++++++++++++
> tests/qemudomainsnapshotxml2xmltest.c         |  10 +-
> 12 files changed, 303 insertions(+), 89 deletions(-)
> create mode 100644 src/conf/schemas/domainoverrides.rng
> create mode 100644 src/conf/schemas/inactiveDomain.rng
> create mode 100644 tests/nodedevschemadata/hba_vport_ops.xml
> create mode 100644 tests/nodedevxml2xmlout/hba_vport_ops.xml
> create mode 100644 tests/qemudomainsnapshotxml2xmlout/memory-snapshot-inactivedomain.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano