From nobody Fri May 17 06:07:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661254388; cv=none; d=zohomail.com; s=zohoarc; b=YzGensOB3KV1T11mMf4UI5nbUfZvMsMbUdp4/+7ds0xY+y4zNMFK9RIi+d09g/OSaJwpweYQ4tyL63rvCSBCtCo1mc7aXYrY9HrprTYwXAsE248A1cEoiy+Ig/2/wZopoWJk1Xxh3D3nA/Eb0t1co5Vda9fRnXRShDWYtSHjwzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661254388; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wpmOoe5H1jwh4mOpTjqMQAwh/hTMd4jyQLPqEl2U+eU=; b=U9w+IBJSO7/tyG/cv/Tjrm0jp83PkvvL5J2UPTj76ZRJUpHmfd9bllCyhIW613vTTjXBoz5nF0ECSqUHMfGlp4u1QavtSaPjbpBZm2C5qrgFSA9BySvOA8caTyVfJFNhd4pSGKBvzG/cWnfatWghHfCVFaR7TWnc/xTjNJqNyQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661254388968966.9585754243305; Tue, 23 Aug 2022 04:33:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-Gm9UghH_OiK36t05vYHipQ-1; Tue, 23 Aug 2022 07:33:02 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B9831C1394D; Tue, 23 Aug 2022 11:32:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34CBBC15BBD; Tue, 23 Aug 2022 11:32:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1C8921946A65; Tue, 23 Aug 2022 11:32:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 92F991946A40 for ; Tue, 23 Aug 2022 11:32:42 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A507A945D0; Tue, 23 Aug 2022 11:32:42 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18ED4945DB for ; Tue, 23 Aug 2022 11:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661254388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wpmOoe5H1jwh4mOpTjqMQAwh/hTMd4jyQLPqEl2U+eU=; b=ga4tZ4EjQvU8edrlCFvf+ClKNEVwsGTBM+UnuPGRk8tc1H3bDl9CaT9g1GvlWcmT95F68S U3897Nx9BWXgZsZkYORe5i7r2xjPnolpTCXmvtjFPI2BVDpZtdw+gFIU02Rg34EuSaok+2 guE1PXu9IQapn0kDkrqdNd2swtcNnkc= X-MC-Unique: Gm9UghH_OiK36t05vYHipQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/4] docs: newapi: Consider also 'https://' links in the API generator XSL Date: Tue, 23 Aug 2022 13:32:37 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661254390894100007 Content-Type: text/plain; charset="utf-8" We converted exclusively to https links so the generator should wrap those in appropriate link tags too. Signed-off-by: Peter Krempa Reviewed-by: Jonathon Jongsma --- docs/newapi.xsl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index e56a5f2a27..f2e8bd5334 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -131,6 +131,11 @@ + + + + + --=20 2.37.1 From nobody Fri May 17 06:07:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661254384; cv=none; d=zohomail.com; s=zohoarc; b=XhWhyR4AcVeA0ONqdsRdZPpXwdCnaT7KUk5m6YfY53KgIP14PlSVmf9s05xgsZo0cxnp0oxMql1H7sv8Y7KhsyL6ETHBHQ4LKmQDeSewmpKbaCMVmzi3BUk+YM6NQXGuASEUShjypovtDe1t1dS1oMYZ6XPcALchOWSN0XudEVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661254384; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=THsTKTfNDUnjFR9IB4Y/zIwPWcquvI9Pu8DX7gJKAlY=; b=dqy5PD3SK2tuLtHmbVSbgCd6JcJm11H8pIedfUVwOo3GfgULpulOaK9yzsuJL9c8Vh5ofQVQ00Ra+lmfzwh7dk8tDyt5yOGC/DXVxCsGsduH3/YC+LmoqY41YIkLw25ywnl/y77O2HMmh6DPpwuvHqbQED/0nYJODSyfWCmBEKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661254384779308.012555758718; Tue, 23 Aug 2022 04:33:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-115-5NKY5aDGMLuUDNF0YeKk-g-1; Tue, 23 Aug 2022 07:33:02 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B38E823F10; Tue, 23 Aug 2022 11:32:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83E9AC15BC5; Tue, 23 Aug 2022 11:32:58 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2C23D1946A47; Tue, 23 Aug 2022 11:32:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 959CB1946A52 for ; Tue, 23 Aug 2022 11:32:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A4654945DB; Tue, 23 Aug 2022 11:32:43 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0EBD7945D2 for ; Tue, 23 Aug 2022 11:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661254383; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=THsTKTfNDUnjFR9IB4Y/zIwPWcquvI9Pu8DX7gJKAlY=; b=L3r7lZhNSK7PgNmB0P0nMSAcU0iQ/w7Kds+z5eVDRhMKMI/fZZA11k6+tuYPzBCFs6t+qN CNB1krXOsgAM8VKpxC5YJ/WKG4NsgNUPUwfSVkLKh1RdpSrVxWb9PAXtvrLwUhmIgDgRee j85DvaNwdQvXbZ3TfWm97Cu50vHSFXE= X-MC-Unique: 5NKY5aDGMLuUDNF0YeKk-g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/4] virDomainCheckpointCreateXML: Don't use HTML in function docs and fix link Date: Tue, 23 Aug 2022 13:32:38 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661254386904100002 Content-Type: text/plain; charset="utf-8" Fix the link target after the conversion of the XML description to RST which renamed anchors and drop the tag from the C code comment. Apart from not working properly in the .c file it didn't work in the generated docs either as the brackets were escaped. Signed-off-by: Peter Krempa Reviewed-by: Jonathon Jongsma --- src/libvirt-domain-checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain-checkpoint.c b/src/libvirt-domain-checkpoin= t.c index f58f1b4f8f..de747aff01 100644 --- a/src/libvirt-domain-checkpoint.c +++ b/src/libvirt-domain-checkpoint.c @@ -114,7 +114,7 @@ virDomainCheckpointGetConnect(virDomainCheckpointPtr ch= eckpoint) * kicking off a backup job with virDomainBackupBegin(); however, it * is also possible to start a checkpoint without a backup. * - * See Checkpoint X= ML + * See https://www.libvirt.org/formatcheckpoint.html#checkpoint-xml * for more details on @xmlDesc. In particular, some hypervisors may requi= re * particular disk formats, such as qcow2, in order to support this * command; where @xmlDesc can be used to limit the checkpoint to a working --=20 2.37.1 From nobody Fri May 17 06:07:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661254389; cv=none; d=zohomail.com; s=zohoarc; b=B7fcnIIZ+NlE2OxabIkZ0Uw4xzaBB2wsS1mQGpBe360Xr6eW3lc+VhmWligzRYE/Xpf5B16CvBTRjR8P9zqQtMGd7Eykuy2JN+kCqewbswbCu4hFcnpF8w2CvMl2BnXMxOf1R1CHu4Zei1U1dhHKzhuCw18je0GoQbrXlz4Er5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661254389; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4cCFYAGfMUUvrLydB7ehKt/hEpJyHTCdMj2ObaTTGtY=; b=aSQXN2DjtSUI87iBYfHTkWipb4C9MRaH25SGBxEjK/DsXeYUONx/ELp77zTiARMuUfoStrE0O7Db6b5yLk4P7P3n4ylAr14nkKrxTjUlTJpEYNPqgYbqgp/FcXnNonS4oGTwfos8YriZFfXWrEvLLlMDAofJs/CyF/i2KSeBl4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661254389726818.2769565750137; Tue, 23 Aug 2022 04:33:09 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-267-0DZN84S9OCODQ0P1Kk7b_g-1; Tue, 23 Aug 2022 07:33:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C10A1C13945; Tue, 23 Aug 2022 11:33:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70C4E40CFD0A; Tue, 23 Aug 2022 11:33:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 69B571947041; Tue, 23 Aug 2022 11:32:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 95FE71946A58 for ; Tue, 23 Aug 2022 11:32:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9EB36945D2; Tue, 23 Aug 2022 11:32:44 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 179A1945D7 for ; Tue, 23 Aug 2022 11:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661254387; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4cCFYAGfMUUvrLydB7ehKt/hEpJyHTCdMj2ObaTTGtY=; b=gPXCgAgaO8fNhm8p2kW+V2RGlD8PJ4kYaRhDU9Rhwj+868LsgI++BuI+BBnsxhWBu0iB86 BZfJVyXzitzMevqOBCSlwdhZBpxuF7+L8CKt1BHp2la6Vg6//PaqWz4+xEIiSQhDx7IGOq DDIkqgfoyhIN/c3ybfss4MOPCYeTTuo= X-MC-Unique: 0DZN84S9OCODQ0P1Kk7b_g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/4] virDomainCheckpointCreateXML: Add disclaimer about creating checkpoints Date: Tue, 23 Aug 2022 13:32:39 +0200 Message-Id: <7f2d1ce6cab3dfd6cffa73f8d437ed078202d9e5.1661254291.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661254390910100008 Content-Type: text/plain; charset="utf-8" Checkpoints created via virDomainCheckpointCreateXML are generally not very useful as they need to be coupled with a backup. Add a disclaimer to the docs explaining why users should use virDomainBackupBegin instead. Signed-off-by: Peter Krempa Reviewed-by: Jonathon Jongsma --- src/libvirt-domain-checkpoint.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libvirt-domain-checkpoint.c b/src/libvirt-domain-checkpoin= t.c index de747aff01..078e999bf3 100644 --- a/src/libvirt-domain-checkpoint.c +++ b/src/libvirt-domain-checkpoint.c @@ -142,6 +142,16 @@ virDomainCheckpointGetConnect(virDomainCheckpointPtr c= heckpoint) * present, an error is thrown. This flag is incompatible with * VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE. * + * Note: A checkpoint represent s point in time since which blocks changed= by + * the hypervisor are tracked. The tracking of changed blocks notes only w= hether + * a block was modified, but does not preserve the old contents. This mean= s that + * for a checkpoint to be generally usable for doing an incremental backup= it's + * required to perform a backup at the same time as taking the checkpoint. + * This is done via the virDomainBackupBegin API, which also allows to cre= ate + * a checkpoint at the same time. virDomainCheckpointCreateXML is generall= y not + * useful for creating checkpoints but rather only for re-creating the lib= virt + * metadata. + * * Returns an (opaque) new virDomainCheckpointPtr on success or NULL * on failure. * --=20 2.37.1 From nobody Fri May 17 06:07:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661254386; cv=none; d=zohomail.com; s=zohoarc; b=LyTMJJKqMogVr1xBQ0h7AJx4XgSs37pu9zWZK2g/jmL2cZrMyrPaa53hxxS1mNollQBbKJJ2i2A4GihWe9qkBGXLwmKoU+mlTIRxLk3LK2p77fA40KbGd/1oLVP9lFIqjTOsPnvHywZrzgJEomJcrRIPkolCKM5Ayv7m8WHUxV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661254386; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WXx3TdxPspDK5Yzuiffum07dYdxM3MQWZo2nbt1LS8w=; b=HQyG8s/8adKI0UexeaYN6w21VNeZjnaa6QuehJhLqcE6QTewUSIHjEtOsVTNBd8/QL9Oe98ejNpnuFUFyOenmAKTGpHIfc+o2PVu9PZwOB/62aBl7dtMx0AtOLvKOFM6fcmb38HMuZlInqT7IIAWDrougSz1fH9QQIMz8Z/6FP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661254386546922.579636674704; Tue, 23 Aug 2022 04:33:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-WRUkYugIOpGkKMKPl76Zdg-1; Tue, 23 Aug 2022 07:33:04 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFABD18E5345; Tue, 23 Aug 2022 11:33:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C77B2026D4C; Tue, 23 Aug 2022 11:33:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A518E1947054; Tue, 23 Aug 2022 11:32:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 92FB61946A47 for ; Tue, 23 Aug 2022 11:32:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 861F5945D9; Tue, 23 Aug 2022 11:32:45 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 045BC945D7 for ; Tue, 23 Aug 2022 11:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661254385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WXx3TdxPspDK5Yzuiffum07dYdxM3MQWZo2nbt1LS8w=; b=agUpl5D1vuiqRBxZH3TDK7x+RDQiUUIJ9/TebdI1hPNQVm1bzjLdDAUOytl7K125m9/pzO 5CFBVy7hviKJg0otjLy5dd/vBH4rxpuOXFJxYBqBbk9EOg3OsMx6NKjtodbcGSei7rUgE5 KnG3BX0UZlcBPurOM3Jh7ubINjlnHiU= X-MC-Unique: WRUkYugIOpGkKMKPl76Zdg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/4] virDomainBackupGetXMLDesc: Fix and use full link to XML documentation Date: Tue, 23 Aug 2022 13:32:40 +0200 Message-Id: <533f4fcd0d1247ed91150acde0c7ad6b9056ce06.1661254291.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661254386903100001 Content-Type: text/plain; charset="utf-8" Use the full link to the backup XML description page and use the proper anchor after html->RST coversion. Signed-off-by: Peter Krempa Reviewed-by: Jonathon Jongsma --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 842663a608..80a6f0f269 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -13582,7 +13582,7 @@ virDomainAgentSetResponseTimeout(virDomainPtr domai= n, * * virDomainBackupGetXMLDesc() can be called to learn actual * values selected. For more information, see - * formatcheckpoint.html#BackupAttributes. + * https://www.libvirt.org/formatbackup.html#backup-xml * * The @checkpointXML parameter is optional; if non-NULL, then libvirt * behaves as if virDomainCheckpointCreateXML() were called to create --=20 2.37.1