Refactor closecallback use in LXC

[PATCH 0/7] Refactor closecallback use in LXC

Peter Krempa posted 7 patches 1 year, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1658227484.git.pkrempa@redhat.com

src/hypervisor/virclosecallbacks.c |  24 -----
src/hypervisor/virclosecallbacks.h |   3 -
src/libvirt_private.syms           |   1 -
src/lxc/lxc_driver.c               |  17 ++--
src/lxc/lxc_process.c              | 141 +++++++++++------------------
src/lxc/lxc_process.h              |   8 +-
6 files changed, 69 insertions(+), 125 deletions(-)

Expand all Fold all

[PATCH 0/7] Refactor closecallback use in LXC

Posted by Peter Krempa 1 year, 9 months ago

The end-goal is to remove 'virCloseCallbacksGetConn'.

Peter Krempa (7):
  virLXCProcessStop: Add 'cleanupFlags' parameter
  virLXCProcessStart: Pass in virConnect object only when registering
    autodestroy
  virLXCProcessReboot: Simplify cleanup
  virLXCProcessAutostartAll: Remove unused 'conn'
  virLXCProcessAutostartDomain: Refactor control flow and variable use
  virLXCProcessReboot: Remove the need to re-register autodestroy
    callback
  virclosecallbacks: Remove unused virCloseCallbacksGetConn

 src/hypervisor/virclosecallbacks.c |  24 -----
 src/hypervisor/virclosecallbacks.h |   3 -
 src/libvirt_private.syms           |   1 -
 src/lxc/lxc_driver.c               |  17 ++--
 src/lxc/lxc_process.c              | 141 +++++++++++------------------
 src/lxc/lxc_process.h              |   8 +-
 6 files changed, 69 insertions(+), 125 deletions(-)

-- 
2.36.1

Re: [PATCH 0/7] Refactor closecallback use in LXC

Posted by Tim Wiederhake 1 year, 9 months ago

On Tue, 2022-07-19 at 12:45 +0200, Peter Krempa wrote:
> The end-goal is to remove 'virCloseCallbacksGetConn'.
> 
> Peter Krempa (7):
>   virLXCProcessStop: Add 'cleanupFlags' parameter
>   virLXCProcessStart: Pass in virConnect object only when registering
>     autodestroy
>   virLXCProcessReboot: Simplify cleanup
>   virLXCProcessAutostartAll: Remove unused 'conn'
>   virLXCProcessAutostartDomain: Refactor control flow and variable
> use
>   virLXCProcessReboot: Remove the need to re-register autodestroy
>     callback
>   virclosecallbacks: Remove unused virCloseCallbacksGetConn
> 
>  src/hypervisor/virclosecallbacks.c |  24 -----
>  src/hypervisor/virclosecallbacks.h |   3 -
>  src/libvirt_private.syms           |   1 -
>  src/lxc/lxc_driver.c               |  17 ++--
>  src/lxc/lxc_process.c              | 141 +++++++++++----------------
> --
>  src/lxc/lxc_process.h              |   8 +-
>  6 files changed, 69 insertions(+), 125 deletions(-)
> 
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>