[PATCH 0/7] qemu: Remove unused code for tuning migration parameters

Peter Krempa posted 7 patches 1 year, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1657888221.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                  |   9 +-
src/qemu/qemu_capabilities.h                  |   6 +-
src/qemu/qemu_driver.c                        | 125 ++++++------------
src/qemu/qemu_migration.c                     |  53 +++-----
src/qemu/qemu_migration_params.c              |  18 ---
src/qemu/qemu_monitor.c                       |  55 --------
src/qemu/qemu_monitor.h                       |  11 --
src/qemu/qemu_monitor_json.c                  |  96 --------------
src/qemu/qemu_monitor_json.h                  |  15 ---
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   3 -
.../caps_3.1.0.x86_64.xml                     |   3 -
.../caps_4.0.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   3 -
.../caps_4.0.0.riscv32.xml                    |   3 -
.../caps_4.0.0.riscv64.xml                    |   3 -
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml |   3 -
.../caps_4.0.0.x86_64.xml                     |   3 -
.../caps_4.1.0.x86_64.xml                     |   3 -
.../caps_4.2.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   3 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |   3 -
.../caps_4.2.0.x86_64.xml                     |   3 -
.../caps_5.0.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   3 -
.../caps_5.0.0.riscv64.xml                    |   3 -
.../caps_5.0.0.x86_64.xml                     |   3 -
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   3 -
.../caps_5.1.0.x86_64.xml                     |   3 -
.../caps_5.2.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |   3 -
.../caps_5.2.0.riscv64.xml                    |   3 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml |   3 -
.../caps_5.2.0.x86_64.xml                     |   3 -
.../caps_6.0.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml |   3 -
.../caps_6.0.0.x86_64.xml                     |   3 -
.../caps_6.1.0.x86_64.xml                     |   3 -
.../caps_6.2.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |   3 -
.../caps_6.2.0.x86_64.xml                     |   3 -
.../caps_7.0.0.aarch64.xml                    |   3 -
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |   3 -
.../caps_7.0.0.x86_64.xml                     |   3 -
.../caps_7.1.0.x86_64.xml                     |   3 -
tests/qemumonitorjsontest.c                   |  39 ------
45 files changed, 59 insertions(+), 473 deletions(-)
[PATCH 0/7] qemu: Remove unused code for tuning migration parameters
Posted by Peter Krempa 1 year, 9 months ago
All qemu versions supported by libvirt allow setting everything via
migration parameters which is also the preferred code path in libvirt.

Remove the legacy code.

Peter Krempa (7):
  qemu: Always assume support for QEMU_CAPS_MIGRATION_PARAM_BANDWIDTH
  qemu: capabilities: Retire QEMU_CAPS_MIGRATION_PARAM_BANDWIDTH
  qemu: driver: Always assume support for
    QEMU_CAPS_MIGRATION_PARAM_DOWNTIME
  qemu: capabilties: Retire QEMU_CAPS_MIGRATION_PARAM_DOWNTIME
  qemu: Always assume support for
    QEMU_CAPS_MIGRATION_PARAM_XBZRLE_CACHE_SIZE
  qemu: capabilities: Retire QEMU_CAPS_MIGRATION_PARAM_XBZRLE_CACHE_SIZE
  qemu: monitor: Remove unused migration property getters/setters

 src/qemu/qemu_capabilities.c                  |   9 +-
 src/qemu/qemu_capabilities.h                  |   6 +-
 src/qemu/qemu_driver.c                        | 125 ++++++------------
 src/qemu/qemu_migration.c                     |  53 +++-----
 src/qemu/qemu_migration_params.c              |  18 ---
 src/qemu/qemu_monitor.c                       |  55 --------
 src/qemu/qemu_monitor.h                       |  11 --
 src/qemu/qemu_monitor_json.c                  |  96 --------------
 src/qemu/qemu_monitor_json.h                  |  15 ---
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   3 -
 .../caps_3.1.0.x86_64.xml                     |   3 -
 .../caps_4.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   3 -
 .../caps_4.0.0.riscv32.xml                    |   3 -
 .../caps_4.0.0.riscv64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |   3 -
 .../caps_4.0.0.x86_64.xml                     |   3 -
 .../caps_4.1.0.x86_64.xml                     |   3 -
 .../caps_4.2.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   3 -
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |   3 -
 .../caps_4.2.0.x86_64.xml                     |   3 -
 .../caps_5.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   3 -
 .../caps_5.0.0.riscv64.xml                    |   3 -
 .../caps_5.0.0.x86_64.xml                     |   3 -
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   3 -
 .../caps_5.1.0.x86_64.xml                     |   3 -
 .../caps_5.2.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |   3 -
 .../caps_5.2.0.riscv64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |   3 -
 .../caps_5.2.0.x86_64.xml                     |   3 -
 .../caps_6.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |   3 -
 .../caps_6.0.0.x86_64.xml                     |   3 -
 .../caps_6.1.0.x86_64.xml                     |   3 -
 .../caps_6.2.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |   3 -
 .../caps_6.2.0.x86_64.xml                     |   3 -
 .../caps_7.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |   3 -
 .../caps_7.0.0.x86_64.xml                     |   3 -
 .../caps_7.1.0.x86_64.xml                     |   3 -
 tests/qemumonitorjsontest.c                   |  39 ------
 45 files changed, 59 insertions(+), 473 deletions(-)

-- 
2.36.1
Re: [PATCH 0/7] qemu: Remove unused code for tuning migration parameters
Posted by Michal Prívozník 1 year, 9 months ago
On 7/15/22 14:31, Peter Krempa wrote:
> All qemu versions supported by libvirt allow setting everything via
> migration parameters which is also the preferred code path in libvirt.
> 
> Remove the legacy code.
> 
> Peter Krempa (7):
>   qemu: Always assume support for QEMU_CAPS_MIGRATION_PARAM_BANDWIDTH
>   qemu: capabilities: Retire QEMU_CAPS_MIGRATION_PARAM_BANDWIDTH
>   qemu: driver: Always assume support for
>     QEMU_CAPS_MIGRATION_PARAM_DOWNTIME
>   qemu: capabilties: Retire QEMU_CAPS_MIGRATION_PARAM_DOWNTIME
>   qemu: Always assume support for
>     QEMU_CAPS_MIGRATION_PARAM_XBZRLE_CACHE_SIZE
>   qemu: capabilities: Retire QEMU_CAPS_MIGRATION_PARAM_XBZRLE_CACHE_SIZE
>   qemu: monitor: Remove unused migration property getters/setters
> 
>  src/qemu/qemu_capabilities.c                  |   9 +-
>  src/qemu/qemu_capabilities.h                  |   6 +-
>  src/qemu/qemu_driver.c                        | 125 ++++++------------
>  src/qemu/qemu_migration.c                     |  53 +++-----
>  src/qemu/qemu_migration_params.c              |  18 ---
>  src/qemu/qemu_monitor.c                       |  55 --------
>  src/qemu/qemu_monitor.h                       |  11 --
>  src/qemu/qemu_monitor_json.c                  |  96 --------------
>  src/qemu/qemu_monitor_json.h                  |  15 ---
>  .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   3 -
>  .../caps_3.1.0.x86_64.xml                     |   3 -
>  .../caps_4.0.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   3 -
>  .../caps_4.0.0.riscv32.xml                    |   3 -
>  .../caps_4.0.0.riscv64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |   3 -
>  .../caps_4.0.0.x86_64.xml                     |   3 -
>  .../caps_4.1.0.x86_64.xml                     |   3 -
>  .../caps_4.2.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   3 -
>  .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |   3 -
>  .../caps_4.2.0.x86_64.xml                     |   3 -
>  .../caps_5.0.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   3 -
>  .../caps_5.0.0.riscv64.xml                    |   3 -
>  .../caps_5.0.0.x86_64.xml                     |   3 -
>  .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   3 -
>  .../caps_5.1.0.x86_64.xml                     |   3 -
>  .../caps_5.2.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |   3 -
>  .../caps_5.2.0.riscv64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |   3 -
>  .../caps_5.2.0.x86_64.xml                     |   3 -
>  .../caps_6.0.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |   3 -
>  .../caps_6.0.0.x86_64.xml                     |   3 -
>  .../caps_6.1.0.x86_64.xml                     |   3 -
>  .../caps_6.2.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |   3 -
>  .../caps_6.2.0.x86_64.xml                     |   3 -
>  .../caps_7.0.0.aarch64.xml                    |   3 -
>  .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |   3 -
>  .../caps_7.0.0.x86_64.xml                     |   3 -
>  .../caps_7.1.0.x86_64.xml                     |   3 -
>  tests/qemumonitorjsontest.c                   |  39 ------
>  45 files changed, 59 insertions(+), 473 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal