[PATCH 0/6] Improve setting of logging with 'virt-admin' when daemon uses auto-shutdown

Peter Krempa posted 6 patches 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1655128518.git.pkrempa@redhat.com
docs/kbase/debuglogs.rst            |  20 +++++
docs/manpages/virt-admin.rst        |  12 +++
include/libvirt/libvirt-admin.h     |   4 +
scripts/apibuild.py                 |   2 +
src/admin/admin_protocol.x          |  12 ++-
src/admin/admin_server_dispatch.c   |  12 +++
src/admin/libvirt-admin.c           |  34 ++++++++
src/admin/libvirt_admin_public.syms |   5 ++
src/admin_protocol-structs          |   5 ++
src/locking/lock_daemon.c           |   5 +-
src/logging/log_daemon.c            |   5 +-
src/remote/remote_daemon.c          |   4 +-
src/rpc/virnetdaemon.c              | 127 ++++++++++++++++++----------
src/rpc/virnetdaemon.h              |   4 +-
tools/virt-admin.c                  |  45 ++++++++++
15 files changed, 240 insertions(+), 56 deletions(-)
[PATCH 0/6] Improve setting of logging with 'virt-admin' when daemon uses auto-shutdown
Posted by Peter Krempa 1 year, 11 months ago
Allow setting of the timeout so that users can bypass it when they are
setting runtime-logging.

Update the docs to mention the caveat and suggest the bypass.

Peter Krempa (6):
  virnetdaemon: Extract autoShutdownTimer operations from
    virNetDaemonRun
  virNetDaemonAutoShutdown: Allow live update of shutdown timeout
  scripts: apibuild: Improve error when API is missing from symbol file
  admin: Introduce virAdmConnectSetDaemonTimeout
  virt-admin: Introduce 'daemon-timeout'
  kbase: debuglogs: Add a note about auto-shutdown of daemons

 docs/kbase/debuglogs.rst            |  20 +++++
 docs/manpages/virt-admin.rst        |  12 +++
 include/libvirt/libvirt-admin.h     |   4 +
 scripts/apibuild.py                 |   2 +
 src/admin/admin_protocol.x          |  12 ++-
 src/admin/admin_server_dispatch.c   |  12 +++
 src/admin/libvirt-admin.c           |  34 ++++++++
 src/admin/libvirt_admin_public.syms |   5 ++
 src/admin_protocol-structs          |   5 ++
 src/locking/lock_daemon.c           |   5 +-
 src/logging/log_daemon.c            |   5 +-
 src/remote/remote_daemon.c          |   4 +-
 src/rpc/virnetdaemon.c              | 127 ++++++++++++++++++----------
 src/rpc/virnetdaemon.h              |   4 +-
 tools/virt-admin.c                  |  45 ++++++++++
 15 files changed, 240 insertions(+), 56 deletions(-)

-- 
2.36.1
Re: [PATCH 0/6] Improve setting of logging with 'virt-admin' when daemon uses auto-shutdown
Posted by Michal Prívozník 1 year, 11 months ago
On 6/13/22 15:56, Peter Krempa wrote:
> Allow setting of the timeout so that users can bypass it when they are
> setting runtime-logging.
> 
> Update the docs to mention the caveat and suggest the bypass.
> 
> Peter Krempa (6):
>   virnetdaemon: Extract autoShutdownTimer operations from
>     virNetDaemonRun
>   virNetDaemonAutoShutdown: Allow live update of shutdown timeout
>   scripts: apibuild: Improve error when API is missing from symbol file
>   admin: Introduce virAdmConnectSetDaemonTimeout
>   virt-admin: Introduce 'daemon-timeout'
>   kbase: debuglogs: Add a note about auto-shutdown of daemons
> 
>  docs/kbase/debuglogs.rst            |  20 +++++
>  docs/manpages/virt-admin.rst        |  12 +++
>  include/libvirt/libvirt-admin.h     |   4 +
>  scripts/apibuild.py                 |   2 +
>  src/admin/admin_protocol.x          |  12 ++-
>  src/admin/admin_server_dispatch.c   |  12 +++
>  src/admin/libvirt-admin.c           |  34 ++++++++
>  src/admin/libvirt_admin_public.syms |   5 ++
>  src/admin_protocol-structs          |   5 ++
>  src/locking/lock_daemon.c           |   5 +-
>  src/logging/log_daemon.c            |   5 +-
>  src/remote/remote_daemon.c          |   4 +-
>  src/rpc/virnetdaemon.c              | 127 ++++++++++++++++++----------
>  src/rpc/virnetdaemon.h              |   4 +-
>  tools/virt-admin.c                  |  45 ++++++++++
>  15 files changed, 240 insertions(+), 56 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal