[libvirt PATCH 0/3] Fix null string specifiers detected by GCC

Scott Davis posted 3 patches 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1653517208.git.scott.davis@starlab.io
src/qemu/qemu_driver.c      | 8 ++++----
src/remote/remote_sockets.c | 2 +-
src/util/vircgroupv1.c      | 5 ++---
3 files changed, 7 insertions(+), 8 deletions(-)
[libvirt PATCH 0/3] Fix null string specifiers detected by GCC
Posted by Scott Davis 1 year, 11 months ago
Each of the following tripped the -Wformat-overflow warning in GCC 11. The
fixes all seemed pretty obvious based on the context.

Apologies for any formatting or other mistakes, this is my first time
submitting libvirt patches and using git publish.

Scott Davis (3):
  qemu: fix null string specifier argument in qemuDomainBlockJobAbort
  remote: fix null string specifier argument in
    remoteProbeSessionDriverFromBinary
  vircgroupv1: fix null string specifier argument in
    virCgroupV1ValidatePlacement

 src/qemu/qemu_driver.c      | 8 ++++----
 src/remote/remote_sockets.c | 2 +-
 src/util/vircgroupv1.c      | 5 ++---
 3 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.25.1
Re: [libvirt PATCH 0/3] Fix null string specifiers detected by GCC
Posted by Ján Tomko 1 year, 11 months ago
On a Wednesday in 2022, Scott Davis wrote:
>Each of the following tripped the -Wformat-overflow warning in GCC 11. The
>fixes all seemed pretty obvious based on the context.
>
>Apologies for any formatting or other mistakes, this is my first time
>submitting libvirt patches and using git publish.
>

The author (in the From field in the email) has your gmail address
while the sign-off has your starlab address.

If you're okay with me changing the author to match the signoff address,
I can push it after the pipeline succeeds:
https://gitlab.com/janotomko/libvirt/-/pipelines/548600566

>Scott Davis (3):
>  qemu: fix null string specifier argument in qemuDomainBlockJobAbort
>  remote: fix null string specifier argument in
>    remoteProbeSessionDriverFromBinary
>  vircgroupv1: fix null string specifier argument in
>    virCgroupV1ValidatePlacement
>
> src/qemu/qemu_driver.c      | 8 ++++----
> src/remote/remote_sockets.c | 2 +-
> src/util/vircgroupv1.c      | 5 ++---
> 3 files changed, 7 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano