Avoid memcpy with NULL argument

[PATCH 0/2] Avoid memcpy with NULL argument

Peter Krempa posted 2 patches 1 year, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1653476354.git.pkrempa@redhat.com

src/rpc/virkeepalive.c        |  2 +-
src/rpc/virnetmessage.c       | 76 ++++++++++++++---------------------
src/rpc/virnetmessage.h       |  2 -
src/rpc/virnetserverprogram.c |  9 +----
4 files changed, 34 insertions(+), 55 deletions(-)

Expand all Fold all

[PATCH 0/2] Avoid memcpy with NULL argument

Posted by Peter Krempa 1 year, 11 months ago

Behaviour is undefined per C standard.

Peter Krempa (2):
  virNetMessageEncodePayloadRaw: Tolerate empty 'data'
  virNetMessageEncodePayloadEmpty: Replace by
    virNetMessageEncodePayloadRaw(msg, NULL, 0)

 src/rpc/virkeepalive.c        |  2 +-
 src/rpc/virnetmessage.c       | 76 ++++++++++++++---------------------
 src/rpc/virnetmessage.h       |  2 -
 src/rpc/virnetserverprogram.c |  9 +----
 4 files changed, 34 insertions(+), 55 deletions(-)

-- 
2.35.3

Re: [PATCH 0/2] Avoid memcpy with NULL argument

Posted by Michal Prívozník 1 year, 11 months ago

On 5/25/22 13:01, Peter Krempa wrote:
> Behaviour is undefined per C standard.
> 
> Peter Krempa (2):
>   virNetMessageEncodePayloadRaw: Tolerate empty 'data'
>   virNetMessageEncodePayloadEmpty: Replace by
>     virNetMessageEncodePayloadRaw(msg, NULL, 0)
> 
>  src/rpc/virkeepalive.c        |  2 +-
>  src/rpc/virnetmessage.c       | 76 ++++++++++++++---------------------
>  src/rpc/virnetmessage.h       |  2 -
>  src/rpc/virnetserverprogram.c |  9 +----
>  4 files changed, 34 insertions(+), 55 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/2] Avoid memcpy with NULL argument

Posted by Claudio Fontana 1 year, 11 months ago

On 5/25/22 1:01 PM, Peter Krempa wrote:
> Behaviour is undefined per C standard.
> 
> Peter Krempa (2):
>   virNetMessageEncodePayloadRaw: Tolerate empty 'data'
>   virNetMessageEncodePayloadEmpty: Replace by
>     virNetMessageEncodePayloadRaw(msg, NULL, 0)
> 
>  src/rpc/virkeepalive.c        |  2 +-
>  src/rpc/virnetmessage.c       | 76 ++++++++++++++---------------------
>  src/rpc/virnetmessage.h       |  2 -
>  src/rpc/virnetserverprogram.c |  9 +----
>  4 files changed, 34 insertions(+), 55 deletions(-)
> 
Both patches seem correct to me.

Reviewed-by: Claudio Fontana <cfontana@suse.de>