From nobody Mon May 13 03:18:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653306981; cv=none; d=zohomail.com; s=zohoarc; b=aAQNynGkAxP85mp/bndCWXxnF/153Y8Xfpn9nkKTj7mImGy9ZXjWP/iElECXpy+hSbvUfPOgFM4B1wvRJM8CGYW84GMRyak8kdoRxzU5XEKwO8hjLfrYasosBOnUPjXcti2VBR8Nd+O9hYhLPPdVMOCQH3m7vIa0RC5lZ268vJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653306981; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lRwt3Vl5cxnRuUvSzxzab29ViVvnsQVf0bEZ6oeuPpo=; b=MiRoOwXw3P+cSlLfPFzdKYWgxnexPtjzrq3BGFR1O5x8ezosTPQXNCcP0i8KRrKM9Dpz8XT/qhi0T2cmUT1N1Xg8/o/Tbym6Ym7ChjqtLDF78VxydXZ0vfefu+s2HJttOgDnGGOrWMWVUBiWfb1ZkyKefFrYlsEb/7b1Zyj4ypw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1653306981018974.914037674596; Mon, 23 May 2022 04:56:21 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-bFkINrEnMu2Fr-XIB0ym0Q-1; Mon, 23 May 2022 07:56:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D55DD811E78; Mon, 23 May 2022 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C02DE2166B2F; Mon, 23 May 2022 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id ECCE01947079; Mon, 23 May 2022 11:56:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0FDDE194705B for ; Mon, 23 May 2022 11:56:07 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E1CAF2026E03; Mon, 23 May 2022 11:56:06 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BCE42026D2F for ; Mon, 23 May 2022 11:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653306979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lRwt3Vl5cxnRuUvSzxzab29ViVvnsQVf0bEZ6oeuPpo=; b=LNt6Crt2FaNvhc0NJMnH6iEXaP6tQh9C/1ku7HC4BTFNfoUlk2lseMfpF0+6TWo5rsraSX TYocUz5nJsh4d73beNLpilc4XNxz6zcDuKPoViYXEBrBryKcNoLyX6kgNIT0r464AWze/z Iq8w4MueiEU4GTxWjn3TpPvcSltjvQE= X-MC-Unique: bFkINrEnMu2Fr-XIB0ym0Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/2] docs: domain: Remove extraneous quotes Date: Mon, 23 May 2022 13:56:03 +0200 Message-Id: <8ff72592fdd3b1787e6ee9e0350ab979fe9fb9d7.1653306919.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653306982117100001 Content-Type: text/plain; charset="utf-8" Certain documentation bits tried to put a reference of a value into quotes, but that's not needed for both the pure view of the rST source and the rendered output. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- docs/formatdomain.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 089a99b4b5..085a929bee 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -576,8 +576,8 @@ layout of sub-elements, with supported values of: The ``sysinfo`` element can have multiple ``entry`` child elements. Each element then has mandatory ``name`` attribute, which defines the name o= f the - blob and must begin with ``"opt/"`` and to avoid clashing with other na= mes is - advised to be in form ``"opt/$RFQDN/$name"`` where ``$RFQDN`` is a reve= rse + blob and must begin with ``opt/`` and to avoid clashing with other name= s is + advised to be in form ``opt/$RFQDN/$name`` where ``$RFQDN`` is a reverse fully qualified domain name you control. Then, the element can either c= ontain the value (to set the blob value directly), or ``file`` attribute (to s= et the blob value from the file). @@ -2613,11 +2613,11 @@ paravirtualized driver is specified via the ``disk`= ` element. ``device`` is 'lun'. :since:`Since 1.0.2` ``snapshot`` Indicates the default behavior of the disk during disk snapshots: - "``internal``" requires a file format such as qcow2 that can store b= oth - the snapshot and the data changes since the snapshot; "``external``"= will - separate the snapshot from the live data; "``no``" means the disk wi= ll + ``internal`` requires a file format such as qcow2 that can store both + the snapshot and the data changes since the snapshot; ``external`` w= ill + separate the snapshot from the live data; ``no`` means the disk will not participate in snapshots; and ``manual`` allows snapshotting don= e via - an unmanaged storage provider. Read-only disks default to "``no``", = while + an unmanaged storage provider. Read-only disks default to ``no``, wh= ile the default for other disks depends on the hypervisor's capabilities. Some hypervisors allow a per-snapshot choice as well, during `domain snapshot creation `__. Not all snapshot modes a= re @@ -5001,10 +5001,10 @@ directly reference an SRIOV VF device: ... The ```` element required attribute ``type`` will be set to either -``"persistent"`` to indicate a device that should always be present in the -domain, or ``"transient"`` to indicate a device that may periodically be +``persistent`` to indicate a device that should always be present in the +domain, or ``transient`` to indicate a device that may periodically be removed, then later re-added to the domain. When type=3D"transient", there= should -be a second attribute to ```` called ``"persistent"`` - this attr= ibute +be a second attribute to ```` called ``persistent`` - this attrib= ute should be set to the alias name of the other device in the pair (the one t= hat has ````). @@ -5210,7 +5210,7 @@ Setting NIC driver-specific options Some NICs may have tunable driver-specific options. These are set as attri= butes of the ``driver`` sub-element of the interface definition. Currently the -following attributes are available for the ``"virtio"`` NIC driver: +following attributes are available for the ``virtio`` NIC driver: ``name`` The optional ``name`` attribute forces which type of backend driver to = use. --=20 2.35.3 From nobody Mon May 13 03:18:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653307024; cv=none; d=zohomail.com; s=zohoarc; b=mwQokg3uppz82PH9mW3lPEBG/MlJ4sxPfMzsh1FOzAlr9rM2I/+bsM+NsuztWq436z9Rx5nVDFzMCmS+CE7H4ThK9Ss+OUC61HlQH5GTAJacu+dg5jcQtdxBe5Ah0f8vkzGVUHW47SZAbtQiUd4XUJcMZRW9c6MlbG4eSyXrrTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653307024; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Elar+/lCa9RvY5IbPoHeCBNy6Vzrd3IuJaEhu8dFaP4=; b=CUsG5RtvUvvsF5UXfHygxnXdiZbJhYxJSL+Pbg925Z1wp212Rk5r6ItgmlEaK3DHPzwTAvQhg8TcELAfLdW0Xv9Cy8IQeYJEFq1RUDP3XZJ4mFYXTRV9W9aI9h+wTrRJgxVdMIjQ1TmFIrXpa9puB4565p5/uzXhDXkzluedek0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1653307024563709.5716829634523; Mon, 23 May 2022 04:57:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-H9bnq0N_PZ69Jfu_RasQsg-1; Mon, 23 May 2022 07:56:13 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D481F804199; Mon, 23 May 2022 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7419D492CA3; Mon, 23 May 2022 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A8AFC194706B; Mon, 23 May 2022 11:56:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E261D194706A for ; Mon, 23 May 2022 11:56:07 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BE87E2024CAE; Mon, 23 May 2022 11:56:07 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C6942026D6A for ; Mon, 23 May 2022 11:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653307023; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Elar+/lCa9RvY5IbPoHeCBNy6Vzrd3IuJaEhu8dFaP4=; b=dTf9digWHEv0eVNkhjp6XuL1DwoP0/BbgaB9kGfCgT5sysYFftfLc77JGuJartoQucuIcE 2qKWiQMdlagVzNg+OKxhecI3E+yRq4+lxxVRgwMs3y5b+vjw2ZbUAWtJw5NLrjMEnQV5rf gxSBw/nWbxS1Taqze+rtuIY0HyEwllY= X-MC-Unique: H9bnq0N_PZ69Jfu_RasQsg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/2] schemas: Allow 'manual' snapshot mode in domain definition Date: Mon, 23 May 2022 13:56:04 +0200 Message-Id: <18356b89064d3917d5fbabf325bd021602b87f3e.1653306919.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653307026327100001 Content-Type: text/plain; charset="utf-8" Commit a1465e661e7 added the 'manual' disk snapshot mode documentation but didn't allow it in the schema as default snapshot mode for a disk. Add the needed value into the schema. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 7bef4910e1..cc598212a8 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -1544,6 +1544,7 @@ no internal external + manual --=20 2.35.3