virIdentity: Don't leak params in virGetConnectGeneric and refactor

[PATCH 0/4] virIdentity: Don't leak params in virGetConnectGeneric and refactor

Peter Krempa posted 4 patches 1 year, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1652865683.git.pkrempa@redhat.com

src/driver.c                        |  8 +++----
src/libvirt_private.syms            |  1 +
src/remote/remote_daemon_dispatch.c | 36 ++++++++++++-----------------
src/util/viridentity.c              | 15 ++++--------
src/util/viridentity.h              |  5 ++--
src/util/virtypedparam.c            | 13 +++++++++++
src/util/virtypedparam.h            |  4 ++++
7 files changed, 44 insertions(+), 38 deletions(-)

Expand all Fold all

[PATCH 0/4] virIdentity: Don't leak params in virGetConnectGeneric and refactor

Posted by Peter Krempa 1 year, 11 months ago

Fix a memleak and make the code a bit neater.

Peter Krempa (4):
  util: typedparam: Introduce virTypedParamListFromParams
  virGetConnectGeneric: Fix memleak of 'identparams' when connecting
    between split daemons
  virIdentityGetParameters: Return 'virTypedParamList'
  doRemoteOpen: Refactor control flow

 src/driver.c                        |  8 +++----
 src/libvirt_private.syms            |  1 +
 src/remote/remote_daemon_dispatch.c | 36 ++++++++++++-----------------
 src/util/viridentity.c              | 15 ++++--------
 src/util/viridentity.h              |  5 ++--
 src/util/virtypedparam.c            | 13 +++++++++++
 src/util/virtypedparam.h            |  4 ++++
 7 files changed, 44 insertions(+), 38 deletions(-)

-- 
2.35.3

Re: [PATCH 0/4] virIdentity: Don't leak params in virGetConnectGeneric and refactor

Posted by Pavel Hrdina 1 year, 11 months ago

On Wed, May 18, 2022 at 11:22:09AM +0200, Peter Krempa wrote:
> Fix a memleak and make the code a bit neater.
> 
> Peter Krempa (4):
>   util: typedparam: Introduce virTypedParamListFromParams
>   virGetConnectGeneric: Fix memleak of 'identparams' when connecting
>     between split daemons
>   virIdentityGetParameters: Return 'virTypedParamList'
>   doRemoteOpen: Refactor control flow

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>