test: Link qemuhotplugmock with test_utils_qemu and test_utils

[PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

Posted by Michal Privoznik 2 years ago

This is an alternative version to:

https://listman.redhat.com/archives/libvir-list/2022-April/230092.html

Michal Prívozník (2):
  test: Link qemuhotplugmock with test_utils_qemu and test_utils
  tests: Deduplicate some WITH_* checks

 tests/meson.build | 94 +++++++++++++++++++++--------------------------
 1 file changed, 41 insertions(+), 53 deletions(-)

-- 
2.35.1

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

Posted by Ján Tomko 2 years ago

On a Monday in 2022, Michal Privoznik wrote:
>This is an alternative version to:
>
>https://listman.redhat.com/archives/libvir-list/2022-April/230092.html
>
>Michal Prívozník (2):
>  test: Link qemuhotplugmock with test_utils_qemu and test_utils
>  tests: Deduplicate some WITH_* checks
>
> tests/meson.build | 94 +++++++++++++++++++++--------------------------
> 1 file changed, 41 insertions(+), 53 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

Posted by Daniel P. Berrangé 1 year, 12 months ago

On Thu, May 05, 2022 at 01:20:54PM +0200, Ján Tomko wrote:
> On a Monday in 2022, Michal Privoznik wrote:
> > This is an alternative version to:
> > 
> > https://listman.redhat.com/archives/libvir-list/2022-April/230092.html
> > 
> > Michal Prívozník (2):
> >  test: Link qemuhotplugmock with test_utils_qemu and test_utils
> >  tests: Deduplicate some WITH_* checks
> > 
> > tests/meson.build | 94 +++++++++++++++++++++--------------------------
> > 1 file changed, 41 insertions(+), 53 deletions(-)
> > 
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>

This series appears to have broken clang asan builds on Ubuntu 20.04

  https://gitlab.com/libvirt/libvirt/-/jobs/2417680559

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

Posted by Michal Prívozník 1 year, 12 months ago

On 5/6/22 12:06, Daniel P. Berrangé wrote:
> On Thu, May 05, 2022 at 01:20:54PM +0200, Ján Tomko wrote:
>> On a Monday in 2022, Michal Privoznik wrote:
>>> This is an alternative version to:
>>>
>>> https://listman.redhat.com/archives/libvir-list/2022-April/230092.html
>>>
>>> Michal Prívozník (2):
>>>  test: Link qemuhotplugmock with test_utils_qemu and test_utils
>>>  tests: Deduplicate some WITH_* checks
>>>
>>> tests/meson.build | 94 +++++++++++++++++++++--------------------------
>>> 1 file changed, 41 insertions(+), 53 deletions(-)
>>>
>>
>> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> This series appears to have broken clang asan builds on Ubuntu 20.04
> 
>   https://gitlab.com/libvirt/libvirt/-/jobs/2417680559


Yep, I've posted fix earlier today:

https://listman.redhat.com/archives/libvir-list/2022-May/230750.html

Michal

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

Posted by Michal Prívozník 2 years ago

On 4/25/22 12:37, Michal Privoznik wrote:
> This is an alternative version to:
> 
> https://listman.redhat.com/archives/libvir-list/2022-April/230092.html
> 
> Michal Prívozník (2):
>   test: Link qemuhotplugmock with test_utils_qemu and test_utils
>   tests: Deduplicate some WITH_* checks
> 
>  tests/meson.build | 94 +++++++++++++++++++++--------------------------
>  1 file changed, 41 insertions(+), 53 deletions(-)
> 

Polite ping.

Michal