[PATCH 0/3] Cleanups based on 'nvram' refactor patch

Peter Krempa posted 3 patches 2 years, 1 month ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1648477590.git.pkrempa@redhat.com
src/conf/domain_conf.c   | 40 +++++++++++++--------------
src/libvirt_private.syms |  1 +
src/util/virxml.c        | 58 +++++++++++++++++++++++++++++++---------
src/util/virxml.h        |  7 +++++
src/vbox/vbox_common.c   | 36 ++++++++++++-------------
5 files changed, 90 insertions(+), 52 deletions(-)
[PATCH 0/3] Cleanups based on 'nvram' refactor patch
Posted by Peter Krempa 2 years, 1 month ago
Few cleanups that I've suggested in the review for adding remote store
of nvram.

Peter Krempa (3):
  virXMLFormatElement: Introduce virXMLFormatElementInternal
  virDomainLoaderDefFormat: Use modern XML formatting approach
  vboxSetBootDeviceOrder: Remove whitespace alignment in VIR_DEBUG
    statements

 src/conf/domain_conf.c   | 40 +++++++++++++--------------
 src/libvirt_private.syms |  1 +
 src/util/virxml.c        | 58 +++++++++++++++++++++++++++++++---------
 src/util/virxml.h        |  7 +++++
 src/vbox/vbox_common.c   | 36 ++++++++++++-------------
 5 files changed, 90 insertions(+), 52 deletions(-)

-- 
2.35.1
Re: [PATCH 0/3] Cleanups based on 'nvram' refactor patch
Posted by Ján Tomko 2 years, 1 month ago
On a Monday in 2022, Peter Krempa wrote:
>Few cleanups that I've suggested in the review for adding remote store
>of nvram.
>
>Peter Krempa (3):
>  virXMLFormatElement: Introduce virXMLFormatElementInternal
>  virDomainLoaderDefFormat: Use modern XML formatting approach
>  vboxSetBootDeviceOrder: Remove whitespace alignment in VIR_DEBUG
>    statements
>
> src/conf/domain_conf.c   | 40 +++++++++++++--------------
> src/libvirt_private.syms |  1 +
> src/util/virxml.c        | 58 +++++++++++++++++++++++++++++++---------
> src/util/virxml.h        |  7 +++++
> src/vbox/vbox_common.c   | 36 ++++++++++++-------------
> 5 files changed, 90 insertions(+), 52 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano