[PATCH v2 0/6] qemu: Add qemu-namespace XML to override device properties (-set replacement)

Peter Krempa posted 6 patches 2 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1647948278.git.pkrempa@redhat.com
Test syntax-check passed
NEWS.rst                                      |   7 +
docs/drvqemu.rst                              |  57 +++++
src/conf/domain_conf.c                        |   2 +
src/conf/domain_conf.h                        |   1 +
src/conf/schemas/domaincommon.rng             |  42 ++++
src/qemu/qemu_command.c                       | 133 +++++++----
src/qemu/qemu_domain.c                        | 221 ++++++++++++++++++
src/qemu/qemu_domain.h                        |  33 +++
.../qemu-ns.x86_64-4.0.0.args                 |   2 +-
.../qemu-ns.x86_64-latest.args                |   2 +-
tests/qemuxml2argvdata/qemu-ns.xml            |  14 ++
.../qemu-ns.x86_64-latest.xml                 |  14 ++
12 files changed, 478 insertions(+), 50 deletions(-)
[PATCH v2 0/6] qemu: Add qemu-namespace XML to override device properties (-set replacement)
Posted by Peter Krempa 2 years, 1 month ago
v2:
 - patch 1/7 from last time was pushed
 - XML changes:
    - top level element renamed to "qemu:override" to accomodate
      possible extension in the future
    - wrapped 'qemu:props' meant to override the frontend under a
      'qemu:frontend' element
 - code changes:
    - renamed few bits (dropped 'Device') from code that can theoretically be reused
    - split out some functions for enhanced extensibility in the future

Peter Krempa (6):
  docs: drvqemu: Document overriding of device properties
  qemu: domain: Add XML namespace code for overriding device config
  conf: Introduce VIR_DOMAIN_TAINT_CUSTOM_DEVICE and use it in qemu
  qemuBuildDeviceCommandlineFromJSON: Pass 'virDomainDef' into the
    function
  qemu: command: Override device definition according to the namespace
    config
  NEWS: Mention the qemu device property override feature

 NEWS.rst                                      |   7 +
 docs/drvqemu.rst                              |  57 +++++
 src/conf/domain_conf.c                        |   2 +
 src/conf/domain_conf.h                        |   1 +
 src/conf/schemas/domaincommon.rng             |  42 ++++
 src/qemu/qemu_command.c                       | 133 +++++++----
 src/qemu/qemu_domain.c                        | 221 ++++++++++++++++++
 src/qemu/qemu_domain.h                        |  33 +++
 .../qemu-ns.x86_64-4.0.0.args                 |   2 +-
 .../qemu-ns.x86_64-latest.args                |   2 +-
 tests/qemuxml2argvdata/qemu-ns.xml            |  14 ++
 .../qemu-ns.x86_64-latest.xml                 |  14 ++
 12 files changed, 478 insertions(+), 50 deletions(-)

-- 
2.35.1
Re: [PATCH v2 0/6] qemu: Add qemu-namespace XML to override device properties (-set replacement)
Posted by Michal Prívozník 2 years, 1 month ago
On 3/22/22 12:27, Peter Krempa wrote:
> v2:
>  - patch 1/7 from last time was pushed
>  - XML changes:
>     - top level element renamed to "qemu:override" to accomodate
>       possible extension in the future
>     - wrapped 'qemu:props' meant to override the frontend under a
>       'qemu:frontend' element
>  - code changes:
>     - renamed few bits (dropped 'Device') from code that can theoretically be reused
>     - split out some functions for enhanced extensibility in the future
> 
> Peter Krempa (6):
>   docs: drvqemu: Document overriding of device properties
>   qemu: domain: Add XML namespace code for overriding device config
>   conf: Introduce VIR_DOMAIN_TAINT_CUSTOM_DEVICE and use it in qemu
>   qemuBuildDeviceCommandlineFromJSON: Pass 'virDomainDef' into the
>     function
>   qemu: command: Override device definition according to the namespace
>     config
>   NEWS: Mention the qemu device property override feature
> 
>  NEWS.rst                                      |   7 +
>  docs/drvqemu.rst                              |  57 +++++
>  src/conf/domain_conf.c                        |   2 +
>  src/conf/domain_conf.h                        |   1 +
>  src/conf/schemas/domaincommon.rng             |  42 ++++
>  src/qemu/qemu_command.c                       | 133 +++++++----
>  src/qemu/qemu_domain.c                        | 221 ++++++++++++++++++
>  src/qemu/qemu_domain.h                        |  33 +++
>  .../qemu-ns.x86_64-4.0.0.args                 |   2 +-
>  .../qemu-ns.x86_64-latest.args                |   2 +-
>  tests/qemuxml2argvdata/qemu-ns.xml            |  14 ++
>  .../qemu-ns.x86_64-latest.xml                 |  14 ++
>  12 files changed, 478 insertions(+), 50 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal
Re: [PATCH v2 0/6] qemu: Add qemu-namespace XML to override device properties (-set replacement)
Posted by Peter Krempa 2 years, 1 month ago
On Tue, Mar 22, 2022 at 12:27:19 +0100, Peter Krempa wrote:
> v2:
>  - patch 1/7 from last time was pushed
>  - XML changes:
>     - top level element renamed to "qemu:override" to accomodate
>       possible extension in the future
>     - wrapped 'qemu:props' meant to override the frontend under a
>       'qemu:frontend' element
>  - code changes:
>     - renamed few bits (dropped 'Device') from code that can theoretically be reused
>     - split out some functions for enhanced extensibility in the future
> 
> Peter Krempa (6):
>   docs: drvqemu: Document overriding of device properties
>   qemu: domain: Add XML namespace code for overriding device config
>   conf: Introduce VIR_DOMAIN_TAINT_CUSTOM_DEVICE and use it in qemu
>   qemuBuildDeviceCommandlineFromJSON: Pass 'virDomainDef' into the
>     function
>   qemu: command: Override device definition according to the namespace
>     config
>   NEWS: Mention the qemu device property override feature

A bit of an early ping ... it would be great to have this for the
upcoming release.