From nobody Wed May 15 22:31:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647876290; cv=none; d=zohomail.com; s=zohoarc; b=UvQmy37Au1jhBUd6Yzss7QlLAVXtlMVK60GR3RfW+tabbPerFelQBKLoyJ2Jp/LwJwT7/qLHuqe88JIIJJqT14vf6zVmpB2YJB6nkfgiB5GSnVHeMKV5fu3fLrBDWwl/VnaDtny4NFPPIdAyCVKgD17ApeNRWDoBVdVIWoEgOMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647876290; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N/WVKWvS2/M3SW35mrCHQ3AmMwOLlVO5VJgdoAmkC3M=; b=mTXzNMqVaRx0P60t0+zAt30CzXd7+aFW4iClJ6HWfkgV3bOKAXrmdM+mIDTBlHd8ijQiKN2FZJP/uewM00yBiYoS6av7TrKiWlAjzbHe072s+QeowI3EdTu3JOFsemFNfQx60ApMoC+I88CmLJ8pyHipndTR8RIr4C6V58GiDEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1647876290254306.4522648446323; Mon, 21 Mar 2022 08:24:50 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-QaxBVteCO1GcgVaLTm4-7w-1; Mon, 21 Mar 2022 11:24:49 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F7C638008AD; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A5E641D3FF; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7BB761940352; Mon, 21 Mar 2022 15:24:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 28C241947BBE for ; Mon, 21 Mar 2022 15:24:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0A2EA41D3FF; Mon, 21 Mar 2022 15:24:43 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7923840F06A for ; Mon, 21 Mar 2022 15:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647876290; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=N/WVKWvS2/M3SW35mrCHQ3AmMwOLlVO5VJgdoAmkC3M=; b=XWNdPLbcZca65brgvkrpui69rRtn+EjnKD0cXoHH42zXw/V5pFfQXUHLCAzCKb827cET78 DnEDBBnlQeJqYFikKaEiOySMgn/TxPOzVOqryCp8Aeb37gguLlgFjfqt2RaHeOB+CHtEYB LvgtS5tDqqZPBaWLtyEXZsMdJ/UOufc= X-MC-Unique: QaxBVteCO1GcgVaLTm4-7w-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/7] qemuDomainDefNamespaceFormatXML*: Convert to virXMLFormatElement Date: Mon, 21 Mar 2022 16:24:34 +0100 Message-Id: <31da00daeea6edd7ac120d684dc2b9272a312c74.1647876193.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647876306438100005 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7180ae616b..3bf864bc5d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3353,25 +3353,19 @@ static void qemuDomainDefNamespaceFormatXMLCommandline(virBuffer *buf, qemuDomainXmlNsDef *cmd) { + g_auto(virBuffer) childBuf =3D VIR_BUFFER_INIT_CHILD(buf); GStrv n; size_t i; - if (!cmd->args && !cmd->num_env) - return; - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - for (n =3D cmd->args; n && *n; n++) - virBufferEscapeString(buf, "\n", *n); + virBufferEscapeString(&childBuf, "\n", *n); for (i =3D 0; i < cmd->num_env; i++) { - virBufferAsprintf(buf, "env[i].name); - virBufferEscapeString(buf, " value=3D'%s'", cmd->env[i].value); - virBufferAddLit(buf, "/>\n"); + virBufferAsprintf(&childBuf, "env[i].= name); + virBufferEscapeString(&childBuf, " value=3D'%s'", cmd->env[i].valu= e); + virBufferAddLit(&childBuf, "/>\n"); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); + virXMLFormatElement(buf, "qemu:commandline", NULL, &childBuf); } @@ -3379,22 +3373,16 @@ static void qemuDomainDefNamespaceFormatXMLCaps(virBuffer *buf, qemuDomainXmlNsDef *xmlns) { + g_auto(virBuffer) childBuf =3D VIR_BUFFER_INIT_CHILD(buf); GStrv n; - if (!xmlns->capsadd && !xmlns->capsdel) - return; - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - for (n =3D xmlns->capsadd; n && *n; n++) - virBufferEscapeString(buf, "\n", *n); + virBufferEscapeString(&childBuf, "\n"= , *n); for (n =3D xmlns->capsdel; n && *n; n++) - virBufferEscapeString(buf, "\n", *n); + virBufferEscapeString(&childBuf, "\n"= , *n); - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); + virXMLFormatElement(buf, "qemu:capabilities", NULL, &childBuf); } --=20 2.35.1 From nobody Wed May 15 22:31:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647876363; cv=none; d=zohomail.com; s=zohoarc; b=d5ZakffrifR41nEzwJCVzFSRBBRlyawiseJAioDfncjUP8zsgwnJLGckJ1YWoXycHKHfqDgGcXwUGIO6ZnU7IuQfk9I8kf8hdKyQI4hGvOVVmxXGIC7Iuis9FxdUu13jRqL4mm8yF0Ro1XS1Ygvl9cz8X7emSP/kdDjYXhhLBIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647876363; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8uRZUFUDCZUy3hUSxn1la1FPW3c5CWRPXNnx0xBXS7Y=; b=Jd91x65h+8dbVF/xsoayrAKC3uAM0F7PLcTWCfnyn0aHO0lTq51RCWLpEwXEwJXpuzKA4hh1G2QbGbhkZRGEceB9WUTrll9m03Mtw6un8G3N8w/ZBnzFzQDfgPk2F9F7EHr8nLsVXJ66peICvnpCuIEh/zXgG64dC+sA+RhzjNY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1647876363702260.9406600435344; Mon, 21 Mar 2022 08:26:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-hwsPWAEFNH6DZP3l7zBIeg-1; Mon, 21 Mar 2022 11:24:51 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F05723C00131; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D54FA145BEEA; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 09CF9193F6E6; Mon, 21 Mar 2022 15:24:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 074611940348 for ; Mon, 21 Mar 2022 15:24:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EB4A441D3ED; Mon, 21 Mar 2022 15:24:43 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 690F240F06A for ; Mon, 21 Mar 2022 15:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647876362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8uRZUFUDCZUy3hUSxn1la1FPW3c5CWRPXNnx0xBXS7Y=; b=c2+/k9T39tQ2lhSwaTo87tx6fdFmyCUndkeLE2uBFNCC53l+WKD+S8S9TOd98+tQkSgAyM Ecbo5SH3d9gwkLu9Tk40sLVZcteDKJwXniLg6E2vBckDz1+uVZuS1YRMZlo0DS6TEAbzfp vvcGjLW9yknUDzTEIORV44gToxqTGLQ= X-MC-Unique: hwsPWAEFNH6DZP3l7zBIeg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/7] docs: drvqemu: Document overriding of device properties Date: Mon, 21 Mar 2022 16:24:35 +0100 Message-Id: <922dafeb8fd64b51103411fcd5b35dab9bbebe3f.1647876193.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647876365488100001 Content-Type: text/plain; charset="utf-8" Upcoming patches will add possibility to override configuration of a device with custom properties as a more versatile replacement to using QEMU's '-set' parameter, which doesn't work when we use JSON to instantiate devices. Describe the XML used for the override as well as expectations of upstream support in case something breaks. Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 52 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index 9d7dd2656b..b13415936c 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -580,6 +580,58 @@ reconfigure libvirtd. *DO NOT* use in production. +Overriding properties of QEMU devices +------------------------------------- + +For development or testing the ```` tag allows to ove= rride +specific properties of devices instantiated by libvirt in QEMU via the +``-device`` argument. + +The ```` sub-element groups overrides for a device identified= via +the ``alias`` attribute. The alias corresponds to the ```` +property of a device. It's strongly recommended to use user-specified alia= ses +for devices with overriden properties. + +The individual properties are overriden by a ```` element. = The +``name`` specifies the name of the property to override. In case when libv= irt +doesn't configure the property a property with the name is added to the +commandline. The ``type`` attribute specifies a type of the argument used.= The +type must correspond with the type that is expected by QEMU. Supported val= ues +for the type attribute are: ``string``, ``number``, ``bool`` (allowed valu= es for +``bool`` are ``true`` and ``false``) and ``remove``. The ``remove`` type is +special and instructs libvirt to remove the property without replacement. + +The overrides are applied only to initial device configuration passed to Q= EMU +via the commandline. Later hotplug operations will not apply any modificat= ions. + +Configuring override for a device alias which is not used or attempting to +remove a device property which is not formatted by libvirt will cause fail= ure +to startup the VM. + +*Note:* The libvirt project doesn't guarantee any form of compatibility and +stability of devices with overriden properties. The domain is tainted when +such configuration is used. + +Example: + +:: + + + testvm + + [...] + + + + + + + + + + + + Example domain XML config ------------------------- --=20 2.35.1 From nobody Wed May 15 22:31:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647876294; cv=none; d=zohomail.com; s=zohoarc; b=KLGcJZx9zj3Q0Q2HUnU3V0X9HyYC3h37kOtTuhgpdcRZTa/gy8+bD6iJaUR8Y6Z6QhTII+OkMwVuZUcfCIGJEGC0PyXOIqRmG4hB3rcKfVbCrUGouSV0aYYFSNHEroqzDQXEkSqDfF6zCKi0jb2JvxIF1Pv6/9A+bDh4W25Zu0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647876294; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0ilRRDDFISKwZiDtbTaQLPAME//Aan3F5rdVgK3uQCA=; b=CQzM1upgvO5UWVjUKfhd/hVe/OYvWo06c9SChklOXVKdb34j3DIMfB3LcRs9/63P1lkI8YZI2PdRhGNpg7OCj8atgsO08vmJ0CCrYaiHBPN6uV2aVtuCYqbmcKkpwjpg7uN3S6ZRXAzFd+rlLfcbFIlD9sEF+pzdT2LRN8B5FE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1647876294018497.14365779328443; Mon, 21 Mar 2022 08:24:54 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-46-UU6ZABS6MyuuqGDgaZe8Jg-1; Mon, 21 Mar 2022 11:24:50 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B25381DA19; Mon, 21 Mar 2022 15:24:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6883D41D3ED; Mon, 21 Mar 2022 15:24:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BD4101940344; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5ECD2193F514 for ; Mon, 21 Mar 2022 15:24:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 416B141D3ED; Mon, 21 Mar 2022 15:24:45 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59B2241D3FD for ; Mon, 21 Mar 2022 15:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647876292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0ilRRDDFISKwZiDtbTaQLPAME//Aan3F5rdVgK3uQCA=; b=hQAROJMWBf1D9SD8Y51r2ilQB+fpUkDeOrfKD49Dv8skr5p/4DrEyfs0dtzvBqJ6SIMhd8 RN6ffDFPLnbuSKSiX4Lxe4UVWkp9Zj9PbbCgNk13smlf8YZeHJ8wTLaj/v2eMyFF4IdQgg 39D4xlIlO/nnyq8Kh1DJglrGEa2WJD8= X-MC-Unique: UU6ZABS6MyuuqGDgaZe8Jg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/7] qemu: domain: Add XML namespace code for overriding device config Date: Mon, 21 Mar 2022 16:24:36 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647876295011100003 Content-Type: text/plain; charset="utf-8" Implement the XML parser and formatter for overriding of device properties such as: Signed-off-by: Peter Krempa --- docs/schemas/domaincommon.rng | 32 +++ src/qemu/qemu_domain.c | 206 ++++++++++++++++++ src/qemu/qemu_domain.h | 33 +++ .../qemu-ns.x86_64-4.0.0.args | 2 +- .../qemu-ns.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/qemu-ns.xml | 12 + .../qemu-ns.x86_64-latest.xml | 12 + 7 files changed, 297 insertions(+), 2 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 9c1b64a644..804ade3f37 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -80,6 +80,9 @@ + + + @@ -7553,6 +7556,35 @@ + + + + + + + + + + + + string + signed + unsigned + bool + remove + + + + + + + + + + + + +