virsh: Completers improvements

[PATCH 0/3] virsh: Completers improvements

Michal Privoznik posted 3 patches 2 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1647328065.git.mprivozn@redhat.com

Test syntax-check failed

tools/virsh-completer-domain.c  | 147 ++++++--------------------------
tools/virsh-completer-host.c    |  11 +--
tools/virsh-completer-nodedev.c |   7 +-
tools/virsh-completer-pool.c    |   7 +-
tools/virsh-completer-volume.c  |  11 +--
tools/virsh-completer.c         |  27 ++++++
tools/virsh-completer.h         |   4 +
7 files changed, 67 insertions(+), 147 deletions(-)

Expand all Fold all

[PATCH 0/3] virsh: Completers improvements

Posted by Michal Privoznik 2 years, 1 month ago

*** BLURB HERE ***

Michal Prívozník (3):
  virsh: Properly terminate string list in
    virshDomainInterfaceSourceModeCompleter()
  virsh: Introduce virshEnumComplete()
  virsh: Don't open code virshEnumComplete()

 tools/virsh-completer-domain.c  | 147 ++++++--------------------------
 tools/virsh-completer-host.c    |  11 +--
 tools/virsh-completer-nodedev.c |   7 +-
 tools/virsh-completer-pool.c    |   7 +-
 tools/virsh-completer-volume.c  |  11 +--
 tools/virsh-completer.c         |  27 ++++++
 tools/virsh-completer.h         |   4 +
 7 files changed, 67 insertions(+), 147 deletions(-)

-- 
2.34.1

Re: [PATCH 0/3] virsh: Completers improvements

Posted by Pavel Hrdina 2 years, 1 month ago

On Tue, Mar 15, 2022 at 08:08:14AM +0100, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (3):
>   virsh: Properly terminate string list in
>     virshDomainInterfaceSourceModeCompleter()
>   virsh: Introduce virshEnumComplete()
>   virsh: Don't open code virshEnumComplete()

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>