Cleanup patches extracted from my upcoming series for handling snapshots
with outsourced storage.

Peter Krempa (14):
  virDomainDiskDefFormat: Refactor to virXMLFormatElement
  qemuSnapshotDiskPrepareActiveExternal: Handle only external snapshots
  qemuSnapshotCreateAlignDisks: Rewrite logic for selecting default
    memory snapshot mode
  virDomainSnapshotDiskDefParseXML: Automatically free temporary
    variables and remove cleanup
  virStorageSource: Convert 'type' to proper enum
  conf: Move definition of 'virDomainSnapshotLocation'
  Rename VIR_DOMAIN_SNAPSHOT_LOCATION_NONE to
    VIR_DOMAIN_SNAPSHOT_LOCATION_NO
  qemuDomainSnapshotForEachQcow2Raw: Act only on internal snapshots
  conf: snapshot: Remove VIR_DOMAIN_SNAPSHOT_PARSE_DISKS flag
  virDomainSnapshotDefParse: Refactor cleanup
  virDomainSnapshotDefParse: Avoid 'memoryfile' temporary variable
  virDomainSnapshotDefParse: Decouple parsing of memory snapshot config
  conf: snapshot: Use proper types for snapshot location
  qemuSnapshotCreateActiveExternal: Remove duplicit assignment

 src/ch/ch_monitor.c                   |   1 +
 src/conf/domain_conf.c                | 122 ++++++------
 src/conf/domain_conf.h                |  14 +-
 src/conf/domain_validate.c            |   2 +-
 src/conf/snapshot_conf.c              | 255 ++++++++++++--------------
 src/conf/snapshot_conf.h              |  23 +--
 src/conf/storage_source_conf.h        |   2 +-
 src/libvirt_private.syms              |   4 +-
 src/qemu/qemu_domain.c                |   2 +-
 src/qemu/qemu_driver.c                |   1 -
 src/qemu/qemu_snapshot.c              |  23 ++-
 src/test/test_driver.c                |   7 +-
 src/vbox/vbox_common.c                |   4 +-
 src/vz/vz_driver.c                    |   2 +-
 src/vz/vz_sdk.c                       |   2 +-
 tests/qemudomainsnapshotxml2xmltest.c |   2 +-
 16 files changed, 221 insertions(+), 245 deletions(-)

-- 
2.35.1

On a Thursday in 2022, Peter Krempa wrote:
>Cleanup patches extracted from my upcoming series for handling snapshots
>with outsourced storage.
>
>Peter Krempa (14):
>  virDomainDiskDefFormat: Refactor to virXMLFormatElement
>  qemuSnapshotDiskPrepareActiveExternal: Handle only external snapshots
>  qemuSnapshotCreateAlignDisks: Rewrite logic for selecting default
>    memory snapshot mode
>  virDomainSnapshotDiskDefParseXML: Automatically free temporary
>    variables and remove cleanup
>  virStorageSource: Convert 'type' to proper enum
>  conf: Move definition of 'virDomainSnapshotLocation'
>  Rename VIR_DOMAIN_SNAPSHOT_LOCATION_NONE to
>    VIR_DOMAIN_SNAPSHOT_LOCATION_NO
>  qemuDomainSnapshotForEachQcow2Raw: Act only on internal snapshots
>  conf: snapshot: Remove VIR_DOMAIN_SNAPSHOT_PARSE_DISKS flag
>  virDomainSnapshotDefParse: Refactor cleanup
>  virDomainSnapshotDefParse: Avoid 'memoryfile' temporary variable
>  virDomainSnapshotDefParse: Decouple parsing of memory snapshot config
>  conf: snapshot: Use proper types for snapshot location
>  qemuSnapshotCreateActiveExternal: Remove duplicit assignment
>
> src/ch/ch_monitor.c                   |   1 +
[..]
> src/vz/vz_driver.c                    |   2 +-
> src/vz/vz_sdk.c                       |   2 +-
> tests/qemudomainsnapshotxml2xmltest.c |   2 +-
> 16 files changed, 221 insertions(+), 245 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano