[PATCH 00/10] qemu: Update capabilities and use 'tls-hostname' field for NBD

Peter Krempa posted 10 patches 2 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1646915026.git.pkrempa@redhat.com
NEWS.rst                                      |    6 +
docs/formatdomain.rst                         |    4 +-
docs/schemas/domaincommon.rng                 |    3 +
src/conf/domain_conf.c                        |    3 +
src/conf/storage_source_conf.c                |    2 +
src/conf/storage_source_conf.h                |    3 +
src/qemu/qemu_block.c                         |    6 +-
src/qemu/qemu_blockjob.c                      |    2 -
src/qemu/qemu_capabilities.c                  |    4 +
src/qemu/qemu_capabilities.h                  |    3 +
src/qemu/qemu_domain.c                        |   15 +
src/qemu/qemu_migration.c                     |   46 +-
src/qemu/qemu_migration_params.c              |   17 +
src/qemu/qemu_migration_params.h              |    3 +
.../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml  |    1 +
.../caps_7.0.0.x86_64.replies                 | 2202 +++++++++--------
.../caps_7.0.0.x86_64.xml                     |   43 +-
...work-tlsx509-nbd-hostname.x86_64-6.2.0.err |    1 +
...rk-tlsx509-nbd-hostname.x86_64-latest.args |   38 +
.../disk-network-tlsx509-nbd-hostname.xml     |   31 +
tests/qemuxml2argvtest.c                      |    2 +
...ork-tlsx509-nbd-hostname.x86_64-latest.xml |   37 +
tests/qemuxml2xmltest.c                       |    1 +
23 files changed, 1390 insertions(+), 1083 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-6.2.0.err
create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.xml
[PATCH 00/10] qemu: Update capabilities and use 'tls-hostname' field for NBD
Posted by Peter Krempa 2 years, 1 month ago
Technically patch 7/10 is more of a RFC for now as my migration setup
doesn't work properly so I could not test it.

Peter Krempa (10):
  tests: qemucapabilities: Update caps_7.0.0.x86_64
  qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_NBD_TLS_HOSTNAME
  qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support
  storage_source: Add 'tlsHostname' field to virStorageSource
  qemu: Add support for 'tlsHostname' setting of virStorageSource
  conf: Add support for setting expected TLS hostname for NBD disks
  qemu: migration: Use 'VIR_MIGRATE_PARAM_TLS_DESTINATION' for the NBD
    connection
  NEWS: Mention that VIR_MIGRATE_PARAM_TLS_DESTINATION works now for
    non-shared storage migration
  qemuMigrationSrcNBDStorageCopyOne: Refactor cleanup
  qemuBlockJobDiskNew: Remove misleading return value description

 NEWS.rst                                      |    6 +
 docs/formatdomain.rst                         |    4 +-
 docs/schemas/domaincommon.rng                 |    3 +
 src/conf/domain_conf.c                        |    3 +
 src/conf/storage_source_conf.c                |    2 +
 src/conf/storage_source_conf.h                |    3 +
 src/qemu/qemu_block.c                         |    6 +-
 src/qemu/qemu_blockjob.c                      |    2 -
 src/qemu/qemu_capabilities.c                  |    4 +
 src/qemu/qemu_capabilities.h                  |    3 +
 src/qemu/qemu_domain.c                        |   15 +
 src/qemu/qemu_migration.c                     |   46 +-
 src/qemu/qemu_migration_params.c              |   17 +
 src/qemu/qemu_migration_params.h              |    3 +
 .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml  |    1 +
 .../caps_7.0.0.x86_64.replies                 | 2202 +++++++++--------
 .../caps_7.0.0.x86_64.xml                     |   43 +-
 ...work-tlsx509-nbd-hostname.x86_64-6.2.0.err |    1 +
 ...rk-tlsx509-nbd-hostname.x86_64-latest.args |   38 +
 .../disk-network-tlsx509-nbd-hostname.xml     |   31 +
 tests/qemuxml2argvtest.c                      |    2 +
 ...ork-tlsx509-nbd-hostname.x86_64-latest.xml |   37 +
 tests/qemuxml2xmltest.c                       |    1 +
 23 files changed, 1390 insertions(+), 1083 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-6.2.0.err
 create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.xml
 create mode 100644 tests/qemuxml2xmloutdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.xml

-- 
2.35.1
Re: [PATCH 00/10] qemu: Update capabilities and use 'tls-hostname' field for NBD
Posted by Ján Tomko 2 years, 1 month ago
On a Thursday in 2022, Peter Krempa wrote:
>Technically patch 7/10 is more of a RFC for now as my migration setup
>doesn't work properly so I could not test it.
>

I have not tested it either.

>Peter Krempa (10):
>  tests: qemucapabilities: Update caps_7.0.0.x86_64
>  qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_NBD_TLS_HOSTNAME
>  qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support
>  storage_source: Add 'tlsHostname' field to virStorageSource
>  qemu: Add support for 'tlsHostname' setting of virStorageSource
>  conf: Add support for setting expected TLS hostname for NBD disks
>  qemu: migration: Use 'VIR_MIGRATE_PARAM_TLS_DESTINATION' for the NBD
>    connection
>  NEWS: Mention that VIR_MIGRATE_PARAM_TLS_DESTINATION works now for
>    non-shared storage migration
>  qemuMigrationSrcNBDStorageCopyOne: Refactor cleanup
>  qemuBlockJobDiskNew: Remove misleading return value description
>
> NEWS.rst                                      |    6 +
> docs/formatdomain.rst                         |    4 +-
> docs/schemas/domaincommon.rng                 |    3 +
> src/conf/domain_conf.c                        |    3 +
> src/conf/storage_source_conf.c                |    2 +
> src/conf/storage_source_conf.h                |    3 +
> src/qemu/qemu_block.c                         |    6 +-
> src/qemu/qemu_blockjob.c                      |    2 -
> src/qemu/qemu_capabilities.c                  |    4 +
> src/qemu/qemu_capabilities.h                  |    3 +
> src/qemu/qemu_domain.c                        |   15 +
> src/qemu/qemu_migration.c                     |   46 +-
> src/qemu/qemu_migration_params.c              |   17 +
> src/qemu/qemu_migration_params.h              |    3 +
> .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml  |    1 +
> .../caps_7.0.0.x86_64.replies                 | 2202 +++++++++--------
> .../caps_7.0.0.x86_64.xml                     |   43 +-
> ...work-tlsx509-nbd-hostname.x86_64-6.2.0.err |    1 +
> ...rk-tlsx509-nbd-hostname.x86_64-latest.args |   38 +
> .../disk-network-tlsx509-nbd-hostname.xml     |   31 +
> tests/qemuxml2argvtest.c                      |    2 +
> ...ork-tlsx509-nbd-hostname.x86_64-latest.xml |   37 +
> tests/qemuxml2xmltest.c                       |    1 +
> 23 files changed, 1390 insertions(+), 1083 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-6.2.0.err
> create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd-hostname.xml
> create mode 100644 tests/qemuxml2xmloutdata/disk-network-tlsx509-nbd-hostname.x86_64-latest.xml

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano