[libvirt PATCH 0/5] Miscelaneous libc-related fixes

Martin Kletzander posted 5 patches 2 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1646643734.git.mkletzan@redhat.com
build-aux/syntax-check.mk           |  2 +-
scripts/mock-noinline.py            |  2 +-
src/lxc/lxc_driver.c                |  4 ++--
src/network/bridge_driver.c         |  2 +-
src/nwfilter/nwfilter_learnipaddr.c | 15 ++++++++-------
src/openvz/openvz_driver.c          |  2 +-
src/qemu/qemu_driver.c              |  2 +-
src/security/security_apparmor.c    |  2 +-
src/vz/vz_driver.c                  |  2 +-
tests/virmock.h                     |  4 +++-
10 files changed, 20 insertions(+), 17 deletions(-)
[libvirt PATCH 0/5] Miscelaneous libc-related fixes
Posted by Martin Kletzander 2 years, 1 month ago
Compiling libvirt on alpine showed a bunch of things that are
potentially wrong, we just haven't noticed elsewhere.

Martin Kletzander (5):
  syntax-check: Rework mock-noinline to get all files at once
  Include poll.h instead of sys/poll.h
  Include sys/wait.h instead of wait.h
  nwfilter: Avoid memory alignment issues
  tests: Allow expansion of mocked stat symbols

 build-aux/syntax-check.mk           |  2 +-
 scripts/mock-noinline.py            |  2 +-
 src/lxc/lxc_driver.c                |  4 ++--
 src/network/bridge_driver.c         |  2 +-
 src/nwfilter/nwfilter_learnipaddr.c | 15 ++++++++-------
 src/openvz/openvz_driver.c          |  2 +-
 src/qemu/qemu_driver.c              |  2 +-
 src/security/security_apparmor.c    |  2 +-
 src/vz/vz_driver.c                  |  2 +-
 tests/virmock.h                     |  4 +++-
 10 files changed, 20 insertions(+), 17 deletions(-)

-- 
2.35.1

Re: [libvirt PATCH 0/5] Miscelaneous libc-related fixes
Posted by Michal Prívozník 2 years, 1 month ago
On 3/7/22 10:04, Martin Kletzander wrote:
> Compiling libvirt on alpine showed a bunch of things that are
> potentially wrong, we just haven't noticed elsewhere.
> 
> Martin Kletzander (5):
>   syntax-check: Rework mock-noinline to get all files at once
>   Include poll.h instead of sys/poll.h
>   Include sys/wait.h instead of wait.h
>   nwfilter: Avoid memory alignment issues
>   tests: Allow expansion of mocked stat symbols
> 
>  build-aux/syntax-check.mk           |  2 +-
>  scripts/mock-noinline.py            |  2 +-
>  src/lxc/lxc_driver.c                |  4 ++--
>  src/network/bridge_driver.c         |  2 +-
>  src/nwfilter/nwfilter_learnipaddr.c | 15 ++++++++-------
>  src/openvz/openvz_driver.c          |  2 +-
>  src/qemu/qemu_driver.c              |  2 +-
>  src/security/security_apparmor.c    |  2 +-
>  src/vz/vz_driver.c                  |  2 +-
>  tests/virmock.h                     |  4 +++-
>  10 files changed, 20 insertions(+), 17 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Apparently, I don't know how C preprocessor works.

Michal
Re: [libvirt PATCH 0/5] Miscelaneous libc-related fixes
Posted by Ján Tomko 2 years, 1 month ago
On a Monday in 2022, Martin Kletzander wrote:
>Compiling libvirt on alpine showed a bunch of things that are
>potentially wrong, we just haven't noticed elsewhere.
>
>Martin Kletzander (5):
>  syntax-check: Rework mock-noinline to get all files at once
>  Include poll.h instead of sys/poll.h
>  Include sys/wait.h instead of wait.h
>  nwfilter: Avoid memory alignment issues
>  tests: Allow expansion of mocked stat symbols
>
> build-aux/syntax-check.mk           |  2 +-
> scripts/mock-noinline.py            |  2 +-
> src/lxc/lxc_driver.c                |  4 ++--
> src/network/bridge_driver.c         |  2 +-
> src/nwfilter/nwfilter_learnipaddr.c | 15 ++++++++-------
> src/openvz/openvz_driver.c          |  2 +-
> src/qemu/qemu_driver.c              |  2 +-
> src/security/security_apparmor.c    |  2 +-
> src/vz/vz_driver.c                  |  2 +-
> tests/virmock.h                     |  4 +++-
> 10 files changed, 20 insertions(+), 17 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano