[PATCH 00/17] lxc_fuse: Implement support for FUSE3

Michal Privoznik posted 17 patches 2 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1646643526.git.mprivozn@redhat.com
Test syntax-check failed
meson.build          |  12 +-
src/lxc/lxc_cgroup.h |  13 +++
src/lxc/lxc_fuse.c   | 258 ++++++++++++++++++++++++++++++-------------
src/lxc/lxc_fuse.h   |  28 +----
4 files changed, 207 insertions(+), 104 deletions(-)
[PATCH 00/17] lxc_fuse: Implement support for FUSE3
Posted by Michal Privoznik 2 years, 1 month ago
Unfortunately, we can't just replace FUSE with FUSE3 because Ubuntu1804
doesn't have fuse3 package, but in a few weeks time, when the support
for old Ubuntu is dropped, we can drop old FUSE support too.

Michal Prívozník (17):
  lxc_fuse: Hide struct virLXCFuse
  lxc_fuse: Move virLXCMeminfo struct into lxc_cgroup.h
  lxc_fuse.h: Don't include lxc_conf.h
  lxc_fuse: Move #include <fuse.h>
  lxc_fuse: Drop some G_GNUC_UNUSED attributes
  lxc_fuse.c: Modernize function declarations
  lxc_fuse: Prefer O_ACCMODE instead of & 3
  lxcSetupFuse: Cleanup error paths
  lxcProcReadMeminfo: Rename @fd to @fp
  lxc_fuse: Use automatic file closing
  lxcProcReadMeminfo: Drop needless label
  lxcProcReadMeminfo: Drop @new_meminfo variable
  lxcProcReadMeminfo: Fix case when @offset != 0
  lxc_fuse: Prefer fuse_file_info::direct_io over mount option
  lxc_fuse: Tell FUSE that /proc/meminfo is nonseekable
  lxc_fuse: Implement support for FUSE3
  meson: Detect newer fuse

 meson.build          |  12 +-
 src/lxc/lxc_cgroup.h |  13 +++
 src/lxc/lxc_fuse.c   | 258 ++++++++++++++++++++++++++++++-------------
 src/lxc/lxc_fuse.h   |  28 +----
 4 files changed, 207 insertions(+), 104 deletions(-)

-- 
2.34.1

Re: [PATCH 00/17] lxc_fuse: Implement support for FUSE3
Posted by Ján Tomko 2 years, 1 month ago
On a Monday in 2022, Michal Privoznik wrote:
>Unfortunately, we can't just replace FUSE with FUSE3 because Ubuntu1804
>doesn't have fuse3 package, but in a few weeks time, when the support
>for old Ubuntu is dropped, we can drop old FUSE support too.
>
>Michal Prívozník (17):
>  lxc_fuse: Hide struct virLXCFuse
>  lxc_fuse: Move virLXCMeminfo struct into lxc_cgroup.h
>  lxc_fuse.h: Don't include lxc_conf.h
>  lxc_fuse: Move #include <fuse.h>
>  lxc_fuse: Drop some G_GNUC_UNUSED attributes
>  lxc_fuse.c: Modernize function declarations
>  lxc_fuse: Prefer O_ACCMODE instead of & 3
>  lxcSetupFuse: Cleanup error paths
>  lxcProcReadMeminfo: Rename @fd to @fp
>  lxc_fuse: Use automatic file closing
>  lxcProcReadMeminfo: Drop needless label
>  lxcProcReadMeminfo: Drop @new_meminfo variable
>  lxcProcReadMeminfo: Fix case when @offset != 0
>  lxc_fuse: Prefer fuse_file_info::direct_io over mount option
>  lxc_fuse: Tell FUSE that /proc/meminfo is nonseekable
>  lxc_fuse: Implement support for FUSE3
>  meson: Detect newer fuse
>
> meson.build          |  12 +-
> src/lxc/lxc_cgroup.h |  13 +++
> src/lxc/lxc_fuse.c   | 258 ++++++++++++++++++++++++++++++-------------
> src/lxc/lxc_fuse.h   |  28 +----
> 4 files changed, 207 insertions(+), 104 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano