[PATCH 0/4] tests: Miscellaneous fixes and improvements

Michal Privoznik posted 4 patches 2 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1646386097.git.mprivozn@redhat.com
tests/nwfilterxml2firewalldata/ah-ipv6-linux.args |  6 +++---
tests/nwfilterxml2firewalldata/ah-ipv6.xml        |  2 +-
.../nwfilterxml2firewalldata/all-ipv6-linux.args  |  6 +++---
tests/nwfilterxml2firewalldata/all-ipv6.xml       |  2 +-
tests/nwfilterxml2firewalldata/comment-linux.args |  4 ++--
tests/nwfilterxml2firewalldata/comment.xml        |  4 ++--
.../nwfilterxml2firewalldata/esp-ipv6-linux.args  |  6 +++---
tests/nwfilterxml2firewalldata/esp-ipv6.xml       |  2 +-
.../nwfilterxml2firewalldata/hex-data-linux.args  |  4 ++--
tests/nwfilterxml2firewalldata/hex-data.xml       |  4 ++--
tests/nwfilterxml2firewalldata/icmpv6-linux.args  |  2 +-
tests/nwfilterxml2firewalldata/icmpv6.xml         |  2 +-
tests/nwfilterxml2firewalldata/ipv6-linux.args    |  4 ++--
tests/nwfilterxml2firewalldata/ipv6.xml           |  4 ++--
.../nwfilterxml2firewalldata/sctp-ipv6-linux.args |  6 +++---
tests/nwfilterxml2firewalldata/sctp-ipv6.xml      |  2 +-
.../nwfilterxml2firewalldata/tcp-ipv6-linux.args  |  6 +++---
tests/nwfilterxml2firewalldata/tcp-ipv6.xml       |  2 +-
.../nwfilterxml2firewalldata/udp-ipv6-linux.args  |  6 +++---
tests/nwfilterxml2firewalldata/udp-ipv6.xml       |  2 +-
.../udplite-ipv6-linux.args                       |  6 +++---
tests/nwfilterxml2firewalldata/udplite-ipv6.xml   |  2 +-
tests/nwfilterxml2xmlin/ah-ipv6-test-invalid.xml  |  2 +-
tests/nwfilterxml2xmlin/all-ipv6-test-invalid.xml |  2 +-
tests/nwfilterxml2xmlin/comment-test-invalid.xml  |  4 ++--
tests/nwfilterxml2xmlin/esp-ipv6-test-invalid.xml |  2 +-
tests/nwfilterxml2xmlin/hex-data-test-invalid.xml |  4 ++--
tests/nwfilterxml2xmlin/icmpv6-test-invalid.xml   |  2 +-
tests/nwfilterxml2xmlin/ipv6-test-invalid.xml     |  4 ++--
.../nwfilterxml2xmlin/sctp-ipv6-test-invalid.xml  |  2 +-
tests/nwfilterxml2xmlin/tcp-ipv6-test-invalid.xml |  2 +-
tests/nwfilterxml2xmlin/udp-ipv6-test-invalid.xml |  2 +-
.../udplite-ipv6-test-invalid.xml                 |  2 +-
tests/nwfilterxml2xmlout/ah-ipv6-test.xml         |  2 +-
tests/nwfilterxml2xmlout/all-ipv6-test.xml        |  2 +-
tests/nwfilterxml2xmlout/comment-test.xml         |  2 +-
tests/nwfilterxml2xmlout/esp-ipv6-test.xml        |  2 +-
tests/nwfilterxml2xmlout/hex-data-test.xml        |  2 +-
tests/nwfilterxml2xmlout/icmpv6-test.xml          |  2 +-
tests/nwfilterxml2xmlout/ipv6-test.xml            |  2 +-
tests/nwfilterxml2xmlout/sctp-ipv6-test.xml       |  2 +-
tests/nwfilterxml2xmlout/tcp-ipv6-test.xml        |  2 +-
tests/nwfilterxml2xmlout/udp-ipv6-test.xml        |  2 +-
tests/nwfilterxml2xmlout/udplite-ipv6-test.xml    |  2 +-
tests/sockettest.c                                |  2 ++
tests/vircgroupmock.c                             | 15 ++++++---------
46 files changed, 75 insertions(+), 76 deletions(-)
[PATCH 0/4] tests: Miscellaneous fixes and improvements
Posted by Michal Privoznik 2 years, 1 month ago
I've been trying to compile libvirt with musl lately and seen couple of
tests failing. Some of them were related strictly to how musl works, but
the rest are genuine bugs we have and it's by pure chance that we
haven't met them with glibc (1/4 for instance).

Green pipeline can be seen here:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/483864407

Michal Prívozník (4):
  vircgroupmock: Be wiser about detecting fakerootdir change
  vircgroupmock: Make global variables static
  sockettest: Check for IPv4-in-IPv6 parsing and formatting
  tests: Update IPv4-in-IPv6 addresses

 tests/nwfilterxml2firewalldata/ah-ipv6-linux.args |  6 +++---
 tests/nwfilterxml2firewalldata/ah-ipv6.xml        |  2 +-
 .../nwfilterxml2firewalldata/all-ipv6-linux.args  |  6 +++---
 tests/nwfilterxml2firewalldata/all-ipv6.xml       |  2 +-
 tests/nwfilterxml2firewalldata/comment-linux.args |  4 ++--
 tests/nwfilterxml2firewalldata/comment.xml        |  4 ++--
 .../nwfilterxml2firewalldata/esp-ipv6-linux.args  |  6 +++---
 tests/nwfilterxml2firewalldata/esp-ipv6.xml       |  2 +-
 .../nwfilterxml2firewalldata/hex-data-linux.args  |  4 ++--
 tests/nwfilterxml2firewalldata/hex-data.xml       |  4 ++--
 tests/nwfilterxml2firewalldata/icmpv6-linux.args  |  2 +-
 tests/nwfilterxml2firewalldata/icmpv6.xml         |  2 +-
 tests/nwfilterxml2firewalldata/ipv6-linux.args    |  4 ++--
 tests/nwfilterxml2firewalldata/ipv6.xml           |  4 ++--
 .../nwfilterxml2firewalldata/sctp-ipv6-linux.args |  6 +++---
 tests/nwfilterxml2firewalldata/sctp-ipv6.xml      |  2 +-
 .../nwfilterxml2firewalldata/tcp-ipv6-linux.args  |  6 +++---
 tests/nwfilterxml2firewalldata/tcp-ipv6.xml       |  2 +-
 .../nwfilterxml2firewalldata/udp-ipv6-linux.args  |  6 +++---
 tests/nwfilterxml2firewalldata/udp-ipv6.xml       |  2 +-
 .../udplite-ipv6-linux.args                       |  6 +++---
 tests/nwfilterxml2firewalldata/udplite-ipv6.xml   |  2 +-
 tests/nwfilterxml2xmlin/ah-ipv6-test-invalid.xml  |  2 +-
 tests/nwfilterxml2xmlin/all-ipv6-test-invalid.xml |  2 +-
 tests/nwfilterxml2xmlin/comment-test-invalid.xml  |  4 ++--
 tests/nwfilterxml2xmlin/esp-ipv6-test-invalid.xml |  2 +-
 tests/nwfilterxml2xmlin/hex-data-test-invalid.xml |  4 ++--
 tests/nwfilterxml2xmlin/icmpv6-test-invalid.xml   |  2 +-
 tests/nwfilterxml2xmlin/ipv6-test-invalid.xml     |  4 ++--
 .../nwfilterxml2xmlin/sctp-ipv6-test-invalid.xml  |  2 +-
 tests/nwfilterxml2xmlin/tcp-ipv6-test-invalid.xml |  2 +-
 tests/nwfilterxml2xmlin/udp-ipv6-test-invalid.xml |  2 +-
 .../udplite-ipv6-test-invalid.xml                 |  2 +-
 tests/nwfilterxml2xmlout/ah-ipv6-test.xml         |  2 +-
 tests/nwfilterxml2xmlout/all-ipv6-test.xml        |  2 +-
 tests/nwfilterxml2xmlout/comment-test.xml         |  2 +-
 tests/nwfilterxml2xmlout/esp-ipv6-test.xml        |  2 +-
 tests/nwfilterxml2xmlout/hex-data-test.xml        |  2 +-
 tests/nwfilterxml2xmlout/icmpv6-test.xml          |  2 +-
 tests/nwfilterxml2xmlout/ipv6-test.xml            |  2 +-
 tests/nwfilterxml2xmlout/sctp-ipv6-test.xml       |  2 +-
 tests/nwfilterxml2xmlout/tcp-ipv6-test.xml        |  2 +-
 tests/nwfilterxml2xmlout/udp-ipv6-test.xml        |  2 +-
 tests/nwfilterxml2xmlout/udplite-ipv6-test.xml    |  2 +-
 tests/sockettest.c                                |  2 ++
 tests/vircgroupmock.c                             | 15 ++++++---------
 46 files changed, 75 insertions(+), 76 deletions(-)

-- 
2.34.1

Re: [PATCH 0/4] tests: Miscellaneous fixes and improvements
Posted by Ján Tomko 2 years, 1 month ago
On a Friday in 2022, Michal Privoznik wrote:
>I've been trying to compile libvirt with musl lately and seen couple of
>tests failing. Some of them were related strictly to how musl works, but
>the rest are genuine bugs we have and it's by pure chance that we
>haven't met them with glibc (1/4 for instance).
>
>Green pipeline can be seen here:
>
>https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/483864407
>

See https://gitlab.com/libvirt/libvirt/-/blob/master/ci/README.rst
on how to get FreeBSD and macOS coverage.

>Michal Prívozník (4):
>  vircgroupmock: Be wiser about detecting fakerootdir change
>  vircgroupmock: Make global variables static
>  sockettest: Check for IPv4-in-IPv6 parsing and formatting
>  tests: Update IPv4-in-IPv6 addresses
>
> tests/nwfilterxml2firewalldata/ah-ipv6-linux.args |  6 +++---
> tests/nwfilterxml2firewalldata/ah-ipv6.xml        |  2 +-
> .../nwfilterxml2firewalldata/all-ipv6-linux.args  |  6 +++---

[...]

> tests/sockettest.c                                |  2 ++
> tests/vircgroupmock.c                             | 15 ++++++---------
> 46 files changed, 75 insertions(+), 76 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano