[PATCH 0/6] qemu: Clean up monitor structs and assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE in the hotplug test

Peter Krempa posted 6 patches 2 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1644854180.git.pkrempa@redhat.com
build-aux/syntax-check.mk      |  6 +--
src/locking/lock_daemon.c      |  4 +-
src/logging/log_daemon.c       |  4 +-
src/lxc/lxc_controller.c       |  2 +-
src/qemu/qemu_monitor.c        | 54 +-----------------------
src/qemu/qemu_monitor.h        | 19 ---------
src/qemu/qemu_monitor_json.c   |  3 ++
src/qemu/qemu_monitor_priv.h   | 77 ++++++++++++++++++++++++++++++++++
src/remote/remote_ssh_helper.c |  2 +-
src/rpc/virnetsocket.c         |  4 +-
src/util/vircommand.c          |  4 +-
src/util/virfdstream.c         |  2 +-
src/util/virfile.c             | 10 ++---
tests/qemucapsprobemock.c      |  3 ++
tests/qemuhotplugmock.c        | 14 +++++++
tests/qemuhotplugtest.c        |  3 ++
tests/shunloadtest.c           |  2 +-
tests/vircgroupmock.c          |  2 +-
tests/virnettlssessiontest.c   |  2 +-
tools/virsh-console.c          |  2 +-
20 files changed, 124 insertions(+), 95 deletions(-)
[PATCH 0/6] qemu: Clean up monitor structs and assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE in the hotplug test
Posted by Peter Krempa 2 years, 2 months ago
qemu-2.11 is the last one which couldn't do FD passing of unix listening
sockets. Since it's approaching time to remove the support for such old
version we need to make sure that some tests don't break.

Peter Krempa (6):
  qemu: monitor: Drop old monitor fields from 'struct
    _qemuMonitorMessage'
  qemu: Privatize 'struct _qemuMonitorMessage'
  qemu: monitor: Move declaration of struct _qemuMonitor to
    qemu_monitor_priv.h
  syntax-check: sc_avoid_write: Don't use blanket file exceptions
  qemuhotplugmock: Mock fd passing to qemu via 'SCM_RIGHTS'
  qemuhotplugtest: Assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE

 build-aux/syntax-check.mk      |  6 +--
 src/locking/lock_daemon.c      |  4 +-
 src/logging/log_daemon.c       |  4 +-
 src/lxc/lxc_controller.c       |  2 +-
 src/qemu/qemu_monitor.c        | 54 +-----------------------
 src/qemu/qemu_monitor.h        | 19 ---------
 src/qemu/qemu_monitor_json.c   |  3 ++
 src/qemu/qemu_monitor_priv.h   | 77 ++++++++++++++++++++++++++++++++++
 src/remote/remote_ssh_helper.c |  2 +-
 src/rpc/virnetsocket.c         |  4 +-
 src/util/vircommand.c          |  4 +-
 src/util/virfdstream.c         |  2 +-
 src/util/virfile.c             | 10 ++---
 tests/qemucapsprobemock.c      |  3 ++
 tests/qemuhotplugmock.c        | 14 +++++++
 tests/qemuhotplugtest.c        |  3 ++
 tests/shunloadtest.c           |  2 +-
 tests/vircgroupmock.c          |  2 +-
 tests/virnettlssessiontest.c   |  2 +-
 tools/virsh-console.c          |  2 +-
 20 files changed, 124 insertions(+), 95 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] qemu: Clean up monitor structs and assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE in the hotplug test
Posted by Ján Tomko 2 years, 2 months ago
On a Monday in 2022, Peter Krempa wrote:
>qemu-2.11 is the last one which couldn't do FD passing of unix listening
>sockets. Since it's approaching time to remove the support for such old
>version we need to make sure that some tests don't break.
>
>Peter Krempa (6):
>  qemu: monitor: Drop old monitor fields from 'struct
>    _qemuMonitorMessage'
>  qemu: Privatize 'struct _qemuMonitorMessage'
>  qemu: monitor: Move declaration of struct _qemuMonitor to
>    qemu_monitor_priv.h
>  syntax-check: sc_avoid_write: Don't use blanket file exceptions
>  qemuhotplugmock: Mock fd passing to qemu via 'SCM_RIGHTS'
>  qemuhotplugtest: Assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE
>
> build-aux/syntax-check.mk      |  6 +--
> src/locking/lock_daemon.c      |  4 +-
> src/logging/log_daemon.c       |  4 +-
> src/lxc/lxc_controller.c       |  2 +-
> src/qemu/qemu_monitor.c        | 54 +-----------------------
> src/qemu/qemu_monitor.h        | 19 ---------
> src/qemu/qemu_monitor_json.c   |  3 ++
> src/qemu/qemu_monitor_priv.h   | 77 ++++++++++++++++++++++++++++++++++
> src/remote/remote_ssh_helper.c |  2 +-
> src/rpc/virnetsocket.c         |  4 +-
> src/util/vircommand.c          |  4 +-
> src/util/virfdstream.c         |  2 +-
> src/util/virfile.c             | 10 ++---
> tests/qemucapsprobemock.c      |  3 ++
> tests/qemuhotplugmock.c        | 14 +++++++
> tests/qemuhotplugtest.c        |  3 ++
> tests/shunloadtest.c           |  2 +-
> tests/vircgroupmock.c          |  2 +-
> tests/virnettlssessiontest.c   |  2 +-
> tools/virsh-console.c          |  2 +-
> 20 files changed, 124 insertions(+), 95 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano