qemu: domain: Move and rename qemuDomainStorageIdNew/Reset

[PATCH 0/2] qemu: domain: Move and rename qemuDomainStorageIdNew/Reset

Peter Krempa posted 2 patches 2 years, 2 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1644832707.git.pkrempa@redhat.com

src/qemu/qemu_domain.c | 62 +++++++++++++++++++++---------------------
src/qemu/qemu_domain.h |  3 --
2 files changed, 31 insertions(+), 34 deletions(-)

Expand all Fold all

[PATCH 0/2] qemu: domain: Move and rename qemuDomainStorageIdNew/Reset

Posted by Peter Krempa 2 years, 2 months ago

In a review adding similar APIs I was asked to use 'ID' instead of 'Id'.

Rename the existing helpers.

Patch 1 is a second version as 'qemuDomainStorageIdNew' can be
unexported too.

Peter Krempa (2):
  qemu: domain: Move and unexport 'qemuDomainStorageIdNew/Reset'
  qemu: domain: Change 'Id' to 'ID' in qemuDomainStorageIdNew/Reset

 src/qemu/qemu_domain.c | 62 +++++++++++++++++++++---------------------
 src/qemu/qemu_domain.h |  3 --
 2 files changed, 31 insertions(+), 34 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] qemu: domain: Move and rename qemuDomainStorageIdNew/Reset

Posted by Ján Tomko 2 years, 2 months ago

On a Monday in 2022, Peter Krempa wrote:
>In a review adding similar APIs I was asked to use 'ID' instead of 'Id'.
>
>Rename the existing helpers.
>
>Patch 1 is a second version as 'qemuDomainStorageIdNew' can be
>unexported too.
>
>Peter Krempa (2):
>  qemu: domain: Move and unexport 'qemuDomainStorageIdNew/Reset'
>  qemu: domain: Change 'Id' to 'ID' in qemuDomainStorageIdNew/Reset
>
> src/qemu/qemu_domain.c | 62 +++++++++++++++++++++---------------------
> src/qemu/qemu_domain.h |  3 --
> 2 files changed, 31 insertions(+), 34 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano