ch_driver: Misc cleanups

[PATCH 0/6] ch_driver: Misc cleanups

Michal Privoznik posted 6 patches 2 years, 2 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1644507592.git.mprivozn@redhat.com

src/ch/ch_domain.c  |  9 +++++++++
src/ch/ch_domain.h  |  4 ++++
src/ch/ch_driver.c  | 32 +++++++++++---------------------
src/ch/ch_process.c |  6 ++++++
4 files changed, 30 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/6] ch_driver: Misc cleanups

Posted by Michal Privoznik 2 years, 2 months ago

While reviewing Tim's patches [1] I've found couple of places in CH
driver that are downright bugs. Fix them.

1: https://listman.redhat.com/archives/libvir-list/2022-February/msg00226.html

Michal Prívozník (6):
  ch_driver: Don't lock driver when getting version
  ch_driver: Don't lock driver when looking up domains
  chDomainCreateXML: Drop spurious driver unlock
  ch_driver: End job properly on failed chDomainCreateXML()
  ch_driver: Introduce and use virCHDomainRemoveInactive()
  ch_process: Check whether domain is already running before starting it

 src/ch/ch_domain.c  |  9 +++++++++
 src/ch/ch_domain.h  |  4 ++++
 src/ch/ch_driver.c  | 32 +++++++++++---------------------
 src/ch/ch_process.c |  6 ++++++
 4 files changed, 30 insertions(+), 21 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] ch_driver: Misc cleanups

Posted by Tim Wiederhake 2 years, 2 months ago

On Thu, 2022-02-10 at 16:51 +0100, Michal Privoznik wrote:
> While reviewing Tim's patches [1] I've found couple of places in CH
> driver that are downright bugs. Fix them.
> 
> 1:
> https://listman.redhat.com/archives/libvir-list/2022-February/msg00226.html
> 
> Michal Prívozník (6):
>   ch_driver: Don't lock driver when getting version
>   ch_driver: Don't lock driver when looking up domains
>   chDomainCreateXML: Drop spurious driver unlock
>   ch_driver: End job properly on failed chDomainCreateXML()
>   ch_driver: Introduce and use virCHDomainRemoveInactive()
>   ch_process: Check whether domain is already running before starting
> it
> 
>  src/ch/ch_domain.c  |  9 +++++++++
>  src/ch/ch_domain.h  |  4 ++++
>  src/ch/ch_driver.c  | 32 +++++++++++---------------------
>  src/ch/ch_process.c |  6 ++++++
>  4 files changed, 30 insertions(+), 21 deletions(-)
> 
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>