v5 of:

https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html

diff to v4:
- Switched to virCommandSetDryRun() in commit 10/13, because using a
  separate script was conflicting with ASAN. Tried to debug, failed
  miserably.
- Extended error message from patch 11/13 to include
  virGetLastErrorMessage() (because if a test fails one simply doesn't
  access libvirt log in the CI).

Michal Prívozník (13):
  virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
  lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
  virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal()
  virdnsmasq: Drop mtime member from struct _dnsmasqCaps
  virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps
  virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
  virdnsmasq: Don't run 'dnsmasq --help'
  virdnsmasq: Lookup DNSMASQ in PATH
  virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
  networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
  networkxml2conftest: Check if capabilities were created successfully
  virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
  virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()

 meson.build                 |  1 -
 src/libvirt_private.syms    |  1 -
 src/util/virdnsmasq.c       | 84 ++++++-------------------------------
 src/util/virdnsmasq.h       |  1 -
 tests/meson.build           |  1 +
 tests/networkxml2conftest.c | 47 ++++++++++++++++++---
 tests/virdnsmasqmock.c      | 19 +++++++++
 7 files changed, 75 insertions(+), 79 deletions(-)
 create mode 100644 tests/virdnsmasqmock.c

-- 
2.34.1

On Tue, Jan 18, 2022 at 03:37:07PM +0100, Michal Privoznik wrote:
> v5 of:
>
> https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html
>
> diff to v4:
> - Switched to virCommandSetDryRun() in commit 10/13, because using a
>   separate script was conflicting with ASAN. Tried to debug, failed
>   miserably.
> - Extended error message from patch 11/13 to include
>   virGetLastErrorMessage() (because if a test fails one simply doesn't
>   access libvirt log in the CI).
>
> Michal Prívozník (13):
>   virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
>   lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
>   virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal()
>   virdnsmasq: Drop mtime member from struct _dnsmasqCaps
>   virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps
>   virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
>   virdnsmasq: Don't run 'dnsmasq --help'
>   virdnsmasq: Lookup DNSMASQ in PATH
>   virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
>   networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
>   networkxml2conftest: Check if capabilities were created successfully
>   virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
>   virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization