On 1/11/22 10:53, Peter Krempa wrote:
> After a recent unreleased refactor we don't remove the temporary
> snapshot object from the list when finishing a snapshot without metadata
> thus we should fix it before releasing a buggy release.
>
> This patchset fixes it by not adding it into the list in the first
> place.
>
> Peter Krempa (3):
> virdomainmomentobjlist.h: Convert to modern header style
> conf: moment: Export helpers to create the virDomainMoment wrapper
> qemuSnapshotCreate: Don't insert snapshot into list with
> VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA
>
> src/conf/virdomainmomentobjlist.c | 4 +-
> src/conf/virdomainmomentobjlist.h | 121 +++++++++++++++++++-----------
> src/libvirt_private.syms | 2 +
> src/qemu/qemu_snapshot.c | 25 +++---
> 4 files changed, 97 insertions(+), 55 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal