virsh: domain: small refactoring

[PATCH v2 0/7] virsh: domain: small refactoring

Kristina Hanicova posted 7 patches 2 years, 7 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1632495763.git.khanicov@redhat.com

tools/virsh-domain.c | 232 +++++++++++++++++--------------------------
1 file changed, 92 insertions(+), 140 deletions(-)

Expand all Fold all

[PATCH v2 0/7] virsh: domain: small refactoring

Posted by Kristina Hanicova 2 years, 7 months ago

This is partially v2 of:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html

Diff to v1:
* split changes into smaller patches

Kristina Hanicova (7):
  virsh: domain: use early return in virshDomainDefine()
  virsh: domain: remove nested 'if' in cmdAttachDisk()
  virsh: domain: remove 'ret' variable and use direct return when
    possible
  virsh: domain: remove 'ret' variable, use early return when possible
  virsh: domain: use early return when possible
  virsh: domain: remove 'ret' variable and use 'count' instead
  virsh: domain: remove else branch

 tools/virsh-domain.c | 232 +++++++++++++++++--------------------------
 1 file changed, 92 insertions(+), 140 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/7] virsh: domain: small refactoring

Posted by Michal Prívozník 2 years, 7 months ago

On 9/24/21 5:17 PM, Kristina Hanicova wrote:
> This is partially v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html
> 
> Diff to v1:
> * split changes into smaller patches
> 
> Kristina Hanicova (7):
>   virsh: domain: use early return in virshDomainDefine()
>   virsh: domain: remove nested 'if' in cmdAttachDisk()
>   virsh: domain: remove 'ret' variable and use direct return when
>     possible
>   virsh: domain: remove 'ret' variable, use early return when possible
>   virsh: domain: use early return when possible
>   virsh: domain: remove 'ret' variable and use 'count' instead
>   virsh: domain: remove else branch
> 
>  tools/virsh-domain.c | 232 +++++++++++++++++--------------------------
>  1 file changed, 92 insertions(+), 140 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal