There are a few more capabilities we can easily assume and stop trying
to probe them and some more legacy code to delete.

This time it's mainly about VNC including a modernization of
qemuxml2argvtest cases for it.

Peter Krempa (14):
  qemuxml2argvtest: Use real caps in "graphics-vnc-tls" case
  qemu: Always assume presence of QEMU_CAPS_OBJECT_TLS_CREDS_X509
  qemu: capabilities: Retire QEMU_CAPS_OBJECT_TLS_CREDS_X509
  qemuBuildTLSx509BackendProps: Remove unused 'qemuCaps'
  qemu: command: Simplify 'vnc' commandline generator
  qemu: command: Always assume QEMU_CAPS_VNC_OPTS
  qemu: capabilities: Retire QEMU_CAPS_VNC_OPTS
  qemuxml2argvtest: Replace vnc unix socket tests with pinned versions
  qemu: command: Always QEMU_CAPS_VNC_MULTI_SERVERS
  qemu: capabilities: Retire QEMU_CAPS_VNC_MULTI_SERVERS
  qemuxml2argvtest: Add DO_TEST_CAPS_LATEST for the vnc unix socket
    tests
  qemuxml2argvtest: Modernize the rest of 'graphics-vnc' tests
  qemu: validate: Always assume QEMU_CAPS_SPICE_FILE_XFER_DISABLE
  qemu: capabilities: Retire QEMU_CAPS_SPICE_FILE_XFER_DISABLE

 src/qemu/qemu_backup.c                        |   5 +-
 src/qemu/qemu_capabilities.c                  |  12 +-
 src/qemu/qemu_capabilities.h                  |   8 +-
 src/qemu/qemu_command.c                       | 108 ++++++------------
 src/qemu/qemu_command.h                       |  10 +-
 src/qemu/qemu_domain.c                        |   4 -
 src/qemu/qemu_driver.c                        |  15 +--
 src/qemu/qemu_hotplug.c                       |  13 +--
 src/qemu/qemu_hotplug.h                       |   3 +-
 src/qemu/qemu_migration_params.c              |   2 +-
 src/qemu/qemu_snapshot.c                      |   3 +-
 src/qemu/qemu_validate.c                      |  20 ----
 .../caps_2.11.0.s390x.xml                     |   3 -
 .../caps_2.11.0.x86_64.xml                    |   4 -
 .../caps_2.12.0.aarch64.xml                   |   3 -
 .../caps_2.12.0.ppc64.xml                     |   3 -
 .../caps_2.12.0.s390x.xml                     |   3 -
 .../caps_2.12.0.x86_64.xml                    |   4 -
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |   3 -
 .../caps_3.0.0.riscv32.xml                    |   3 -
 .../caps_3.0.0.riscv64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |   3 -
 .../caps_3.0.0.x86_64.xml                     |   4 -
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |   3 -
 .../caps_3.1.0.x86_64.xml                     |   4 -
 .../caps_4.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |   3 -
 .../caps_4.0.0.riscv32.xml                    |   4 -
 .../caps_4.0.0.riscv64.xml                    |   4 -
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |   3 -
 .../caps_4.0.0.x86_64.xml                     |   4 -
 .../caps_4.1.0.x86_64.xml                     |   4 -
 .../caps_4.2.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |   3 -
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |   3 -
 .../caps_4.2.0.x86_64.xml                     |   4 -
 .../caps_5.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |   3 -
 .../caps_5.0.0.riscv64.xml                    |   4 -
 .../caps_5.0.0.x86_64.xml                     |   4 -
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |   4 -
 .../caps_5.1.0.x86_64.xml                     |   4 -
 .../caps_5.2.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |   3 -
 .../caps_5.2.0.riscv64.xml                    |   4 -
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |   3 -
 .../caps_5.2.0.x86_64.xml                     |   4 -
 .../caps_6.0.0.aarch64.xml                    |   3 -
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |   3 -
 .../caps_6.0.0.x86_64.xml                     |   4 -
 .../caps_6.1.0.x86_64.xml                     |   4 -
 tests/qemuhotplugtest.c                       |   1 -
 ...cs-vnc-auto-socket-cfg.x86_64-2.11.0.args} |   7 +-
 ...ics-vnc-auto-socket-cfg.x86_64-latest.args |  36 ++++++
 ...raphics-vnc-auto-socket.x86_64-2.11.0.args |  31 +++++
 ...raphics-vnc-auto-socket.x86_64-latest.args |  33 ++++++
 ...phics-vnc-egl-headless.x86_64-2.11.0.args} |   5 +-
 ...aphics-vnc-egl-headless.x86_64-latest.args |  37 ++++++
 ...ics-vnc-no-listen-attr.x86_64-2.11.0.args} |   5 +-
 ...hics-vnc-no-listen-attr.x86_64-latest.args |  36 ++++++
 ...s => graphics-vnc-none.x86_64-2.11.0.args} |   5 +-
 .../graphics-vnc-none.x86_64-latest.args      |  33 ++++++
 ...=> graphics-vnc-policy.x86_64-2.11.0.args} |   5 +-
 .../graphics-vnc-policy.x86_64-latest.args    |  36 ++++++
 ...emove-generated-socket.x86_64-2.11.0.args} |   5 +-
 ...remove-generated-socket.x86_64-latest.args |  36 ++++++
 ...s => graphics-vnc-sasl.x86_64-2.11.0.args} |   7 +-
 .../graphics-vnc-sasl.x86_64-latest.args      |  37 ++++++
 ...vnc-socket-new-cmdline.x86_64-2.11.0.args} |   5 +-
 ...-vnc-socket-new-cmdline.x86_64-latest.args |  33 ++++++
 .../qemuxml2argvdata/graphics-vnc-socket.args |  30 -----
 ...=> graphics-vnc-socket.x86_64-2.11.0.args} |   7 +-
 .../graphics-vnc-socket.x86_64-latest.args    |  33 ++++++
 ...gs => graphics-vnc-tls.x86_64-2.11.0.args} |   8 +-
 ...graphics-vnc-websocket.x86_64-2.11.0.args} |   5 +-
 .../graphics-vnc-websocket.x86_64-latest.args |  33 ++++++
 ...r.args => graphics-vnc.x86_64-2.11.0.args} |   5 +-
 .../graphics-vnc.x86_64-latest.args           |  36 ++++++
 tests/qemuxml2argvdata/name-escape.args       |   2 +-
 tests/qemuxml2argvtest.c                      |  71 ++++++------
 tests/qemuxml2xmltest.c                       |   4 +-
 81 files changed, 586 insertions(+), 378 deletions(-)
 rename tests/qemuxml2argvdata/{graphics-vnc-auto-socket-cfg.args => graphics-vnc-auto-socket-cfg.x86_64-2.11.0.args} (79%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket-cfg.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket.x86_64-2.11.0.args
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-egl-headless.args => graphics-vnc-egl-headless.x86_64-2.11.0.args} (84%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc.args => graphics-vnc-no-listen-attr.x86_64-2.11.0.args} (83%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-no-listen-attr.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-none.args => graphics-vnc-none.x86_64-2.11.0.args} (81%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-none.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-policy.args => graphics-vnc-policy.x86_64-2.11.0.args} (84%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-policy.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-remove-generated-socket.args => graphics-vnc-remove-generated-socket.x86_64-2.11.0.args} (83%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-remove-generated-socket.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-sasl.args => graphics-vnc-sasl.x86_64-2.11.0.args} (82%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-sasl.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-socket-new-cmdline.args => graphics-vnc-socket-new-cmdline.x86_64-2.11.0.args} (81%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket-new-cmdline.x86_64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket.args
 rename tests/qemuxml2argvdata/{graphics-vnc-auto-socket.args => graphics-vnc-socket.x86_64-2.11.0.args} (78%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-tls.args => graphics-vnc-tls.x86_64-2.11.0.args} (71%)
 rename tests/qemuxml2argvdata/{graphics-vnc-websocket.args => graphics-vnc-websocket.x86_64-2.11.0.args} (81%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc-websocket.x86_64-latest.args
 rename tests/qemuxml2argvdata/{graphics-vnc-no-listen-attr.args => graphics-vnc.x86_64-2.11.0.args} (83%)
 create mode 100644 tests/qemuxml2argvdata/graphics-vnc.x86_64-latest.args

-- 
2.31.1

On a Thursday in 2021, Peter Krempa wrote:
>There are a few more capabilities we can easily assume and stop trying
>to probe them and some more legacy code to delete.
>
>This time it's mainly about VNC including a modernization of
>qemuxml2argvtest cases for it.
>
>Peter Krempa (14):
>  qemuxml2argvtest: Use real caps in "graphics-vnc-tls" case
>  qemu: Always assume presence of QEMU_CAPS_OBJECT_TLS_CREDS_X509
>  qemu: capabilities: Retire QEMU_CAPS_OBJECT_TLS_CREDS_X509
>  qemuBuildTLSx509BackendProps: Remove unused 'qemuCaps'
>  qemu: command: Simplify 'vnc' commandline generator
>  qemu: command: Always assume QEMU_CAPS_VNC_OPTS
>  qemu: capabilities: Retire QEMU_CAPS_VNC_OPTS
>  qemuxml2argvtest: Replace vnc unix socket tests with pinned versions
>  qemu: command: Always QEMU_CAPS_VNC_MULTI_SERVERS
>  qemu: capabilities: Retire QEMU_CAPS_VNC_MULTI_SERVERS
>  qemuxml2argvtest: Add DO_TEST_CAPS_LATEST for the vnc unix socket
>    tests
>  qemuxml2argvtest: Modernize the rest of 'graphics-vnc' tests
>  qemu: validate: Always assume QEMU_CAPS_SPICE_FILE_XFER_DISABLE
>  qemu: capabilities: Retire QEMU_CAPS_SPICE_FILE_XFER_DISABLE
>
> src/qemu/qemu_backup.c                        |   5 +-
> src/qemu/qemu_capabilities.c                  |  12 +-
> src/qemu/qemu_capabilities.h                  |   8 +-
[...]
> tests/qemuxml2argvtest.c                      |  71 ++++++------
> tests/qemuxml2xmltest.c                       |   4 +-
> 81 files changed, 586 insertions(+), 378 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano