tests: Return EXIT_* from main instead of 0/-1

[PATCH 0/3] tests: Return EXIT_* from main instead of 0/-1

Michal Privoznik posted 3 patches 2 years, 11 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1621234104.git.mprivozn@redhat.com

tests/fchosttest.c          |  2 +-
tests/qemusecuritytest.c    |  2 +-
tests/scsihosttest.c        |  2 +-
tests/seclabeltest.c        |  2 +-
tests/storagepoolcapstest.c |  2 +-
tests/testutils.c           | 20 +++++++++++++++-----
tests/testutils.h           |  4 ++++
tests/virbitmaptest.c       |  2 +-
tests/vircaps2xmltest.c     |  2 +-
tests/vircapstest.c         |  2 +-
tests/virconftest.c         |  2 +-
tests/virendiantest.c       |  2 +-
tests/virlogtest.c          |  2 +-
tests/virresctrltest.c      |  2 +-
tests/virscsitest.c         |  2 +-
15 files changed, 32 insertions(+), 18 deletions(-)

Expand all Fold all

[PATCH 0/3] tests: Return EXIT_* from main instead of 0/-1

Posted by Michal Privoznik 2 years, 11 months ago

See 3/3 for rationale.

Michal Prívozník (3):
  testutils: Drop libtool binary name handling
  tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
  testutils: Document and enforce @func callback retvals for
    virTestMain()

 tests/fchosttest.c          |  2 +-
 tests/qemusecuritytest.c    |  2 +-
 tests/scsihosttest.c        |  2 +-
 tests/seclabeltest.c        |  2 +-
 tests/storagepoolcapstest.c |  2 +-
 tests/testutils.c           | 20 +++++++++++++++-----
 tests/testutils.h           |  4 ++++
 tests/virbitmaptest.c       |  2 +-
 tests/vircaps2xmltest.c     |  2 +-
 tests/vircapstest.c         |  2 +-
 tests/virconftest.c         |  2 +-
 tests/virendiantest.c       |  2 +-
 tests/virlogtest.c          |  2 +-
 tests/virresctrltest.c      |  2 +-
 tests/virscsitest.c         |  2 +-
 15 files changed, 32 insertions(+), 18 deletions(-)

-- 
2.26.3

Re: [PATCH 0/3] tests: Return EXIT_* from main instead of 0/-1

Posted by Peter Krempa 2 years, 11 months ago

On Mon, May 17, 2021 at 08:49:07 +0200, Michal Privoznik wrote:
> See 3/3 for rationale.
> 
> Michal Prívozník (3):
>   testutils: Drop libtool binary name handling
>   tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
>   testutils: Document and enforce @func callback retvals for
>     virTestMain()

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

I've actually fixed a few instances before where we were returning -1
which was actually confusing the test suite and printing that the test
got some weird signal.