Couple of virCapabilities cleanups

[PATCH 0/5] Couple of virCapabilities cleanups

Michal Privoznik posted 5 patches 2 years, 12 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1620201674.git.mprivozn@redhat.com

src/conf/capabilities.c        | 75 ++++++++++++++++++----------------
src/conf/capabilities.h        |  6 +--
src/libxl/libxl_capabilities.c |  4 +-
src/test/test_driver.c         |  5 ++-
tests/testutils.c              |  6 +--
5 files changed, 50 insertions(+), 46 deletions(-)

Expand all Fold all

[PATCH 0/5] Couple of virCapabilities cleanups

Posted by Michal Privoznik 2 years, 12 months ago

I'm working on reporting HMAT in virCapabilities and noticed couple of
possible cleanups. I'm sending them upfront.

Michal Prívozník (5):
  virCapabilitiesHostNUMAFormat: Swap order of arguments
  virCapabilitiesHostNUMAInitReal: Free @cpus properly
  virCapabilitiesHostNUMAAddCell: Take double pointer
  virCapabilitiesHostNUMAInitReal: Use g_auto* where possible
  virCapabilitiesHostNUMAInitReal: Bring variables into loop

 src/conf/capabilities.c        | 75 ++++++++++++++++++----------------
 src/conf/capabilities.h        |  6 +--
 src/libxl/libxl_capabilities.c |  4 +-
 src/test/test_driver.c         |  5 ++-
 tests/testutils.c              |  6 +--
 5 files changed, 50 insertions(+), 46 deletions(-)

-- 
2.26.3

Re: [PATCH 0/5] Couple of virCapabilities cleanups

Posted by Ján Tomko 2 years, 11 months ago

On a Wednesday in 2021, Michal Privoznik wrote:
>I'm working on reporting HMAT in virCapabilities and noticed couple of
>possible cleanups. I'm sending them upfront.
>
>Michal Prívozník (5):
>  virCapabilitiesHostNUMAFormat: Swap order of arguments
>  virCapabilitiesHostNUMAInitReal: Free @cpus properly
>  virCapabilitiesHostNUMAAddCell: Take double pointer
>  virCapabilitiesHostNUMAInitReal: Use g_auto* where possible
>  virCapabilitiesHostNUMAInitReal: Bring variables into loop
>
> src/conf/capabilities.c        | 75 ++++++++++++++++++----------------
> src/conf/capabilities.h        |  6 +--
> src/libxl/libxl_capabilities.c |  4 +-
> src/test/test_driver.c         |  5 ++-
> tests/testutils.c              |  6 +--
> 5 files changed, 50 insertions(+), 46 deletions(-)
>

Beautiful.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano