util: xml: Fix two problems with the new virXMLProp* helpers

[PATCH 0/2] util: xml: Fix two problems with the new virXMLProp* helpers

Peter Krempa posted 2 patches 3 years ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1618988328.git.pkrempa@redhat.com

src/conf/cpu_conf.c     |  2 +-
src/conf/domain_conf.c  | 24 ++++++++++++------------
src/conf/network_conf.c |  2 +-
src/util/virxml.c       |  6 +-----
src/util/virxml.h       |  3 +--
5 files changed, 16 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/2] util: xml: Fix two problems with the new virXMLProp* helpers

Posted by Peter Krempa 3 years ago

See individual patches for explanation.

Peter Krempa (2):
  util: xml: Remove VIR_XML_PROP_WRAPNEGATIVE
  util: xml: Fix confusing semantics of VIR_XML_PROP_OPTIONAL flag

 src/conf/cpu_conf.c     |  2 +-
 src/conf/domain_conf.c  | 24 ++++++++++++------------
 src/conf/network_conf.c |  2 +-
 src/util/virxml.c       |  6 +-----
 src/util/virxml.h       |  3 +--
 5 files changed, 16 insertions(+), 21 deletions(-)

-- 
2.30.2

Re: [PATCH 0/2] util: xml: Fix two problems with the new virXMLProp* helpers

Posted by Michal Privoznik 3 years ago

On 4/21/21 8:59 AM, Peter Krempa wrote:
> See individual patches for explanation.
> 
> Peter Krempa (2):
>    util: xml: Remove VIR_XML_PROP_WRAPNEGATIVE
>    util: xml: Fix confusing semantics of VIR_XML_PROP_OPTIONAL flag
> 
>   src/conf/cpu_conf.c     |  2 +-
>   src/conf/domain_conf.c  | 24 ++++++++++++------------
>   src/conf/network_conf.c |  2 +-
>   src/util/virxml.c       |  6 +-----
>   src/util/virxml.h       |  3 +--
>   5 files changed, 16 insertions(+), 21 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal