[libvirt PATCH 0/2] introduce 'restrictive' mode in numatune

Martin Kletzander posted 2 patches 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1618576942.git.mkletzan@redhat.com
There is a newer version of this series
docs/formatdomain.rst                         |  7 +++-
docs/schemas/domaincommon.rng                 |  2 +
include/libvirt/libvirt-domain.h              |  1 +
src/conf/numa_conf.c                          |  9 ++++
src/qemu/qemu_command.c                       |  6 ++-
src/qemu/qemu_process.c                       | 32 +++++++++++++++
src/util/virnuma.c                            |  3 ++
.../numatune-memnode-invalid-mode.err         |  1 +
.../numatune-memnode-invalid-mode.xml         | 33 +++++++++++++++
...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++
.../numatune-memnode-restrictive-mode.xml     | 41 +++++++++++++++++++
tests/qemuxml2argvtest.c                      |  2 +
...memnode-restrictive-mode.x86_64-latest.xml |  1 +
tests/qemuxml2xmltest.c                       |  1 +
14 files changed, 174 insertions(+), 3 deletions(-)
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
create mode 120000 tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-latest.xml
[libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
Posted by Martin Kletzander 3 years ago
Resent patches with some fixes

v5: https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.html

Luyao Zhong (2):
  conf, docs, schema: Add support for 'restrictive' mode in numatune
  qemu: Add support for 'restrictive' mode in numatune

 docs/formatdomain.rst                         |  7 +++-
 docs/schemas/domaincommon.rng                 |  2 +
 include/libvirt/libvirt-domain.h              |  1 +
 src/conf/numa_conf.c                          |  9 ++++
 src/qemu/qemu_command.c                       |  6 ++-
 src/qemu/qemu_process.c                       | 32 +++++++++++++++
 src/util/virnuma.c                            |  3 ++
 .../numatune-memnode-invalid-mode.err         |  1 +
 .../numatune-memnode-invalid-mode.xml         | 33 +++++++++++++++
 ...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++
 .../numatune-memnode-restrictive-mode.xml     | 41 +++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  2 +
 ...memnode-restrictive-mode.x86_64-latest.xml |  1 +
 tests/qemuxml2xmltest.c                       |  1 +
 14 files changed, 174 insertions(+), 3 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
 create mode 120000 tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-latest.xml

-- 
2.31.1


Re: [libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
Posted by Martin Kletzander 3 years ago
Sorry for not putting you in Cc on the original patch, I was too much in
a rush.  If this works and looks OK to you, then let me know.  Thanks.

On Fri, Apr 16, 2021 at 02:42:23PM +0200, Martin Kletzander wrote:
>Resent patches with some fixes
>
>v5: https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.html
>
>Luyao Zhong (2):
>  conf, docs, schema: Add support for 'restrictive' mode in numatune
>  qemu: Add support for 'restrictive' mode in numatune
>
> docs/formatdomain.rst                         |  7 +++-
> docs/schemas/domaincommon.rng                 |  2 +
> include/libvirt/libvirt-domain.h              |  1 +
> src/conf/numa_conf.c                          |  9 ++++
> src/qemu/qemu_command.c                       |  6 ++-
> src/qemu/qemu_process.c                       | 32 +++++++++++++++
> src/util/virnuma.c                            |  3 ++
> .../numatune-memnode-invalid-mode.err         |  1 +
> .../numatune-memnode-invalid-mode.xml         | 33 +++++++++++++++
> ...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++
> .../numatune-memnode-restrictive-mode.xml     | 41 +++++++++++++++++++
> tests/qemuxml2argvtest.c                      |  2 +
> ...memnode-restrictive-mode.x86_64-latest.xml |  1 +
> tests/qemuxml2xmltest.c                       |  1 +
> 14 files changed, 174 insertions(+), 3 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
> create mode 120000 tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-latest.xml
>
>-- 
>2.31.1
>
>
RE: [libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
Posted by Zhong, Luyao 3 years ago
@Jing Qi Thanks for your comments.
@Martin Kletzander Thanks for your help on fixing the issues and refine the comments.
I have no problem on current patches.

>-----Original Message-----
>From: Martin Kletzander <mkletzan@redhat.com>
>Sent: Friday, April 16, 2021 8:48 PM
>To: Zhong, Luyao <luyao.zhong@intel.com>
>Cc: libvir-list@redhat.com; Jing Qi <jinqi@redhat.com>
>Subject: Re: [libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
>
>Sorry for not putting you in Cc on the original patch, I was too much in a rush.  If
>this works and looks OK to you, then let me know.  Thanks.
>
>On Fri, Apr 16, 2021 at 02:42:23PM +0200, Martin Kletzander wrote:
>>Resent patches with some fixes
>>
>>v5:
>>https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.htm
>>l
>>
>>Luyao Zhong (2):
>>  conf, docs, schema: Add support for 'restrictive' mode in numatune
>>  qemu: Add support for 'restrictive' mode in numatune
>>
>> docs/formatdomain.rst                         |  7 +++-
>> docs/schemas/domaincommon.rng                 |  2 +
>> include/libvirt/libvirt-domain.h              |  1 +
>> src/conf/numa_conf.c                          |  9 ++++
>> src/qemu/qemu_command.c                       |  6 ++-
>> src/qemu/qemu_process.c                       | 32 +++++++++++++++
>> src/util/virnuma.c                            |  3 ++
>> .../numatune-memnode-invalid-mode.err         |  1 +
>> .../numatune-memnode-invalid-mode.xml         | 33 +++++++++++++++
>> ...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++
>> .../numatune-memnode-restrictive-mode.xml     | 41 +++++++++++++++++++
>> tests/qemuxml2argvtest.c                      |  2 +
>> ...memnode-restrictive-mode.x86_64-latest.xml |  1 +
>> tests/qemuxml2xmltest.c                       |  1 +
>> 14 files changed, 174 insertions(+), 3 deletions(-) create mode 100644
>> tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err
>> create mode 100644
>> tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml
>> create mode 100644
>> tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest
>> .args create mode 100644
>> tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
>> create mode 120000
>> tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-late
>> st.xml
>>
>>--
>>2.31.1
>>
>>


Re: [libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
Posted by Michal Privoznik 3 years ago
On 4/16/21 2:42 PM, Martin Kletzander wrote:
> Resent patches with some fixes
> 
> v5: https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.html
> 
> Luyao Zhong (2):
>    conf, docs, schema: Add support for 'restrictive' mode in numatune
>    qemu: Add support for 'restrictive' mode in numatune
> 
>   docs/formatdomain.rst                         |  7 +++-
>   docs/schemas/domaincommon.rng                 |  2 +
>   include/libvirt/libvirt-domain.h              |  1 +
>   src/conf/numa_conf.c                          |  9 ++++
>   src/qemu/qemu_command.c                       |  6 ++-
>   src/qemu/qemu_process.c                       | 32 +++++++++++++++
>   src/util/virnuma.c                            |  3 ++
>   .../numatune-memnode-invalid-mode.err         |  1 +
>   .../numatune-memnode-invalid-mode.xml         | 33 +++++++++++++++
>   ...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++
>   .../numatune-memnode-restrictive-mode.xml     | 41 +++++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  2 +
>   ...memnode-restrictive-mode.x86_64-latest.xml |  1 +
>   tests/qemuxml2xmltest.c                       |  1 +
>   14 files changed, 174 insertions(+), 3 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml
>   create mode 120000 tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal