conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

[PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

Peter Krempa posted 2 patches 3 years ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1618573737.git.pkrempa@redhat.com

src/conf/domain_conf.c | 31 +++++++------------------------
src/conf/domain_conf.h |  4 ++--
2 files changed, 9 insertions(+), 26 deletions(-)

Expand all Fold all

[PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

Posted by Peter Krempa 3 years ago

I was testing how virXMLPropEnum works when used on converted types, so
I've converted these.

Peter Krempa (2):
  conf: domain: Convert virDomainDiskDef's 'tray_status' to
    virDomainDiskTray
  conf: domain: Convert virDomainDiskDef's 'startupPolicy' to
    virDomainStartupPolicy

 src/conf/domain_conf.c | 31 +++++++------------------------
 src/conf/domain_conf.h |  4 ++--
 2 files changed, 9 insertions(+), 26 deletions(-)

-- 
2.30.2

Re: [PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

Posted by Tim Wiederhake 3 years ago

On Fri, 2021-04-16 at 13:50 +0200, Peter Krempa wrote:
> I was testing how virXMLPropEnum works when used on converted types,
> so
> I've converted these.
> 
> Peter Krempa (2):
>   conf: domain: Convert virDomainDiskDef's 'tray_status' to
>     virDomainDiskTray
>   conf: domain: Convert virDomainDiskDef's 'startupPolicy' to
>     virDomainStartupPolicy
> 
>  src/conf/domain_conf.c | 31 +++++++------------------------
>  src/conf/domain_conf.h |  4 ++--
>  2 files changed, 9 insertions(+), 26 deletions(-)
> 
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>

Re: [PATCH 0/2] conf: Convert 'tray_status' and 'startupPolicy' of virDomainDiskDef to enums

Posted by Peter Krempa 3 years ago

On Fri, Apr 16, 2021 at 14:22:32 +0200, Tim Wiederhake wrote:
> On Fri, 2021-04-16 at 13:50 +0200, Peter Krempa wrote:
> > I was testing how virXMLPropEnum works when used on converted types,
> > so
> > I've converted these.
> > 
> > Peter Krempa (2):
> >   conf: domain: Convert virDomainDiskDef's 'tray_status' to
> >     virDomainDiskTray
> >   conf: domain: Convert virDomainDiskDef's 'startupPolicy' to
> >     virDomainStartupPolicy

Actually startupPolicy is checked as <= in the original code, so
consider VIR_XML_PROP_NONZERO added in that case.

> >  src/conf/domain_conf.c | 31 +++++++------------------------
> >  src/conf/domain_conf.h |  4 ++--
> >  2 files changed, 9 insertions(+), 26 deletions(-)
> > 
> Reviewed-by: Tim Wiederhake <twiederh@redhat.com>