[libvirt] [PATCHv4 00/15] Switch from yajl to Jansson

Ján Tomko posted 15 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1531924566.git.jtomko@redhat.com
Test syntax-check passed
config-post.h                            |   3 +-
configure.ac                             |   3 +
libvirt.spec.in                          |   4 +-
m4/virt-driver-qemu.m4                   |   9 +-
m4/virt-jansson.m4                       |  32 ++
m4/virt-nss.m4                           |   4 +-
m4/virt-yajl.m4                          |  27 +-
src/Makefile.am                          |   8 +-
src/libvirt_private.syms                 |   1 -
src/qemu/qemu_driver.c                   |   2 +-
src/util/Makefile.inc.am                 |   4 +-
src/util/virjson.c                       | 616 +++++++------------------------
src/util/virjson.h                       |   1 -
tests/Makefile.am                        |  12 +-
tests/cputest.c                          |  16 +-
tests/libxlxml2domconfigtest.c           |   4 +-
tests/qemuagenttest.c                    |   2 +-
tests/qemublocktest.c                    |   6 +
tests/qemucapabilitiestest.c             |   7 +-
tests/qemucaps2xmltest.c                 |   2 +-
tests/qemucommandutiltest.c              |   7 +-
tests/qemuhotplugtest.c                  |   7 +-
tests/qemumigparamsdata/empty.json       |   4 +-
tests/qemumigparamsdata/unsupported.json |   4 +-
tests/qemumigparamstest.c                |   7 +-
tests/qemumonitorjsontest.c              |   7 +-
tests/virjsontest.c                      |   5 +
tests/virmacmaptest.c                    |   5 +
tests/virmacmaptestdata/empty.json       |   4 +-
tests/virmocklibxl.c                     |   4 +-
tests/virnetdaemontest.c                 |   7 +-
tests/virstoragetest.c                   |   4 +-
32 files changed, 274 insertions(+), 554 deletions(-)
create mode 100644 m4/virt-jansson.m4
[libvirt] [PATCHv4 00/15] Switch from yajl to Jansson
Posted by Ján Tomko 5 years, 9 months ago
Per the discussion here:
https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html
Switch from using yajl to Jansson.

v1:
https://www.redhat.com/archives/libvir-list/2018-March/msg01781.html
v2:
https://www.redhat.com/archives/libvir-list/2018-May/msg00695.html
v3:
https://www.redhat.com/archives/libvir-list/2018-May/msg00850.html

v4:
Introduce a separate check for Jansson >= 2.8, which preserves
ordering of object keys. For older platforms (e.g. Debian 8),
skip tests that depend on stable ordering.

All patches except for 12/15 (trivial) and 15/15 (new) were ACK'd
already by either Peter or Andrea.

Tested on Debian 8 with libjansson-dev 2.7.

Also available on my repo:
http://repo.or.cz/libvirt/jtomko.git/ jansson-skip

Ján Tomko (15):
  build: add --with-jansson
  build: undef WITH_JANSSON for SETUID_RPC_CLIENT
  Switch from yajl to Jansson
  FIXUP: fix tests
  FIXUP: Deprecate building --with-yajl
  FIXUP: make nss depend on Jansson instead of yajl
  FIXUP: compile and link with Jansson instead of yajl
  FIXUP: s/WITH_YAJL/WITH_JANSSON/
  FIXUP: libvirt.spec: use jansson instead of yajl
  Remove functions using yajl
  build: remove references to WITH_YAJL for SETUID_RPC_CLIENT
  Remove virJSONValueNewStringLen
  build: switch --with-qemu default from yes to check
  build: require Jansson if QEMU driver is enabled
  m4: Introduce STABLE_ORDERING_JANSSON

 config-post.h                            |   3 +-
 configure.ac                             |   3 +
 libvirt.spec.in                          |   4 +-
 m4/virt-driver-qemu.m4                   |   9 +-
 m4/virt-jansson.m4                       |  32 ++
 m4/virt-nss.m4                           |   4 +-
 m4/virt-yajl.m4                          |  27 +-
 src/Makefile.am                          |   8 +-
 src/libvirt_private.syms                 |   1 -
 src/qemu/qemu_driver.c                   |   2 +-
 src/util/Makefile.inc.am                 |   4 +-
 src/util/virjson.c                       | 616 +++++++------------------------
 src/util/virjson.h                       |   1 -
 tests/Makefile.am                        |  12 +-
 tests/cputest.c                          |  16 +-
 tests/libxlxml2domconfigtest.c           |   4 +-
 tests/qemuagenttest.c                    |   2 +-
 tests/qemublocktest.c                    |   6 +
 tests/qemucapabilitiestest.c             |   7 +-
 tests/qemucaps2xmltest.c                 |   2 +-
 tests/qemucommandutiltest.c              |   7 +-
 tests/qemuhotplugtest.c                  |   7 +-
 tests/qemumigparamsdata/empty.json       |   4 +-
 tests/qemumigparamsdata/unsupported.json |   4 +-
 tests/qemumigparamstest.c                |   7 +-
 tests/qemumonitorjsontest.c              |   7 +-
 tests/virjsontest.c                      |   5 +
 tests/virmacmaptest.c                    |   5 +
 tests/virmacmaptestdata/empty.json       |   4 +-
 tests/virmocklibxl.c                     |   4 +-
 tests/virnetdaemontest.c                 |   7 +-
 tests/virstoragetest.c                   |   4 +-
 32 files changed, 274 insertions(+), 554 deletions(-)
 create mode 100644 m4/virt-jansson.m4

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list