qemu: add comma escaping in qemuBuildSCSIiSCSIHostdevDrvStr

[libvirt] [PATCH 0/2] qemu: add comma escaping in qemuBuildSCSIiSCSIHostdevDrvStr

Anya Harter posted 2 patches 5 years, 10 months ago

Download series mbox

Failed in applying to current master (apply log)

src/qemu/qemu_command.c                 | 19 +++++++++++++------
tests/qemuxml2argvdata/name-escape.args |  6 +++++-
tests/qemuxml2argvdata/name-escape.xml  |  7 +++++++
tests/qemuxml2argvtest.c                |  5 ++++-
4 files changed, 29 insertions(+), 8 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] qemu: add comma escaping in qemuBuildSCSIiSCSIHostdevDrvStr

Posted by Anya Harter 5 years, 10 months ago

In order to use the virQEMUBuildBufferEscapeComma function to escape the
commas, the function first had to be converted to use a buffer.

Added a test case for comma escaping in name-escape.xml.

This should complete the BiteSizedTask entry at
https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values.

Anya Harter (2):
  qemu: use virBuffer in qemuBuildSCSIiSCSIHostdevDrvStr
  qemu: Escape commas for qemuBuildSCSIiSCSIHostdevDrvStr

 src/qemu/qemu_command.c                 | 19 +++++++++++++------
 tests/qemuxml2argvdata/name-escape.args |  6 +++++-
 tests/qemuxml2argvdata/name-escape.xml  |  7 +++++++
 tests/qemuxml2argvtest.c                |  5 ++++-
 4 files changed, 29 insertions(+), 8 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list