On 06/19/2018 06:40 PM, Cole Robinson wrote:
> Most VMs libvirt knows how to launch will have qemu network config like:
>
> -netdev $NETDEV_OPTS,id=netdev1 -device e1000,id=netdev1
>
> However for machine types with built-in platform network devices, we
> currently do:
>
> -net nic,model=e1000,vlan=1 -net $NETDEV_OPTS,vlan=1
>
> However for the platform case, all qemu versions we support can do:
>
> -netdev $NETDEV_OPTS,id=netdev1 -net nic,model=e1000,netdev=netdev1
>
> Which simplifies our code, and is more future proof as qemu has
> deprecated the vlan= option. This series switches to the netdev=
> method, and performs some cleanups in related code.
>
> Thanks,
> Cole
>
> Cole Robinson (6):
> qemu: command: Make qemuBuildNicStr static
> qemu: command: Rename BuildNicStr to BuildLegacyNicStr
> qemu: command: remove unused LegacyNicStr arg 'prefix'
> qemu: command: replace vlan= with netdev= for legacy nic
> qemu: Remove vlan function arguments
> qemu: command: vhost: cleanup error reporting
>
> src/qemu/qemu_command.c | 99 ++++++-------------
> src/qemu/qemu_command.h | 8 --
> src/qemu/qemu_hotplug.c | 3 +-
> .../arm-vexpressa9-basic.args | 4 +-
> 4 files changed, 33 insertions(+), 81 deletions(-)
>
ACK series.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list