qemu: add comma escaping in qemu_command.c

[libvirt] [PATCH 0/4] qemu: add comma escaping in qemu_command.c

Anya Harter posted 4 patches 5 years, 10 months ago

Download series mbox

Failed in applying to current master (apply log)

Test syntax-check failed

src/qemu/qemu_command.c                 | 44 +++++++++++--------------
tests/qemuxml2argvdata/name-escape.args | 14 ++++++--
tests/qemuxml2argvdata/name-escape.xml  | 18 ++++++++++
tests/qemuxml2argvtest.c                | 10 +++++-
4 files changed, 58 insertions(+), 28 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] qemu: add comma escaping in qemu_command.c

Posted by Anya Harter 5 years, 10 months ago

The function virQEMUBuildBufferEscapeComma is used to escape commas in
user provided fields for qemu command line processing in the four
functions listed below.

A corresponding test for each comma escaping instance has been added to
tests/qemuxml2argvdata/name-escape.xml.

This should complete the BiteSizedTask entry at
https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values.

Anya Harter (4):
  qemu: Escape commas for qemuBuildChrChardevStr
  qemu: Escape commas for qemuBuildChrChardevFileStr
  qemu: Escape commas for qemuBuildSmartcardCommandLine
  qemu: Escape commas for qemuBuildGrapicsSPICECommandLine

 src/qemu/qemu_command.c                 | 44 +++++++++++--------------
 tests/qemuxml2argvdata/name-escape.args | 14 ++++++--
 tests/qemuxml2argvdata/name-escape.xml  | 18 ++++++++++
 tests/qemuxml2argvtest.c                | 10 +++++-
 4 files changed, 58 insertions(+), 28 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list