rmv virObjectEventStateQueue wrapper funcs

[libvirt] [PATCH libvirt 0/4] rmv virObjectEventStateQueue wrapper funcs

Anya Harter posted 4 patches 5 years, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1528824678.git.aharter@redhat.com

Test syntax-check passed

src/libxl/libxl_domain.c    | 24 +++-------
src/libxl/libxl_domain.h    |  4 --
src/libxl/libxl_driver.c    | 21 +++------
src/libxl/libxl_migration.c | 18 +++-----
src/qemu/qemu_blockjob.c    |  4 +-
src/qemu/qemu_cgroup.c      |  2 +-
src/qemu/qemu_domain.c      | 11 +----
src/qemu/qemu_domain.h      |  2 -
src/qemu/qemu_driver.c      | 88 +++++++++++++++++--------------------
src/qemu/qemu_hotplug.c     | 26 +++++------
src/qemu/qemu_migration.c   | 24 +++++-----
src/qemu/qemu_process.c     | 54 +++++++++++------------
src/test/test_driver.c      | 80 ++++++++++++++++-----------------
src/uml/uml_driver.c        | 33 ++++----------
14 files changed, 162 insertions(+), 229 deletions(-)

Expand all Fold all

[libvirt] [PATCH libvirt 0/4] rmv virObjectEventStateQueue wrapper funcs

Posted by Anya Harter 5 years, 10 months ago

Currently, there are four wrapper functions which call
virObjectEventStateQueue:
    - testObjectEventQueue
    - libxlDomainEventQueue
    - qemuDomainEventQueue
    - umlDomainEventQueue

This patch series removes these wrappers makes all calls directly to
virObjectEventStateQueue.

Since virObjectEventStateQueue takes care of NULL checking, all NULL
checking by callers has also been removed.

This patch series should complete the BiteSizedTask entry at 
https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_EventStateQueue . 

Anya Harter (4):
  events: remove testObjectEventQueue wrapper func
  events: remove libxlDomainEventQueue wrapper func
  events: remove qemuDomainEventQueue wrapper func
  events: remove umlDomainEventQueue wrapper func

 src/libxl/libxl_domain.c    | 24 +++-------
 src/libxl/libxl_domain.h    |  4 --
 src/libxl/libxl_driver.c    | 21 +++------
 src/libxl/libxl_migration.c | 18 +++-----
 src/qemu/qemu_blockjob.c    |  4 +-
 src/qemu/qemu_cgroup.c      |  2 +-
 src/qemu/qemu_domain.c      | 11 +----
 src/qemu/qemu_domain.h      |  2 -
 src/qemu/qemu_driver.c      | 88 +++++++++++++++++--------------------
 src/qemu/qemu_hotplug.c     | 26 +++++------
 src/qemu/qemu_migration.c   | 24 +++++-----
 src/qemu/qemu_process.c     | 54 +++++++++++------------
 src/test/test_driver.c      | 80 ++++++++++++++++-----------------
 src/uml/uml_driver.c        | 33 ++++----------
 14 files changed, 162 insertions(+), 229 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt 0/4] rmv virObjectEventStateQueue wrapper funcs

Posted by Ján Tomko 5 years, 10 months ago

On Tue, Jun 12, 2018 at 01:32:59PM -0400, Anya Harter wrote:
>Currently, there are four wrapper functions which call
>virObjectEventStateQueue:
>    - testObjectEventQueue
>    - libxlDomainEventQueue
>    - qemuDomainEventQueue
>    - umlDomainEventQueue
>
>This patch series removes these wrappers makes all calls directly to
>virObjectEventStateQueue.
>
>Since virObjectEventStateQueue takes care of NULL checking, all NULL
>checking by callers has also been removed.
>
>This patch series should complete the BiteSizedTask entry at
>https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_EventStateQueue .
>
>Anya Harter (4):
>  events: remove testObjectEventQueue wrapper func
>  events: remove libxlDomainEventQueue wrapper func
>  events: remove qemuDomainEventQueue wrapper func
>  events: remove umlDomainEventQueue wrapper func
>

Series:
Reviewed-by: Ján Tomko <jtomko@redhat.com>

and pushed

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list