As mentioned in discussion to my PRNG patches [1] we use GnuTLS
functions widely. Therefore, make GnuTLS required at build time.
This enables us to drop most of #ifdef WITH_GNULS we have. Not all of
them though because we still want libvirt-setuid-rpc-client.la to build
without GnuTLS.

I should also mention that surprisingly this breaks travis. This time,
it's Ubuntu that lacks new enough GnuTLS and not OSX. But after Peter's
patches travis is broken anyway (on GnuTLS).

Michal Privoznik (3):
  configure: Require GnuTLS
  build: Build gnutls related sources unconditionally
  src: Drop most of #ifdef WITH_GNUTLS

 configure.ac                        |  2 --
 m4/virt-gnutls.m4                   |  4 ---
 src/Makefile.am                     |  7 +----
 src/locking/lock_daemon.c           |  4 ---
 src/logging/log_daemon.c            |  4 ---
 src/lxc/lxc_controller.c            |  2 --
 src/qemu/qemu_migration_cookie.c    | 12 +++-----
 src/remote/remote_daemon.c          | 23 ---------------
 src/remote/remote_daemon_dispatch.c |  2 --
 src/rpc/Makefile.inc.am             | 14 ++-------
 src/rpc/virnetdaemon.h              |  4 +--
 src/rpc/virnetserver.c              |  6 ----
 src/rpc/virnetserver.h              |  6 +---
 src/rpc/virnetserverclient.c        | 57 +++----------------------------------
 src/rpc/virnetserverclient.h        |  8 ------
 src/rpc/virnetserverservice.c       | 24 ----------------
 src/rpc/virnetserverservice.h       | 10 -------
 src/util/vircrypto.c                | 43 ++--------------------------
 tests/Makefile.am                   | 12 ++------
 tests/qemuxml2argvtest.c            | 15 ----------
 tests/vircryptotest.c               | 24 +++++-----------
 tests/virfilecachetest.c            | 18 +++---------
 tests/virnetdaemontest.c            |  8 ------
 tests/virnetserverclienttest.c      |  2 --
 tests/virrandommock.c               |  8 ++----
 25 files changed, 32 insertions(+), 287 deletions(-)

-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2018-06-05 at 10:45 +0200, Michal Privoznik wrote:
> I should also mention that surprisingly this breaks travis. This time,
> it's Ubuntu that lacks new enough GnuTLS and not OSX. But after Peter's
> patches travis is broken anyway (on GnuTLS).

As mentioned elsewhere, I believe the way to go here is to just
drop Linux builds from Travis CI. They only offer Ubuntu 14.04,
which is not supported as per our support policy[1], but having
it on Travis makes it de-facto supported and holds us back.

We can have Ubuntu 16.04 and 18.04 (actual supported platforms)
builders up and running in no time in the CentOS CI environment,
once we have been assigned more hardware - or at the expense of
overall slower builds to due to overcommittment.

Either way, even taking the performance hit would IMHO be
preferable than keeping 14.04 compatibility around, especially
now that we finally managed to leave RHEL 6 behind.


[1] https://libvirt.org/platforms.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list