From nobody Thu May 2 13:53:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527696278484881.7654601438694; Wed, 30 May 2018 09:04:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4DB2D6D42; Wed, 30 May 2018 16:04:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1513100194F; Wed, 30 May 2018 16:04:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2DBEC1800FC1; Wed, 30 May 2018 16:04:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4UG4V2Z028916 for ; Wed, 30 May 2018 12:04:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 861962026609; Wed, 30 May 2018 16:04:31 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BBCD2026988 for ; Wed, 30 May 2018 16:04:31 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 30 May 2018 18:04:27 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] virDomainDefParseXML: Free @tmp when parsing genid X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 May 2018 16:04:37 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We need to free return value of virXPathString(). =3D=3D12962=3D=3D 37 bytes in 1 blocks are definitely lost in loss record 1= 56 of 331 =3D=3D12962=3D=3D at 0x4C2AF0F: malloc (vg_replace_malloc.c:299) =3D=3D12962=3D=3D by 0x91E8439: strdup (in /lib64/libc-2.25.so) =3D=3D12962=3D=3D by 0x5DBD551: virStrdup (virstring.c:977) =3D=3D12962=3D=3D by 0x5DD3E5E: virXPathString (virxml.c:84) =3D=3D12962=3D=3D by 0x5E178AB: virDomainDefParseXML (domain_conf.c:1911= 0) =3D=3D12962=3D=3D by 0x5E1E985: virDomainDefParseNode (domain_conf.c:208= 85) =3D=3D12962=3D=3D by 0x5E1E7CB: virDomainDefParse (domain_conf.c:20827) =3D=3D12962=3D=3D by 0x5E1E871: virDomainDefParseFile (domain_conf.c:208= 53) Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 27e2bd50eb..d8b4fbd6b0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19120,6 +19120,7 @@ virDomainDefParseXML(xmlDocPtr xml, "%s", _("malformed genid element")); goto error; } + VIR_FREE(tmp); } } VIR_FREE(nodes); --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu May 2 13:53:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527696281870204.57949473956376; Wed, 30 May 2018 09:04:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 466ED30BFEC0; Wed, 30 May 2018 16:04:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F291717D84; Wed, 30 May 2018 16:04:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 84FFF1800C9C; Wed, 30 May 2018 16:04:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4UG4WHs028927 for ; Wed, 30 May 2018 12:04:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 270DD2026DFD; Wed, 30 May 2018 16:04:32 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id C12E72026DEF for ; Wed, 30 May 2018 16:04:31 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 30 May 2018 18:04:28 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] qemuxml2argvtest: Don't initialize qemuCaps twice X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 30 May 2018 16:04:41 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There's no point in calling testInitQEMUCaps() (which sets info.qemuCaps) only to overwrite (and leak) it on the very next line. =3D=3D12962=3D=3D 296 (208 direct, 88 indirect) bytes in 1 blocks are defin= itely lost in loss record 265 of 331 =3D=3D12962=3D=3D at 0x4C2CF26: calloc (vg_replace_malloc.c:711) =3D=3D12962=3D=3D by 0x5D28D9F: virAllocVar (viralloc.c:560) =3D=3D12962=3D=3D by 0x5D96AB4: virObjectNew (virobject.c:239) =3D=3D12962=3D=3D by 0x56DB7C7: virQEMUCapsNew (qemu_capabilities.c:1480) =3D=3D12962=3D=3D by 0x112A5B: testInitQEMUCaps (qemuxml2argvtest.c:361) =3D=3D12962=3D=3D by 0x1371C8: mymain (qemuxml2argvtest.c:2871) =3D=3D12962=3D=3D by 0x13AD0B: virTestMain (testutils.c:1120) =3D=3D12962=3D=3D by 0x1372FD: main (qemuxml2argvtest.c:2883) Signed-off-by: Michal Privoznik --- tests/qemuxml2argvtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index ddd2b88c0a..6f421ce8f5 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -699,8 +699,6 @@ mymain(void) (flags), parseFlags, false, NULL \ }; \ info.skipLegacyCPUs =3D skipLegacyCPUs; \ - if (testInitQEMUCaps(&info, gic) < 0) \ - return EXIT_FAILURE; \ if (!(info.qemuCaps =3D qemuTestParseCapabilitiesArch(virArchFromS= tring(arch), \ capsfile))) \ return EXIT_FAILURE; \ --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu May 2 13:53:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527696277900297.29572230254246; Wed, 30 May 2018 09:04:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5799710F2B; Wed, 30 May 2018 16:04:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15D0B2010CE3; Wed, 30 May 2018 16:04:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9E2D2180BA80; Wed, 30 May 2018 16:04:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4UG4WKS028930 for ; Wed, 30 May 2018 12:04:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD0412026DFD; Wed, 30 May 2018 16:04:32 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 623C62026DEF for ; Wed, 30 May 2018 16:04:32 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 30 May 2018 18:04:29 +0200 Message-Id: <6115036a92a890b3a22841125096fbaa93f30d0c.1527696206.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] virQEMUCapsSetHostModel: Free cpuData before setting it X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 30 May 2018 16:04:37 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" While this leak happens in tests only, it is still worth fixing. =3D=3D12962=3D=3D 2,035 (104 direct, 1,931 indirect) bytes in 1 blocks are = definitely lost in loss record 325 of 331 =3D=3D12962=3D=3D at 0x4C2CF26: calloc (vg_replace_malloc.c:711) =3D=3D12962=3D=3D by 0x5D285D5: virAlloc (viralloc.c:144) =3D=3D12962=3D=3D by 0x5E823EB: virCPUGetHost (cpu.c:411) =3D=3D12962=3D=3D by 0x56DE953: virQEMUCapsInitHostCPUModel (qemu_capabi= lities.c:2874) =3D=3D12962=3D=3D by 0x56E062F: virQEMUCapsLoadCache (qemu_capabilities.= c:3435) =3D=3D12962=3D=3D by 0x13802F: qemuTestParseCapabilitiesArch (testutilsq= emu.c:500) =3D=3D12962=3D=3D by 0x1371F0: mymain (qemuxml2argvtest.c:2871) =3D=3D12962=3D=3D by 0x13AD0B: virTestMain (testutils.c:1120) =3D=3D12962=3D=3D by 0x1372FD: main (qemuxml2argvtest.c:2883) Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e2e76e4dd8..9ec9089d5b 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1857,6 +1857,10 @@ virQEMUCapsSetHostModel(virQEMUCapsPtr qemuCaps, { virQEMUCapsHostCPUDataPtr cpuData =3D virQEMUCapsGetHostCPUData(qemuCa= ps, type); =20 + virCPUDefFree(cpuData->reported); + virCPUDefFree(cpuData->migratable); + virCPUDefFree(cpuData->full); + cpuData->reported =3D reported; cpuData->migratable =3D migratable; cpuData->full =3D full; --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list