Changeset
src/util/virutil.c | 2 --
1 file changed, 2 deletions(-)
Git apply log
Switched to a new branch 'cover.1526043717.git.jtomko@redhat.com'
Applying: virutil.c: do not include ioctl.h
Applying: virutil.c: do not include stdarg.h
To https://github.com/patchew-project/libvirt
 * [new tag]         patchew/cover.1526043717.git.jtomko@redhat.com -> patchew/cover.1526043717.git.jtomko@redhat.com
Test passed: syntax-check

loading

[libvirt] [PATCH 0/2] Some include cleanups
Posted by Ján Tomko, 1 week ago
Ján Tomko (2):
  virutil.c: do not include ioctl.h
  virutil.c: do not include stdarg.h

 src/util/virutil.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 1/2] virutil.c: do not include ioctl.h
Posted by Ján Tomko, 1 week ago
Added by commit 61674cc, but we have started using
set_nonblocking_flag from gnulib incommit da3c4714

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/util/virutil.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/virutil.c b/src/util/virutil.c
index cd6fbf2f30..4b03fe60eb 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -42,7 +42,6 @@
 #endif
 
 #include <sys/types.h>
-#include <sys/ioctl.h>
 #include <string.h>
 #include <termios.h>
 
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/2] virutil.c: do not include ioctl.h
Posted by Peter Krempa, 1 week ago
On Fri, May 11, 2018 at 15:02:15 +0200, J�n Tomko wrote:
> Added by commit 61674cc, but we have started using
> set_nonblocking_flag from gnulib incommit da3c4714

s/incommit/in commit/

Wow, that's some pro-level archaeology.

> 
> Signed-off-by: J�n Tomko <jtomko@redhat.com>
> ---
>  src/util/virutil.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/util/virutil.c b/src/util/virutil.c
> index cd6fbf2f30..4b03fe60eb 100644
> --- a/src/util/virutil.c
> +++ b/src/util/virutil.c
> @@ -42,7 +42,6 @@
>  #endif
>  
>  #include <sys/types.h>
> -#include <sys/ioctl.h>
>  #include <string.h>
>  #include <termios.h>

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 2/2] virutil.c: do not include stdarg.h
Posted by Ján Tomko, 1 week ago
Last functions using it were moved to virfile.c in commit <bfe7721>.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/util/virutil.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/virutil.c b/src/util/virutil.c
index 4b03fe60eb..bb4474acd5 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -28,7 +28,6 @@
 
 #include <stdlib.h>
 #include <stdio.h>
-#include <stdarg.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <errno.h>
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] virutil.c: do not include stdarg.h
Posted by Peter Krempa, 1 week ago
On Fri, May 11, 2018 at 15:02:16 +0200, J�n Tomko wrote:
> Last functions using it were moved to virfile.c in commit <bfe7721>.
> 
> Signed-off-by: J�n Tomko <jtomko@redhat.com>
> ---
>  src/util/virutil.c | 1 -
>  1 file changed, 1 deletion(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list