random fixes | Patchew

[libvirt] [dbus PATCH 0/9] random fixes

Posted by Pavel Hrdina 5 years, 11 months ago

*** BLURB HERE ***

Pavel Hrdina (9):
  Process input arguments before getting libvirt object
  Use ++ operator instead of += in for loop
  connect: Fix List* methods to return empty array for empty list
  connect: Pass error into virtDBusConnectOpen function
  domain: There is no need to check ret again
  domain: Return error if libvirt API fails
  domain: Introduce virtDBusDomainGVariantToMountpoints helper
  domain: Introduce virtDBusDomainGVariantToCpumap helper
  util: Use spaces around operators

 src/connect.c |  28 ++++++---------
 src/domain.c  | 110 ++++++++++++++++++++++++++++------------------------------
 src/main.c    |   2 +-
 src/network.c |   2 +-
 src/util.c    |   6 ++--
 5 files changed, 70 insertions(+), 78 deletions(-)

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 0/9] random fixes

Posted by Katerina Koukiou 5 years, 11 months ago

On Mon, 2018-05-07 at 12:06 +0200, Pavel Hrdina wrote:
> *** BLURB HERE ***
> 
> Pavel Hrdina (9):
>   Process input arguments before getting libvirt object
>   Use ++ operator instead of += in for loop
>   connect: Fix List* methods to return empty array for empty list
>   connect: Pass error into virtDBusConnectOpen function
>   domain: There is no need to check ret again
>   domain: Return error if libvirt API fails
>   domain: Introduce virtDBusDomainGVariantToMountpoints helper
>   domain: Introduce virtDBusDomainGVariantToCpumap helper
>   util: Use spaces around operators
> 
>  src/connect.c |  28 ++++++---------
>  src/domain.c  | 110 ++++++++++++++++++++++++++++------------------
> ------------
>  src/main.c    |   2 +-
>  src/network.c |   2 +-
>  src/util.c    |   6 ++--
>  5 files changed, 70 insertions(+), 78 deletions(-)
> 
Thanks for the fixes. ACK whole patchset.

Katerina

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list