From nobody Mon Apr 29 13:18:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152403869209322.561828131445054; Wed, 18 Apr 2018 01:04:52 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8AC3731327F8; Wed, 18 Apr 2018 08:04:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 613F16C320; Wed, 18 Apr 2018 08:04:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6EBA61806102; Wed, 18 Apr 2018 08:04:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3I84j2s000458 for ; Wed, 18 Apr 2018 04:04:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id BAC9A2026E04; Wed, 18 Apr 2018 08:04:45 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D3E32023229 for ; Wed, 18 Apr 2018 08:04:45 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 18 Apr 2018 10:04:41 +0200 Message-Id: <1c36a59b020fa4f938a05a400f727a1c6d2c0d48.1524038626.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] virmocklibxl.c: Fix include of virfile.h X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 18 Apr 2018 08:04:51 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Firstly, this isn't supposed to be in angle brackets because it's not a system header file (not that gcc distinguishes these two, it's just guide for us developers). Secondly, no need to use util/ path prefix because CFLAGS already contain -I$(srcdir)/util. The include is needed because virmocklibxl is mocking virFileMakePath() and even when VIR_MOCK_IMPL_RET_ARGS() does forward declaration to shut up compiler we need real virFileMakePath() declaration so that when it changes compiler catches mismatching declarations. Signed-off-by: Michal Privoznik --- tests/virmocklibxl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virmocklibxl.c b/tests/virmocklibxl.c index 50ae25810f..546c6d6a43 100644 --- a/tests/virmocklibxl.c +++ b/tests/virmocklibxl.c @@ -27,11 +27,12 @@ # include # include # include -# include # include # include # include =20 +# include "virfile.h" + VIR_MOCK_IMPL_RET_VOID(xs_daemon_open, struct xs_handle *) { --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 13:18:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524038691984385.7556968842123; Wed, 18 Apr 2018 01:04:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99E393004408; Wed, 18 Apr 2018 08:04:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F46C6C321; Wed, 18 Apr 2018 08:04:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ECCE14CA99; Wed, 18 Apr 2018 08:04:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3I84kE3000470 for ; Wed, 18 Apr 2018 04:04:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5CCCC2023227; Wed, 18 Apr 2018 08:04:46 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01306202660D for ; Wed, 18 Apr 2018 08:04:45 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 18 Apr 2018 10:04:42 +0200 Message-Id: <2a7845b55def7e4dc1112a0a59305422cc1b35fb.1524038626.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] tests: Compile and link virmocklibxl with libxml X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 18 Apr 2018 08:04:51 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Michal Privoznik --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8c4b6c2206..7b93fbde69 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -528,7 +528,7 @@ libxlxml2domconfigtest_LDADD =3D $(libxl_LDADDS) $(LIBX= ML_LIBS) =20 virmocklibxl_la_SOURCES =3D \ virmocklibxl.c -virmocklibxl_la_CFLAGS =3D $(LIBXL_CFLAGS) +virmocklibxl_la_CFLAGS =3D $(LIBXL_CFLAGS) $(LIBXML_CFLAGS) virmocklibxl_la_LDFLAGS =3D $(MOCKLIBS_LDFLAGS) virmocklibxl_la_LIBADD =3D $(MOCKLIBS_LIBS) =20 --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list